Leo Hemsted 6784ae62a6 Raise Exception if letter PDF not in S3 ...

Previously, the function would just return a presumed filename. Now that
it actually checks s3, if the file doesn't exist it'll raise an
exception. By default that's a StopIteration at the end of the bucket
iterator, which isn't ideal as this will get supressed if the function
is called within a generator loop further up or anything.

There are a couple of places where we expect the file may not exist, so
we define a custom exception to rescue specifically here. I did consider
subclassing boto's ClientError, but this wasn't straightforward as the
constructor expects to know the operation that failed, which for me is a
signal that it's not an appropriate (re-)use of the class.

2021-03-15 17:18:11 +00:00

..

__init__.py

…

letter_schemas.py

Remove letter_job_ids schema

2018-11-16 13:04:49 +00:00

rest.py

Run auto-correct on app/ and tests/

2021-03-12 11:45:45 +00:00

utils.py

Raise Exception if letter PDF not in S3

2021-03-15 17:18:11 +00:00