mirror of
https://github.com/GSA/notifications-api.git
synced 2025-12-21 07:51:13 -05:00
bbc444699a
If someone tries to cancel a broadcast but the references don’t match and existing broadcast we correctly return a 404. If they don’t provide any references then we get an exception. This commit catches the missing references and returns a 400. I think this is more appropriate because it’s malformed request, rather than a well-formed request that doesn’t match our data. It also lets us write a more specific and helpful error message.
38 lines
1.2 KiB
Python
38 lines
1.2 KiB
Python
from bs4 import BeautifulSoup
|
||
|
||
|
||
def cap_xml_to_dict(cap_xml):
|
||
# This function assumes that it’s being passed valid CAP XML
|
||
cap = BeautifulSoup(cap_xml, "xml")
|
||
return {
|
||
"msgType": cap.alert.msgType.text,
|
||
"reference": cap.alert.identifier.text,
|
||
"references": (
|
||
# references to previous events belonging to the same alert
|
||
cap.alert.references.text if cap.alert.references else None
|
||
),
|
||
"cap_event": cap.alert.info.event.text,
|
||
"category": cap.alert.info.category.text,
|
||
"expires": cap.alert.info.expires.text,
|
||
"content": cap.alert.info.description.text,
|
||
"areas": [
|
||
{
|
||
"name": area.areaDesc.text,
|
||
"polygons": [
|
||
cap_xml_polygon_to_list(polygon.text)
|
||
for polygon in area.find_all('polygon')
|
||
]
|
||
}
|
||
for area in cap.alert.info.find_all('area')
|
||
]
|
||
}
|
||
|
||
|
||
def cap_xml_polygon_to_list(polygon_string):
|
||
return [
|
||
[
|
||
float(coordinate) for coordinate in pair.split(',')
|
||
]
|
||
for pair in polygon_string.strip().split(' ')
|
||
]
|