Ben Thorner 7d92a0869a Remove per-client SMS exception classes ...

In response to: [^1].

The stacktrace conveys the same and more information. We don't do
anything different for each exception class, so there's no value
in having three of them over one exception.

I did think about DRYing-up the duplicate exception behaviour into
the base class one. This isn't ideal because the base class would
be making assumptions about how inheriting classes make requests,
which might change with future providers. Although it might be nice
to have more info in the top-level message, we'll still get it in
the stacktrace e.g.

    ValueError: Expected 'code' to be '0'
    During handling of the above exception, another exception occurred:
    app.clients.sms.SmsClientResponseException: SMS client error (Invalid response JSON)

    requests.exceptions.ReadTimeout
    During handling of the above exception, another exception occurred:
    app.clients.sms.SmsClientResponseException: SMS client error (Request failed)

[^1]: https://github.com/alphagov/notifications-api/pull/3493#discussion_r837363717

2022-03-30 13:38:50 +01:00

..

app

Remove per-client SMS exception classes

2022-03-30 13:38:50 +01:00

__init__.py

DRY-up creating auth headers for requests

2021-08-04 16:06:23 +01:00

conftest.py

…

test_all_queues_used.py

…