mirror of
https://github.com/GSA/notifications-api.git
synced 2026-01-03 01:40:44 -05:00
67d1b3719e
We had an inbound number in the database with a value of ''. This could happen if there are blank lines in the inbound numbers file we use for the `insert-inbound-numbers` command. To avoid this happening again, the command now calls `.strip()` on each line of the file and only inserts a row if the result is truthy (i.e. not '').
39 lines
1.4 KiB
Python
39 lines
1.4 KiB
Python
from app.commands import (
|
|
insert_inbound_numbers_from_file,
|
|
local_dev_broadcast_permissions,
|
|
)
|
|
from app.dao.inbound_numbers_dao import dao_get_available_inbound_numbers
|
|
from app.dao.services_dao import dao_add_user_to_service
|
|
from tests.app.db import create_user
|
|
|
|
|
|
def test_insert_inbound_numbers_from_file(notify_db_session, notify_api, tmpdir):
|
|
numbers_file = tmpdir.join("numbers.txt")
|
|
numbers_file.write("07700900373\n07700900473\n07700900375\n\n\n\n")
|
|
|
|
notify_api.test_cli_runner().invoke(insert_inbound_numbers_from_file, ['-f', numbers_file])
|
|
|
|
inbound_numbers = dao_get_available_inbound_numbers()
|
|
assert len(inbound_numbers) == 3
|
|
assert set(x.number for x in inbound_numbers) == {'07700900373', '07700900473', '07700900375'}
|
|
|
|
|
|
def test_local_dev_broadcast_permissions(
|
|
sample_service,
|
|
sample_broadcast_service,
|
|
notify_api,
|
|
):
|
|
user = create_user()
|
|
dao_add_user_to_service(sample_service, user)
|
|
dao_add_user_to_service(sample_broadcast_service, user)
|
|
|
|
assert len(user.get_permissions(sample_service.id)) == 0
|
|
assert len(user.get_permissions(sample_broadcast_service.id)) == 0
|
|
|
|
notify_api.test_cli_runner().invoke(
|
|
local_dev_broadcast_permissions, ['-u', user.id]
|
|
)
|
|
|
|
assert len(user.get_permissions(sample_service.id)) == 0
|
|
assert len(user.get_permissions(sample_broadcast_service.id)) > 0
|