mirror of
https://github.com/GSA/notifications-api.git
synced 2026-04-02 00:20:47 -04:00
6181c60f75
* notify_db fixture creates the database connection and ensures the test db exists and has migrations applied etc. It will run once per session (test run). * notify_db_session fixture runs after your test finishes and deletes all non static (eg type table) data. In unit tests that hit the database (ie: most of them), 99% of the time we will need to use notify_db_session to ensure everything is reset. The only time we don't need to use it is when we're querying things such as "ensure get X works when database is empty". This is such a low percentage of tests that it's easier for us to just use notify_db_session every time, and ensure that all our tests run much more consistently, at the cost of a small bit of performance when running tests. We used to use notify_db to access the session object for manually adding, committing, etc. To dissuade usage of that fixture I've moved that to the `notify_db_session`. I've then removed all uses of notify_db that I could find in the codebase. As a note, if you're writing a test that uses a `sample_x` fixture, all of those fixtures rely on notify_db_session so you'll get the teardown functionality for free. If you're just calling eg `create_x` db.py functions, then you'll need to make you add notify_db_session fixture to your test, even if you aren't manually accessing the session.
19 lines
456 B
Python
19 lines
456 B
Python
|
|
from app.dao.events_dao import dao_create_event
|
|
from app.models import Event
|
|
|
|
|
|
def test_create_event(notify_db_session):
|
|
assert Event.query.count() == 0
|
|
data = {
|
|
'event_type': 'sucessful_login',
|
|
'data': {'something': 'random', 'in_fact': 'could be anything'}
|
|
}
|
|
|
|
event = Event(**data)
|
|
dao_create_event(event)
|
|
|
|
assert Event.query.count() == 1
|
|
event_from_db = Event.query.first()
|
|
assert event == event_from_db
|