mirror of
https://github.com/GSA/notifications-api.git
synced 2026-04-12 13:19:30 -04:00
bdf2253298
use the new endpoint from cbc proxy. create a new task that just serializes the event and sends it across rather than sending a template and the broadcast message. some changes to serialize to make it json friendly etc. it also expects sent_at and transmitted_finishes_at to always be set (we set them in the code but don't enforce it n the DB right now), as they're required by utils template. not sure whether we'll update db constraints to be more strict or utils template to be more permissive just yet, wait until we find out more about the requirements of the CBCs we integrate with.
119 lines
5.9 KiB
Python
119 lines
5.9 KiB
Python
from freezegun import freeze_time
|
|
import pytest
|
|
import requests_mock
|
|
from requests import RequestException
|
|
|
|
from app.dao.templates_dao import dao_update_template
|
|
from app.models import BROADCAST_TYPE, BroadcastStatusType, BroadcastEventMessageType
|
|
from app.celery.broadcast_message_tasks import send_broadcast_message, send_broadcast_event
|
|
from tests.app.db import create_template, create_broadcast_message, create_broadcast_event
|
|
|
|
|
|
def test_send_broadcast_message_sends_data_correctly(sample_service):
|
|
template = create_template(sample_service, BROADCAST_TYPE)
|
|
broadcast_message = create_broadcast_message(template, areas=['london'], status=BroadcastStatusType.BROADCASTING)
|
|
|
|
with requests_mock.Mocker() as request_mock:
|
|
request_mock.post("http://test-cbc-proxy/broadcasts/stub-1", json={'valid': 'true'}, status_code=200)
|
|
send_broadcast_message(broadcast_message_id=str(broadcast_message.id))
|
|
|
|
assert request_mock.call_count == 1
|
|
assert request_mock.request_history[0].method == 'POST'
|
|
assert request_mock.request_history[0].headers["Content-type"] == "application/json"
|
|
|
|
cbc_json = request_mock.request_history[0].json()
|
|
assert cbc_json['template']['id'] == str(template.id)
|
|
assert cbc_json['template']['template_type'] == BROADCAST_TYPE
|
|
assert cbc_json['broadcast_message']['areas'] == ['london']
|
|
|
|
|
|
def test_send_broadcast_message_sends_old_version_of_template(sample_service):
|
|
template = create_template(sample_service, BROADCAST_TYPE, content='first content')
|
|
broadcast_message = create_broadcast_message(template, areas=['london'], status=BroadcastStatusType.BROADCASTING)
|
|
|
|
template.content = 'second content'
|
|
dao_update_template(template)
|
|
assert template.version == 2
|
|
|
|
with requests_mock.Mocker() as request_mock:
|
|
request_mock.post("http://test-cbc-proxy/broadcasts/stub-1", json={'valid': 'true'}, status_code=200)
|
|
send_broadcast_message(broadcast_message_id=str(broadcast_message.id))
|
|
|
|
assert request_mock.call_count == 1
|
|
assert request_mock.request_history[0].method == 'POST'
|
|
assert request_mock.request_history[0].headers["Content-type"] == "application/json"
|
|
|
|
cbc_json = request_mock.request_history[0].json()
|
|
assert cbc_json['template']['id'] == str(template.id)
|
|
assert cbc_json['template']['version'] == 1
|
|
assert cbc_json['template']['content'] == 'first content'
|
|
|
|
|
|
def test_send_broadcast_message_errors(sample_service):
|
|
template = create_template(sample_service, BROADCAST_TYPE)
|
|
broadcast_message = create_broadcast_message(template, status=BroadcastStatusType.BROADCASTING)
|
|
|
|
with requests_mock.Mocker() as request_mock:
|
|
request_mock.post("http://test-cbc-proxy/broadcasts/stub-1", text='503 bad gateway', status_code=503)
|
|
# we're not retrying or anything for the moment - but this'll ensure any exception gets logged
|
|
with pytest.raises(RequestException) as ex:
|
|
send_broadcast_message(broadcast_message_id=str(broadcast_message.id))
|
|
|
|
assert ex.value.response.status_code == 503
|
|
|
|
|
|
@freeze_time('2020-08-01 12:00')
|
|
def test_send_broadcast_event_sends_data_correctly(sample_service):
|
|
template = create_template(sample_service, BROADCAST_TYPE)
|
|
broadcast_message = create_broadcast_message(template, areas=['london'], status=BroadcastStatusType.BROADCASTING)
|
|
event = create_broadcast_event(broadcast_message)
|
|
|
|
with requests_mock.Mocker() as request_mock:
|
|
request_mock.post("http://test-cbc-proxy/broadcasts/events/stub-1", json={'valid': 'true'}, status_code=200)
|
|
send_broadcast_event(broadcast_event_id=str(event.id))
|
|
|
|
assert request_mock.call_count == 1
|
|
assert request_mock.request_history[0].method == 'POST'
|
|
assert request_mock.request_history[0].headers["Content-type"] == "application/json"
|
|
|
|
cbc_json = request_mock.request_history[0].json()
|
|
assert cbc_json['id'] == str(event.id)
|
|
assert cbc_json['broadcast_message_id'] == str(broadcast_message.id)
|
|
assert cbc_json['sent_at'] == '2020-08-01T12:00:00.000000Z'
|
|
assert cbc_json['transmitted_starts_at'] is None
|
|
assert cbc_json['transmitted_areas'] == ['london']
|
|
|
|
|
|
def test_send_broadcast_event_sends_references(sample_service):
|
|
template = create_template(sample_service, BROADCAST_TYPE, content='content')
|
|
broadcast_message = create_broadcast_message(template, areas=['london'], status=BroadcastStatusType.BROADCASTING)
|
|
alert_event = create_broadcast_event(broadcast_message, message_type=BroadcastEventMessageType.ALERT)
|
|
cancel_event = create_broadcast_event(broadcast_message, message_type=BroadcastEventMessageType.CANCEL)
|
|
|
|
with requests_mock.Mocker() as request_mock:
|
|
request_mock.post("http://test-cbc-proxy/broadcasts/events/stub-1", json={'valid': 'true'}, status_code=200)
|
|
send_broadcast_event(broadcast_event_id=str(cancel_event.id))
|
|
|
|
assert request_mock.call_count == 1
|
|
assert request_mock.request_history[0].method == 'POST'
|
|
assert request_mock.request_history[0].headers["Content-type"] == "application/json"
|
|
|
|
cbc_json = request_mock.request_history[0].json()
|
|
assert cbc_json['id'] == str(cancel_event.id)
|
|
assert cbc_json['message_type'] == cancel_event.message_type
|
|
assert cbc_json['previous_event_references'] == [alert_event.reference]
|
|
|
|
|
|
def test_send_broadcast_event_errors(sample_service):
|
|
template = create_template(sample_service, BROADCAST_TYPE)
|
|
broadcast_message = create_broadcast_message(template, status=BroadcastStatusType.BROADCASTING)
|
|
event = create_broadcast_event(broadcast_message)
|
|
|
|
with requests_mock.Mocker() as request_mock:
|
|
request_mock.post("http://test-cbc-proxy/broadcasts/events/stub-1", text='503 bad gateway', status_code=503)
|
|
# we're not retrying or anything for the moment - but this'll ensure any exception gets logged
|
|
with pytest.raises(RequestException) as ex:
|
|
send_broadcast_event(broadcast_event_id=str(event.id))
|
|
|
|
assert ex.value.response.status_code == 503
|