mirror of
https://github.com/GSA/notifications-api.git
synced 2026-07-30 11:18:54 -04:00
7d92a0869a
In response to: [^1].
The stacktrace conveys the same and more information. We don't do
anything different for each exception class, so there's no value
in having three of them over one exception.
I did think about DRYing-up the duplicate exception behaviour into
the base class one. This isn't ideal because the base class would
be making assumptions about how inheriting classes make requests,
which might change with future providers. Although it might be nice
to have more info in the top-level message, we'll still get it in
the stacktrace e.g.
ValueError: Expected 'code' to be '0'
During handling of the above exception, another exception occurred:
app.clients.sms.SmsClientResponseException: SMS client error (Invalid response JSON)
requests.exceptions.ReadTimeout
During handling of the above exception, another exception occurred:
app.clients.sms.SmsClientResponseException: SMS client error (Request failed)
[^1]: https://github.com/alphagov/notifications-api/pull/3493#discussion_r837363717
53 lines
1.4 KiB
Python
53 lines
1.4 KiB
Python
import json
|
|
|
|
from requests import RequestException, request
|
|
|
|
from app.clients.sms import SmsClient, SmsClientResponseException
|
|
|
|
|
|
def get_reach_responses(status, detailed_status_code=None):
|
|
if status == 'TODO-d':
|
|
return ("delivered", "TODO: Delivered")
|
|
elif status == 'TODO-tf':
|
|
return ("temporary-failure", "TODO: Temporary failure")
|
|
elif status == 'TODO-pf':
|
|
return ("permanent-failure", "TODO: Permanent failure")
|
|
else:
|
|
raise KeyError
|
|
|
|
|
|
class ReachClient(SmsClient):
|
|
def init_app(self, *args, **kwargs):
|
|
super().init_app(*args, **kwargs)
|
|
self.url = self.current_app.config.get('REACH_URL')
|
|
|
|
@property
|
|
def name(self):
|
|
return 'reach'
|
|
|
|
def try_send_sms(self, to, content, reference, international, sender):
|
|
data = {
|
|
# TODO
|
|
}
|
|
|
|
try:
|
|
response = request(
|
|
"POST",
|
|
self.url,
|
|
data=json.dumps(data),
|
|
headers={
|
|
'Content-Type': 'application/json',
|
|
},
|
|
timeout=60
|
|
)
|
|
|
|
response.raise_for_status()
|
|
try:
|
|
json.loads(response.text)
|
|
except (ValueError, AttributeError):
|
|
raise SmsClientResponseException("Invalid response JSON")
|
|
except RequestException:
|
|
raise SmsClientResponseException("Request failed")
|
|
|
|
return response
|