mirror of
https://github.com/GSA/notifications-api.git
synced 2025-12-14 09:12:06 -05:00
1. The number of letters that we send to DVLA will be not be correct (see20ead82463/app/celery/letters_pdf_tasks.py (L136)) This may raise an alert with DVLA when they find we have sent them fewer letter than we have reported. 2. When we get the PDF from S3 we will get a file not found20ead82463/app/celery/letters_pdf_tasks.py (L244)The error will not prevent the collate task from completing but we will see an alert email for the exception and raise questions. Although this situation is very unlikely because we have a 15 minute window between the last letter deadline date and the time we kick off the collate task we should still mitigate these issues. I updated the queries to only return letters with billable_units > 0, all valid letters should have at least 1 billable unit.
508 lines
18 KiB
Python
508 lines
18 KiB
Python
import base64
|
|
import functools
|
|
import uuid
|
|
from datetime import datetime
|
|
|
|
import botocore
|
|
from flask import abort, current_app, jsonify, request
|
|
from gds_metrics import Histogram
|
|
from notifications_utils.recipients import try_validate_and_format_phone_number
|
|
|
|
from app import (
|
|
api_user,
|
|
authenticated_service,
|
|
document_download_client,
|
|
encryption,
|
|
notify_celery,
|
|
)
|
|
from app.celery.letters_pdf_tasks import (
|
|
get_pdf_for_templated_letter,
|
|
sanitise_letter,
|
|
)
|
|
from app.celery.research_mode_tasks import create_fake_letter_response_file
|
|
from app.celery.tasks import save_api_email, save_api_sms
|
|
from app.clients.document_download import DocumentDownloadError
|
|
from app.config import QueueNames, TaskNames
|
|
from app.dao.dao_utils import transaction
|
|
from app.dao.templates_dao import get_precompiled_letter_template
|
|
from app.letters.utils import upload_letter_pdf
|
|
from app.models import (
|
|
EMAIL_TYPE,
|
|
KEY_TYPE_NORMAL,
|
|
KEY_TYPE_TEAM,
|
|
KEY_TYPE_TEST,
|
|
LETTER_TYPE,
|
|
NOTIFICATION_CREATED,
|
|
NOTIFICATION_DELIVERED,
|
|
NOTIFICATION_PENDING_VIRUS_CHECK,
|
|
NOTIFICATION_SENDING,
|
|
PRIORITY,
|
|
SMS_TYPE,
|
|
Notification,
|
|
)
|
|
from app.notifications.process_letter_notifications import (
|
|
create_letter_notification,
|
|
)
|
|
from app.notifications.process_notifications import (
|
|
persist_notification,
|
|
send_notification_to_queue_detached,
|
|
simulated_recipient,
|
|
)
|
|
from app.notifications.validators import (
|
|
check_if_service_can_send_files_by_email,
|
|
check_is_message_too_long,
|
|
check_rate_limiting,
|
|
check_service_email_reply_to_id,
|
|
check_service_has_permission,
|
|
check_service_sms_sender_id,
|
|
validate_address,
|
|
validate_and_format_recipient,
|
|
validate_template,
|
|
)
|
|
from app.schema_validation import validate
|
|
from app.utils import DATETIME_FORMAT
|
|
from app.v2.errors import BadRequestError
|
|
from app.v2.notifications import v2_notification_blueprint
|
|
from app.v2.notifications.create_response import (
|
|
create_post_email_response_from_notification,
|
|
create_post_letter_response_from_notification,
|
|
create_post_sms_response_from_notification,
|
|
)
|
|
from app.v2.notifications.notification_schemas import (
|
|
post_email_request,
|
|
post_letter_request,
|
|
post_precompiled_letter_request,
|
|
post_sms_request,
|
|
)
|
|
from app.v2.utils import get_valid_json
|
|
|
|
POST_NOTIFICATION_JSON_PARSE_DURATION_SECONDS = Histogram(
|
|
'post_notification_json_parse_duration_seconds',
|
|
'Time taken to parse and validate post request json',
|
|
)
|
|
|
|
|
|
@v2_notification_blueprint.route('/{}'.format(LETTER_TYPE), methods=['POST'])
|
|
def post_precompiled_letter_notification():
|
|
request_json = get_valid_json()
|
|
if 'content' not in (request_json or {}):
|
|
return post_notification(LETTER_TYPE)
|
|
|
|
form = validate(request_json, post_precompiled_letter_request)
|
|
|
|
# Check permission to send letters
|
|
check_service_has_permission(LETTER_TYPE, authenticated_service.permissions)
|
|
|
|
check_rate_limiting(authenticated_service, api_user)
|
|
|
|
template = get_precompiled_letter_template(authenticated_service.id)
|
|
|
|
# For precompiled letters the to field will be set to Provided as PDF until the validation passes,
|
|
# then the address of the letter will be set as the to field
|
|
form['personalisation'] = {
|
|
'address_line_1': 'Provided as PDF'
|
|
}
|
|
|
|
notification = process_letter_notification(
|
|
letter_data=form,
|
|
api_key=api_user,
|
|
service=authenticated_service,
|
|
template=template,
|
|
template_with_content=None, # not required for precompiled
|
|
reply_to_text='', # not required for precompiled
|
|
precompiled=True
|
|
)
|
|
|
|
return jsonify(notification), 201
|
|
|
|
|
|
@v2_notification_blueprint.route('/<notification_type>', methods=['POST'])
|
|
def post_notification(notification_type):
|
|
with POST_NOTIFICATION_JSON_PARSE_DURATION_SECONDS.time():
|
|
request_json = get_valid_json()
|
|
|
|
if notification_type == EMAIL_TYPE:
|
|
form = validate(request_json, post_email_request)
|
|
elif notification_type == SMS_TYPE:
|
|
form = validate(request_json, post_sms_request)
|
|
elif notification_type == LETTER_TYPE:
|
|
form = validate(request_json, post_letter_request)
|
|
else:
|
|
abort(404)
|
|
|
|
check_service_has_permission(notification_type, authenticated_service.permissions)
|
|
|
|
check_rate_limiting(authenticated_service, api_user)
|
|
|
|
template, template_with_content = validate_template(
|
|
form['template_id'],
|
|
form.get('personalisation', {}),
|
|
authenticated_service,
|
|
notification_type,
|
|
check_char_count=False
|
|
)
|
|
|
|
reply_to = get_reply_to_text(notification_type, form, template)
|
|
|
|
if notification_type == LETTER_TYPE:
|
|
notification = process_letter_notification(
|
|
letter_data=form,
|
|
api_key=api_user,
|
|
service=authenticated_service,
|
|
template=template,
|
|
template_with_content=template_with_content,
|
|
reply_to_text=reply_to
|
|
)
|
|
else:
|
|
notification = process_sms_or_email_notification(
|
|
form=form,
|
|
notification_type=notification_type,
|
|
template=template,
|
|
template_with_content=template_with_content,
|
|
template_process_type=template.process_type,
|
|
service=authenticated_service,
|
|
reply_to_text=reply_to
|
|
)
|
|
|
|
return jsonify(notification), 201
|
|
|
|
|
|
def process_sms_or_email_notification(
|
|
*,
|
|
form,
|
|
notification_type,
|
|
template,
|
|
template_with_content,
|
|
template_process_type,
|
|
service,
|
|
reply_to_text=None,
|
|
):
|
|
notification_id = uuid.uuid4()
|
|
form_send_to = form['email_address'] if notification_type == EMAIL_TYPE else form['phone_number']
|
|
|
|
send_to = validate_and_format_recipient(send_to=form_send_to,
|
|
key_type=api_user.key_type,
|
|
service=service,
|
|
notification_type=notification_type)
|
|
|
|
# Do not persist or send notification to the queue if it is a simulated recipient
|
|
simulated = simulated_recipient(send_to, notification_type)
|
|
|
|
personalisation, document_download_count = process_document_uploads(
|
|
form.get('personalisation'),
|
|
service,
|
|
simulated=simulated
|
|
)
|
|
if document_download_count:
|
|
# We changed personalisation which means we need to update the content
|
|
template_with_content.values = personalisation
|
|
|
|
# validate content length after url is replaced in personalisation.
|
|
check_is_message_too_long(template_with_content)
|
|
|
|
resp = create_response_for_post_notification(
|
|
notification_id=notification_id,
|
|
client_reference=form.get('reference', None),
|
|
template_id=template.id,
|
|
template_version=template.version,
|
|
service_id=service.id,
|
|
notification_type=notification_type,
|
|
reply_to=reply_to_text,
|
|
template_with_content=template_with_content
|
|
)
|
|
|
|
if service.high_volume \
|
|
and api_user.key_type == KEY_TYPE_NORMAL \
|
|
and notification_type in [EMAIL_TYPE, SMS_TYPE]:
|
|
# Put service with high volumes of notifications onto a queue
|
|
# To take the pressure off the db for API requests put the notification for our high volume service onto a queue
|
|
# the task will then save the notification, then call send_notification_to_queue.
|
|
# NOTE: The high volume service should be aware that the notification is not immediately
|
|
# available by a GET request, it is recommend they use callbacks to keep track of status updates.
|
|
try:
|
|
save_email_or_sms_to_queue(
|
|
form=form,
|
|
notification_id=str(notification_id),
|
|
notification_type=notification_type,
|
|
api_key=api_user,
|
|
template=template,
|
|
service_id=service.id,
|
|
personalisation=personalisation,
|
|
document_download_count=document_download_count,
|
|
reply_to_text=reply_to_text
|
|
)
|
|
return resp
|
|
except (botocore.exceptions.ClientError, botocore.parsers.ResponseParserError):
|
|
# If SQS cannot put the task on the queue, it's probably because the notification body was too long and it
|
|
# went over SQS's 256kb message limit. If the body is very large, it may exceed the HTTP max content length;
|
|
# the exception we get here isn't handled correctly by botocore - we get a ResponseParserError instead.
|
|
current_app.logger.info(
|
|
f'Notification {notification_id} failed to save to high volume queue. Using normal flow instead'
|
|
)
|
|
|
|
persist_notification(
|
|
notification_id=notification_id,
|
|
template_id=template.id,
|
|
template_version=template.version,
|
|
recipient=form_send_to,
|
|
service=service,
|
|
personalisation=personalisation,
|
|
notification_type=notification_type,
|
|
api_key_id=api_user.id,
|
|
key_type=api_user.key_type,
|
|
client_reference=form.get('reference', None),
|
|
simulated=simulated,
|
|
reply_to_text=reply_to_text,
|
|
document_download_count=document_download_count
|
|
)
|
|
|
|
if not simulated:
|
|
queue_name = QueueNames.PRIORITY if template_process_type == PRIORITY else None
|
|
send_notification_to_queue_detached(
|
|
key_type=api_user.key_type,
|
|
notification_type=notification_type,
|
|
notification_id=notification_id,
|
|
research_mode=service.research_mode, # research_mode is deprecated
|
|
queue=queue_name
|
|
)
|
|
else:
|
|
current_app.logger.debug("POST simulated notification for id: {}".format(notification_id))
|
|
|
|
return resp
|
|
|
|
|
|
def save_email_or_sms_to_queue(
|
|
*,
|
|
notification_id,
|
|
form,
|
|
notification_type,
|
|
api_key,
|
|
template,
|
|
service_id,
|
|
personalisation,
|
|
document_download_count,
|
|
reply_to_text=None
|
|
):
|
|
data = {
|
|
"id": notification_id,
|
|
"template_id": str(template.id),
|
|
"template_version": template.version,
|
|
"to": form['email_address'] if notification_type == EMAIL_TYPE else form['phone_number'],
|
|
"service_id": str(service_id),
|
|
"personalisation": personalisation,
|
|
"notification_type": notification_type,
|
|
"api_key_id": str(api_key.id),
|
|
"key_type": api_key.key_type,
|
|
"client_reference": form.get('reference', None),
|
|
"reply_to_text": reply_to_text,
|
|
"document_download_count": document_download_count,
|
|
"status": NOTIFICATION_CREATED,
|
|
"created_at": datetime.utcnow().strftime(DATETIME_FORMAT),
|
|
}
|
|
encrypted = encryption.encrypt(
|
|
data
|
|
)
|
|
|
|
if notification_type == EMAIL_TYPE:
|
|
save_api_email.apply_async([encrypted], queue=QueueNames.SAVE_API_EMAIL)
|
|
elif notification_type == SMS_TYPE:
|
|
save_api_sms.apply_async([encrypted], queue=QueueNames.SAVE_API_SMS)
|
|
|
|
return Notification(**data)
|
|
|
|
|
|
def process_document_uploads(personalisation_data, service, simulated=False):
|
|
"""
|
|
Returns modified personalisation dict and a count of document uploads. If there are no document uploads, returns
|
|
a count of `None` rather than `0`.
|
|
"""
|
|
file_keys = [k for k, v in (personalisation_data or {}).items() if isinstance(v, dict) and 'file' in v]
|
|
if not file_keys:
|
|
return personalisation_data, None
|
|
|
|
personalisation_data = personalisation_data.copy()
|
|
|
|
check_if_service_can_send_files_by_email(
|
|
service_contact_link=authenticated_service.contact_link,
|
|
service_id=authenticated_service.id
|
|
)
|
|
|
|
for key in file_keys:
|
|
if simulated:
|
|
personalisation_data[key] = document_download_client.get_upload_url(service.id) + '/test-document'
|
|
else:
|
|
try:
|
|
personalisation_data[key] = document_download_client.upload_document(
|
|
service.id, personalisation_data[key]['file'], personalisation_data[key].get('is_csv')
|
|
)
|
|
except DocumentDownloadError as e:
|
|
raise BadRequestError(message=e.message, status_code=e.status_code)
|
|
|
|
return personalisation_data, len(file_keys)
|
|
|
|
|
|
def process_letter_notification(
|
|
*, letter_data, api_key, service, template, template_with_content, reply_to_text, precompiled=False
|
|
):
|
|
if api_key.key_type == KEY_TYPE_TEAM:
|
|
raise BadRequestError(message='Cannot send letters with a team api key', status_code=403)
|
|
|
|
if not service.research_mode and service.restricted and api_key.key_type != KEY_TYPE_TEST:
|
|
raise BadRequestError(message='Cannot send letters when service is in trial mode', status_code=403)
|
|
|
|
if precompiled:
|
|
return process_precompiled_letter_notifications(letter_data=letter_data,
|
|
api_key=api_key,
|
|
service=service,
|
|
template=template,
|
|
reply_to_text=reply_to_text)
|
|
|
|
postage = validate_address(service, letter_data['personalisation'])
|
|
|
|
test_key = api_key.key_type == KEY_TYPE_TEST
|
|
|
|
status = NOTIFICATION_CREATED
|
|
updated_at = None
|
|
if test_key:
|
|
# if we don't want to actually send the letter, then start it off in SENDING so we don't pick it up
|
|
if current_app.config['NOTIFY_ENVIRONMENT'] in ['preview', 'development']:
|
|
status = NOTIFICATION_SENDING
|
|
# mark test letter as delivered and do not create a fake response later
|
|
else:
|
|
status = NOTIFICATION_DELIVERED
|
|
updated_at = datetime.utcnow()
|
|
|
|
queue = QueueNames.CREATE_LETTERS_PDF if not test_key else QueueNames.RESEARCH_MODE
|
|
|
|
notification = create_letter_notification(letter_data=letter_data,
|
|
service=service,
|
|
template=template,
|
|
api_key=api_key,
|
|
status=status,
|
|
reply_to_text=reply_to_text,
|
|
updated_at=updated_at,
|
|
postage=postage
|
|
)
|
|
|
|
get_pdf_for_templated_letter.apply_async(
|
|
[str(notification.id)],
|
|
queue=queue
|
|
)
|
|
|
|
if test_key and current_app.config['NOTIFY_ENVIRONMENT'] in ['preview', 'development']:
|
|
create_fake_letter_response_file.apply_async(
|
|
(notification.reference,),
|
|
queue=queue
|
|
)
|
|
|
|
resp = create_response_for_post_notification(
|
|
notification_id=notification.id,
|
|
client_reference=notification.client_reference,
|
|
template_id=notification.template_id,
|
|
template_version=notification.template_version,
|
|
notification_type=notification.notification_type,
|
|
reply_to=reply_to_text,
|
|
service_id=notification.service_id,
|
|
template_with_content=template_with_content
|
|
)
|
|
return resp
|
|
|
|
|
|
def process_precompiled_letter_notifications(*, letter_data, api_key, service, template, reply_to_text):
|
|
try:
|
|
status = NOTIFICATION_PENDING_VIRUS_CHECK
|
|
letter_content = base64.b64decode(letter_data['content'])
|
|
except ValueError:
|
|
raise BadRequestError(message='Cannot decode letter content (invalid base64 encoding)', status_code=400)
|
|
|
|
with transaction():
|
|
notification = create_letter_notification(letter_data=letter_data,
|
|
service=service,
|
|
template=template,
|
|
api_key=api_key,
|
|
status=status,
|
|
reply_to_text=reply_to_text)
|
|
filename = upload_letter_pdf(notification, letter_content, precompiled=True)
|
|
|
|
resp = {
|
|
'id': notification.id,
|
|
'reference': notification.client_reference,
|
|
'postage': notification.postage
|
|
}
|
|
|
|
current_app.logger.info('Calling task scan-file for {}'.format(filename))
|
|
|
|
# call task to add the filename to anti virus queue
|
|
if current_app.config['ANTIVIRUS_ENABLED']:
|
|
notify_celery.send_task(
|
|
name=TaskNames.SCAN_FILE,
|
|
kwargs={'filename': filename},
|
|
queue=QueueNames.ANTIVIRUS,
|
|
)
|
|
else:
|
|
# stub out antivirus in dev
|
|
sanitise_letter.apply_async(
|
|
[filename],
|
|
queue=QueueNames.LETTERS
|
|
)
|
|
|
|
return resp
|
|
|
|
|
|
def get_reply_to_text(notification_type, form, template):
|
|
reply_to = None
|
|
if notification_type == EMAIL_TYPE:
|
|
service_email_reply_to_id = form.get("email_reply_to_id", None)
|
|
reply_to = check_service_email_reply_to_id(
|
|
str(authenticated_service.id), service_email_reply_to_id, notification_type
|
|
) or template.reply_to_text
|
|
|
|
elif notification_type == SMS_TYPE:
|
|
service_sms_sender_id = form.get("sms_sender_id", None)
|
|
sms_sender_id = check_service_sms_sender_id(
|
|
str(authenticated_service.id), service_sms_sender_id, notification_type
|
|
)
|
|
if sms_sender_id:
|
|
reply_to = try_validate_and_format_phone_number(sms_sender_id)
|
|
else:
|
|
reply_to = template.reply_to_text
|
|
|
|
elif notification_type == LETTER_TYPE:
|
|
reply_to = template.reply_to_text
|
|
|
|
return reply_to
|
|
|
|
|
|
def create_response_for_post_notification(
|
|
notification_id,
|
|
client_reference,
|
|
template_id,
|
|
template_version,
|
|
service_id,
|
|
notification_type,
|
|
reply_to,
|
|
template_with_content
|
|
):
|
|
if notification_type == SMS_TYPE:
|
|
create_resp_partial = functools.partial(
|
|
create_post_sms_response_from_notification,
|
|
from_number=reply_to,
|
|
)
|
|
elif notification_type == EMAIL_TYPE:
|
|
create_resp_partial = functools.partial(
|
|
create_post_email_response_from_notification,
|
|
subject=template_with_content.subject,
|
|
email_from='{}@{}'.format(authenticated_service.email_from, current_app.config['NOTIFY_EMAIL_DOMAIN']),
|
|
)
|
|
elif notification_type == LETTER_TYPE:
|
|
create_resp_partial = functools.partial(
|
|
create_post_letter_response_from_notification,
|
|
subject=template_with_content.subject,
|
|
)
|
|
resp = create_resp_partial(
|
|
notification_id, client_reference, template_id, template_version, service_id,
|
|
url_root=request.url_root,
|
|
content=template_with_content.content_with_placeholders_filled_in,
|
|
)
|
|
return resp
|