mirror of
https://github.com/GSA/notifications-api.git
synced 2025-12-23 00:41:35 -05:00
41ce691704
MMG changed the datatype and the status codes they send us for the delivery receipts. This PR accounts for that change.
111 lines
4.8 KiB
Python
111 lines
4.8 KiB
Python
import uuid
|
|
|
|
from app.models import NotificationStatistics
|
|
from app.notifications.process_client_response import (
|
|
validate_callback_data,
|
|
process_sms_client_response
|
|
)
|
|
|
|
|
|
def test_validate_callback_data_returns_none_when_valid():
|
|
form = {'status': 'good',
|
|
'reference': 'send-sms-code'}
|
|
fields = ['status', 'reference']
|
|
client_name = 'sms client'
|
|
|
|
assert validate_callback_data(form, fields, client_name) is None
|
|
|
|
|
|
def test_validate_callback_data_return_errors_when_fields_are_empty():
|
|
form = {'monkey': 'good'}
|
|
fields = ['status', 'cid']
|
|
client_name = 'sms client'
|
|
|
|
errors = validate_callback_data(form, fields, client_name)
|
|
assert len(errors) == 2
|
|
assert "{} callback failed: {} missing".format(client_name, 'status') in errors
|
|
assert "{} callback failed: {} missing".format(client_name, 'cid') in errors
|
|
|
|
|
|
def test_validate_callback_data_can_handle_integers():
|
|
form = {'status': 00, 'cid': 'fsdfadfsdfas'}
|
|
fields = ['status', 'cid']
|
|
client_name = 'sms client'
|
|
|
|
result = validate_callback_data(form, fields, client_name)
|
|
assert result is None
|
|
|
|
|
|
def test_validate_callback_data_returns_error_for_empty_string():
|
|
form = {'status': '', 'cid': 'fsdfadfsdfas'}
|
|
fields = ['status', 'cid']
|
|
client_name = 'sms client'
|
|
|
|
result = validate_callback_data(form, fields, client_name)
|
|
assert result is not None
|
|
assert "{} callback failed: {} missing".format(client_name, 'status') in result
|
|
|
|
|
|
def test_process_sms_response_return_success_for_send_sms_code_reference():
|
|
success, error = process_sms_client_response(status='000', reference='send-sms-code', client_name='sms-client')
|
|
assert success == "{} callback succeeded: send-sms-code".format('sms-client')
|
|
assert error is None
|
|
|
|
|
|
def test_process_sms_response_returns_error_bad_reference():
|
|
success, error = process_sms_client_response(status='000', reference='something-bad', client_name='sms-client')
|
|
assert success is None
|
|
assert error == "{} callback with invalid reference {}".format('sms-client', 'something-bad')
|
|
|
|
|
|
def test_process_sms_response_returns_error_for_unknown_sms_client():
|
|
success, error = process_sms_client_response(status='000', reference=str(uuid.uuid4()), client_name='sms-client')
|
|
assert success is None
|
|
assert error == 'unknown sms client: {}'.format('sms-client')
|
|
|
|
|
|
def test_process_sms_response_returns_error_for_unknown_status():
|
|
success, error = process_sms_client_response(status='000', reference=str(uuid.uuid4()), client_name='Firetext')
|
|
assert success is None
|
|
assert error == "{} callback failed: status {} not found.".format('Firetext', '000')
|
|
|
|
|
|
def test_process_sms_response_updates_notification_stats_for_valid_request(notify_db,
|
|
notify_db_session,
|
|
sample_notification):
|
|
stats = NotificationStatistics.query.all()
|
|
assert len(stats) == 1
|
|
assert stats[0].sms_requested == 1
|
|
assert stats[0].sms_delivered == 0
|
|
assert stats[0].sms_failed == 0
|
|
success, error = process_sms_client_response(status='0', reference=str(sample_notification.id),
|
|
client_name='Firetext')
|
|
assert error is None
|
|
assert success == "{} callback succeeded. reference {} updated".format('Firetext', sample_notification.id)
|
|
stats = NotificationStatistics.query.all()
|
|
assert len(stats) == 1
|
|
assert stats[0].sms_requested == 1
|
|
assert stats[0].sms_delivered == 1
|
|
assert stats[0].sms_failed == 0
|
|
|
|
|
|
def test_process_sms_response_updates_notification_stats_for_valid_request_with_failed_status(notify_api,
|
|
notify_db,
|
|
notify_db_session,
|
|
sample_notification):
|
|
with notify_api.test_request_context():
|
|
stats = NotificationStatistics.query.all()
|
|
assert len(stats) == 1
|
|
assert stats[0].sms_requested == 1
|
|
assert stats[0].sms_delivered == 0
|
|
assert stats[0].sms_failed == 0
|
|
success, error = process_sms_client_response(status='1', reference=str(sample_notification.id),
|
|
client_name='Firetext')
|
|
assert success == "{} callback succeeded. reference {} updated".format('Firetext', sample_notification.id)
|
|
assert error is None
|
|
stats = NotificationStatistics.query.all()
|
|
assert len(stats) == 1
|
|
assert stats[0].sms_requested == 1
|
|
assert stats[0].sms_delivered == 0
|
|
assert stats[0].sms_failed == 1
|