mirror of
https://github.com/GSA/notifications-api.git
synced 2026-01-03 16:10:45 -05:00
2acc4ee67d
This is so we can use it to address issues highlighted by the new
alert, if it's not possible to actually send the notifications e.g.
if they are somehow 'invalid'.
Previously this was added for a one-off use case [1]. This rewrites
the task to operate on arbitrary notification IDs instead of client
refs, which aren't always present for notifications we may want to
send / replay callbacks for. Since the task may now need to work on
notifications more than one service, I had to restructure it to cope
with multiple callback APIs.
Note that, in the test, I've chosen to do a chain of invocations and
assertions, rather than duplicate a load of boilerplate or introduce
funky parametrize flags for a service with/out a callback API. We'll
refactor this in a later commit.
[1]: e95740a6b5
68 lines
2.1 KiB
Python
68 lines
2.1 KiB
Python
import uuid
|
|
|
|
from app.commands import local_dev_broadcast_permissions, replay_callbacks
|
|
from app.config import QueueNames
|
|
from app.dao.services_dao import dao_add_user_to_service
|
|
from tests.app.db import create_service_callback_api, create_user
|
|
|
|
|
|
def test_local_dev_broadcast_permissions(
|
|
sample_service,
|
|
sample_broadcast_service,
|
|
notify_api,
|
|
):
|
|
user = create_user()
|
|
dao_add_user_to_service(sample_service, user)
|
|
dao_add_user_to_service(sample_broadcast_service, user)
|
|
|
|
assert len(user.get_permissions(sample_service.id)) == 0
|
|
assert len(user.get_permissions(sample_broadcast_service.id)) == 0
|
|
|
|
notify_api.test_cli_runner().invoke(
|
|
local_dev_broadcast_permissions, ['-u', user.id]
|
|
)
|
|
|
|
assert len(user.get_permissions(sample_service.id)) == 0
|
|
assert len(user.get_permissions(sample_broadcast_service.id)) > 0
|
|
|
|
|
|
def test_replay_callbacks(
|
|
mocker,
|
|
sample_service,
|
|
sample_notification,
|
|
tmpdir,
|
|
notify_api,
|
|
):
|
|
mock_apply = mocker.patch('app.commands.send_delivery_status_to_service.apply_async')
|
|
mock_update = mocker.patch('app.commands.create_delivery_status_callback_data')
|
|
mock_update.return_value = 'encrypted_status_update'
|
|
|
|
file_path = tmpdir + 'callback_ids.txt'
|
|
missing_notification_id = uuid.uuid4()
|
|
|
|
with open(file_path, 'w') as f:
|
|
f.write(str(sample_notification.id) + "\n")
|
|
f.write(str(missing_notification_id) + "\n")
|
|
|
|
result = notify_api.test_cli_runner().invoke(
|
|
replay_callbacks, ['-f', file_path]
|
|
)
|
|
|
|
mock_apply.assert_not_called()
|
|
assert f'{missing_notification_id} was not found' in result.output
|
|
assert "Callback api was not found" in result.output
|
|
|
|
# Now re-run with the callback API in place
|
|
create_service_callback_api(service=sample_service, bearer_token='foo')
|
|
|
|
result = notify_api.test_cli_runner().invoke(
|
|
replay_callbacks, ['-f', file_path]
|
|
)
|
|
|
|
mock_apply.assert_called_once_with(
|
|
[str(sample_notification.id), 'encrypted_status_update'],
|
|
queue=QueueNames.CALLBACKS
|
|
)
|
|
|
|
assert result.exit_code == 0
|