mirror of
https://github.com/GSA/notifications-api.git
synced 2026-08-15 15:28:02 -04:00
1cd498dd39
previously, it was too loose - checking `"name" in str(exc)` returns false positives. By changing from three if statements to a loop we can cut down on unnecessary code (and ensure that the returned objects are consistent), and by using the full check constraint name we can be sure that we're only capturing exactly the right errors. Additionally, don't return the original data in the error message - it's obvious what the name is because it'll be populated in the form you just filled in.
70 lines
2.2 KiB
Python
70 lines
2.2 KiB
Python
from celery import current_app
|
|
from sqlalchemy.exc import IntegrityError
|
|
|
|
from flask import Blueprint, jsonify, request
|
|
|
|
from app.dao.letter_branding_dao import (
|
|
dao_get_all_letter_branding, dao_create_letter_branding,
|
|
dao_update_letter_branding,
|
|
dao_get_letter_branding_by_id
|
|
)
|
|
from app.errors import register_errors
|
|
from app.letter_branding.letter_branding_schema import post_letter_branding_schema
|
|
from app.models import LetterBranding
|
|
from app.schema_validation import validate
|
|
|
|
letter_branding_blueprint = Blueprint('letter_branding', __name__, url_prefix='/letter-branding')
|
|
register_errors(letter_branding_blueprint)
|
|
|
|
|
|
@letter_branding_blueprint.errorhandler(IntegrityError)
|
|
def handle_integrity_error(exc):
|
|
"""
|
|
Handle integrity errors caused by the unique constraint
|
|
"""
|
|
for col in {'domain', 'name', 'filename'}:
|
|
if 'letter_branding_{}_key'.format(col) in str(exc):
|
|
return jsonify(
|
|
result='error',
|
|
message={col: ["{} already in use".format(col.title())]}
|
|
), 400
|
|
current_app.logger.exception(exc)
|
|
return jsonify(result='error', message="Internal server error"), 500
|
|
|
|
|
|
@letter_branding_blueprint.route('', methods=['GET'])
|
|
def get_all_letter_brands():
|
|
letter_brands = dao_get_all_letter_branding()
|
|
|
|
return jsonify([lb.serialize() for lb in letter_brands])
|
|
|
|
|
|
@letter_branding_blueprint.route('/<uuid:letter_branding_id>', methods=['GET'])
|
|
def get_letter_brand_by_id(letter_branding_id):
|
|
letter_branding = dao_get_letter_branding_by_id(letter_branding_id)
|
|
|
|
return jsonify(letter_branding.serialize()), 200
|
|
|
|
|
|
@letter_branding_blueprint.route('', methods=['POST'])
|
|
def create_letter_brand():
|
|
data = request.get_json()
|
|
|
|
validate(data, post_letter_branding_schema)
|
|
|
|
letter_branding = LetterBranding(**data)
|
|
dao_create_letter_branding(letter_branding)
|
|
|
|
return jsonify(letter_branding.serialize()), 201
|
|
|
|
|
|
@letter_branding_blueprint.route('/<uuid:letter_branding_id>', methods=['POST'])
|
|
def update_letter_branding(letter_branding_id):
|
|
data = request.get_json()
|
|
|
|
validate(data, post_letter_branding_schema)
|
|
|
|
letter_branding = dao_update_letter_branding(letter_branding_id, **data)
|
|
|
|
return jsonify(letter_branding.serialize()), 201
|