mirror of
https://github.com/GSA/notifications-api.git
synced 2025-12-20 15:31:15 -05:00
106187ba04
For preview and staging environments, we often send no messages
in a single day. This is currently causing a `DivisionByZero` error
that is rendering the page with no results. This makes it impossible
to look at preview/staging and see if the performance page is
working correctly or not.
(psycopg2.errors.DivisionByZero) division by zero
[SQL: SELECT CAST(ft_processing_time.bst_date AS TEXT) AS date, ft_processing_time.messages_total AS ft_processing_time_messages_total, ft_processing_time.messages_within_10_secs AS ft_processing_time_messages_within_10_secs, (ft_processing_time.messages_within_10_secs / CAST(ft_processing_time.messages_total AS FLOAT)) * %(param_1)s AS percentage
FROM ft_processing_time
WHERE ft_processing_time.bst_date >= %(bst_date_1)s AND ft_processing_time.bst_date <= %(bst_date_2)s ORDER BY ft_processing_time.bst_date]
[parameters: {'param_1': 100, 'bst_date_1': datetime.date(2021, 11, 12), 'bst_date_2': datetime.date(2021, 11, 19)}]
(Background on this error at: http://sqlalche.me/e/14/9h9h)
I've fixed this by falling back to 100.0% for days we send
no messages. Maybe some argument that it should be N/A rather than
100% but I think it doesn't really matter as this is only
going to affect preview and staging as we will never have a day
sending no messages in production.
99 lines
2.9 KiB
Python
99 lines
2.9 KiB
Python
from datetime import datetime
|
|
|
|
from freezegun import freeze_time
|
|
|
|
from app.dao import fact_processing_time_dao
|
|
from app.dao.fact_processing_time_dao import (
|
|
get_processing_time_percentage_for_date_range,
|
|
)
|
|
from app.models import FactProcessingTime
|
|
from tests.app.db import create_process_time
|
|
|
|
|
|
def test_insert_update_processing_time(notify_db_session):
|
|
data = FactProcessingTime(
|
|
bst_date=datetime(2021, 2, 22).date(),
|
|
messages_total=3,
|
|
messages_within_10_secs=2
|
|
)
|
|
|
|
fact_processing_time_dao.insert_update_processing_time(data)
|
|
|
|
result = FactProcessingTime.query.all()
|
|
|
|
assert len(result) == 1
|
|
assert result[0].bst_date == datetime(2021, 2, 22).date()
|
|
assert result[0].messages_total == 3
|
|
assert result[0].messages_within_10_secs == 2
|
|
assert result[0].created_at
|
|
assert not result[0].updated_at
|
|
|
|
data = FactProcessingTime(
|
|
bst_date=datetime(2021, 2, 22).date(),
|
|
messages_total=4,
|
|
messages_within_10_secs=3
|
|
)
|
|
with freeze_time("2021-02-23 13:23:33"):
|
|
fact_processing_time_dao.insert_update_processing_time(data)
|
|
|
|
result = FactProcessingTime.query.all()
|
|
|
|
assert len(result) == 1
|
|
assert result[0].bst_date == datetime(2021, 2, 22).date()
|
|
assert result[0].messages_total == 4
|
|
assert result[0].messages_within_10_secs == 3
|
|
assert result[0].created_at
|
|
assert result[0].updated_at == datetime(2021, 2, 23, 13, 23, 33)
|
|
|
|
|
|
def test_get_processing_time_percentage_for_date_range(notify_db_session):
|
|
create_process_time(
|
|
bst_date='2021-02-21',
|
|
messages_total=5,
|
|
messages_within_10_secs=4
|
|
)
|
|
create_process_time(
|
|
bst_date='2021-02-22',
|
|
messages_total=3,
|
|
messages_within_10_secs=2
|
|
)
|
|
create_process_time(
|
|
bst_date='2021-02-23',
|
|
messages_total=4,
|
|
messages_within_10_secs=3
|
|
)
|
|
|
|
results = get_processing_time_percentage_for_date_range('2021-02-22', '2021-02-22')
|
|
|
|
assert len(results) == 1
|
|
assert results[0].date == '2021-02-22'
|
|
assert results[0].messages_total == 3
|
|
assert results[0].messages_within_10_secs == 2
|
|
assert round(results[0].percentage, 1) == 66.7
|
|
|
|
|
|
def test_get_processing_time_percentage_for_date_range_handles_zero_cases(notify_db_session):
|
|
create_process_time(
|
|
bst_date='2021-02-21',
|
|
messages_total=0,
|
|
messages_within_10_secs=0
|
|
)
|
|
create_process_time(
|
|
bst_date='2021-02-22',
|
|
messages_total=10,
|
|
messages_within_10_secs=0
|
|
)
|
|
|
|
results = get_processing_time_percentage_for_date_range('2021-02-21', '2021-02-22')
|
|
|
|
assert len(results) == 2
|
|
assert results[0].date == '2021-02-21'
|
|
assert results[0].messages_total == 0
|
|
assert results[0].messages_within_10_secs == 0
|
|
assert results[0].percentage == 100.0
|
|
|
|
assert results[1].date == '2021-02-22'
|
|
assert results[1].messages_total == 10
|
|
assert results[1].messages_within_10_secs == 0
|
|
assert results[1].percentage == 0.0
|