Leo Hemsted
c863b33c8d
make sure letters are handled properly by the v1 api
2017-08-25 16:47:17 +01:00
kentsanggds
549601a6df
Merge pull request #1200 from alphagov/ken-refactor-inbound_numbers
...
Refactor inbound numbers
2017-08-25 13:27:16 +01:00
Rebecca Law
d4422dd35f
Added a proper error response if the notification type is not supported.
2017-08-23 14:56:03 +01:00
Ken Tsang
d99ab329eb
Refactored code to use inbound_number.number
...
- Removed filter on sms_sender for `dao_fetch_services_by_inbound_number`
2017-08-23 14:14:32 +01:00
Leo Hemsted
ae683cad6e
Merge pull request #1192 from alphagov/deps
...
update dependencies
2017-08-22 15:39:49 +01:00
Leo Hemsted
c36e50bef1
update dependencies
2017-08-18 17:02:31 +01:00
Ken Tsang
3a70d63a7c
Test for inbound_number when no inbound_sms permissions
2017-08-16 16:28:56 +01:00
Ken Tsang
c36423aac6
Refactor code for dao_fetch_servies_by_sms_sender to use inbound_numbers
...
This will need to be refactored after the deployment of api and admin and after the update script for existing services using inbound numbers has been executed.
2017-08-16 12:51:31 +01:00
Ken Tsang
667ee57a35
Refactor code to use inbound_numbers if set
2017-08-16 12:50:44 +01:00
Leo Hemsted
372b10f19c
fix up tests to be internally consistent
...
notifications should always have at least one of job and api key, and
the key type should match the api key's key type (or be 'normal')
2017-08-02 15:35:56 +01:00
Leo Hemsted
5d61b3644c
add tests for new test-key handling
2017-08-02 11:14:05 +01:00
Leo Hemsted
075d2a3346
tighten key_type validation on letters api
...
when in research mode or test key, dont send letters via api - instead,
just put them straight to success state
when using a team key, flat out reject the request (403)
2017-08-01 15:49:00 +01:00
Leo Hemsted
8e738b783e
update test_send_notification to account for new uuid mock
2017-07-31 11:10:05 +01:00
Leo Hemsted
2ab105aaf4
add tests for letter api notifications
2017-07-27 16:43:55 +01:00
Leo Hemsted
0ce9b94c36
Merge pull request #1075 from alphagov/letter-api-refactor
...
Letter api step 1 - refactor
2017-07-25 14:53:39 +01:00
Leo Hemsted
614880f6d9
send to send-sms-tasks and send-email-tasks instead of send-tasks
2017-07-21 13:49:37 +01:00
Leo Hemsted
9caf45451e
make persist_notification require kwargs
...
when functions get as big as that, it's confusing to try and work out what
things are what. By including a * as the first arg, we require that anyone
calling the function has to use kwargs to reference the parameters
2017-07-19 17:02:19 +01:00
Ken Tsang
8b04039a5a
Refactor to abstract inbound_sms perms check
2017-07-06 12:31:02 +01:00
Ken Tsang
3372fe6b18
Refactored test
2017-07-06 12:31:01 +01:00
Ken Tsang
5efe4d59ec
Improved test to include check on log
2017-07-06 12:31:01 +01:00
Ken Tsang
f028dab252
Removed firetext params
2017-07-06 12:31:01 +01:00
Ken Tsang
e96a67c59b
Firetext tests
2017-07-06 12:31:01 +01:00
Ken Tsang
5a82fe0a70
Add inbound sms permission check
2017-07-06 12:31:01 +01:00
Ken Tsang
23618a186c
Further refactoring
2017-07-06 12:27:57 +01:00
Ken Tsang
46a55c1cdb
Refactor code
2017-07-06 12:27:57 +01:00
Ken Tsang
542bbb2f34
Refactor code
2017-07-06 12:27:56 +01:00
Ken Tsang
c1caa4a5da
Add tests for when email / sms disabled
2017-07-06 12:27:56 +01:00
Ken Tsang
b04d01ba27
Refactored code to use new service permissions only
2017-07-06 12:27:55 +01:00
Ken Tsang
98cd838510
ken-use-only-new-service-permissions
2017-07-06 12:27:55 +01:00
Leo Hemsted
350133e6db
ensure created_by_id is being persisted correctly
...
(also make sure it's well tested 🎉 )
2017-06-23 15:56:47 +01:00
Rebecca Law
e0d23f40f6
Merge pull request #1038 from alphagov/push-inbound-sms
...
Push inbound sms
2017-06-21 15:49:32 +01:00
Rebecca Law
c608f5997b
New task to send the inbound sms to the service.
...
If the service has not set the url then nothing happens.
If the request to the service url returns with 500 or greater the task is retries.
The task is created when the SMS provider post the inbound SMS.
2017-06-20 17:13:40 +01:00
Leo Hemsted
ac7665bfc6
celery test cleanup
...
* Alter config so an error will be raised if you forget to mock out a
celery call in one of your tests
* Remove an unneeded exception type that was masking errors
2017-06-20 12:06:49 +01:00
Leo Hemsted
a1e570dea7
persist created_by_id when using the one off notification endpoint
2017-06-20 12:06:49 +01:00
Rebecca Law
3a66027d6a
Refactor ApiKeys.secret and ServiceInboundApi.bearer_token to use the same encryption method and get rid of the duplicate code.
2017-06-19 14:32:22 +01:00
Martyn Inglis
29455b6d3b
Strip leading 44 from inbound SMS numbers to normalise to how we store things.
2017-06-06 11:50:30 +01:00
Martyn Inglis
b296e736f2
Reorder the migrations.
2017-06-05 11:51:30 +01:00
Martyn Inglis
f15d235d1e
Merge branch 'master' into firetext-inbound-sms
2017-06-05 11:33:53 +01:00
Martyn Inglis
012f8d2675
Adds provider onto the inbound sms table so we know where this came from.
2017-06-02 16:37:57 +01:00
Martyn Inglis
3e1de2e901
Capture the fire text callbacks.
...
Parse the form data, and stop the message
2017-06-02 15:58:36 +01:00
Leo Hemsted
bf18b179b0
ensure the user_number in inbound sms is international
...
rather than using the `normalise_phone_number` function, use the
`validate_and_format_phone_number` function - this will also convert
all numbers to international format, which means we won't need to
worry about whether the user enters internaional or UK phone numbers
when searching
2017-06-02 15:20:18 +01:00
Leo Hemsted
d9bdacb5cd
parse datetimes from mmg inbound sms
...
the DateRecieved field from MMG comes in with +s instead of spaces,
and uriencoded (the same as how they format their messages)
Make sure we decode this, and then convert to a UTC timestamp
2017-06-02 10:14:01 +01:00
Leo Hemsted
dba4e2ad89
mmg spell received incorrectly, lets use that
2017-06-01 17:27:09 +01:00
Martyn Inglis
c57e2a6894
Merge branch 'master' into inbound-sms
...
Conflicts:
app/notifications/receive_notifications.py
tests/app/notifications/test_receive_notification.py
2017-06-01 15:56:33 +01:00
Leo Hemsted
dd9fd6cf92
still return RECEIVED even if we couldn't find a matching service
...
mmg don't need to retry that message or anything. just log it.
2017-06-01 13:13:51 +01:00
Martyn Inglis
a7fd624db5
Added simple logging endpoint for fire text inbound SMS calls
...
- logs post data
- OK to log all as not currently in use so no real user data expected.
2017-06-01 08:21:18 +01:00
Martyn Inglis
3c416d3631
Simple end point for fire text inbound SMS callbacks.
2017-05-31 16:15:25 +01:00
Leo Hemsted
ef799d0515
add sad path tests for inbound sms
2017-05-30 11:14:18 +01:00
Leo Hemsted
4a85818c34
add inbound sms table
2017-05-30 10:47:01 +01:00
Martyn Inglis
75c5e5e5d5
Merge branch 'master' into redo-queue-visibitlity-timeout
...
Conflicts:
app/notifications/process_notifications.py
app/v2/notifications/post_notifications.py
2017-05-30 10:18:18 +01:00
