Leo Hemsted
fd4e27bfd3
add type conversion to report downloads
...
"sent" is fine as an internal marker but not very obvious to the end
user that it specifically refers to international messages. We now
say "Sent internationally" in the CSV
2017-04-28 11:00:55 +01:00
Imdad Ahad
b5d4acb758
Make message more accurate
2017-04-27 16:58:00 +01:00
Imdad Ahad
e450f15b2b
Fix typo and update test now that we expect sent for international
2017-04-27 16:57:04 +01:00
Imdad Ahad
c5bd685cef
Don't update sent notifications (dao)
2017-04-27 16:55:39 +01:00
Martyn Inglis
349fb3529e
Handle case for international SMS - use correct phone validator, and also set status correctly.
...
This relies on some other code so this commit has placeholder failing tests to be populated when other PRs are merged.
2017-04-27 16:27:14 +01:00
Imdad Ahad
162fc8de04
Merge pull request #925 from alphagov/feat-use-intl-provider-send-sms
...
Feat use intl provider send sms
2017-04-27 15:33:45 +01:00
Imdad Ahad
164ba0c6b3
as_decimal defaults to False
2017-04-27 13:50:51 +01:00
Imdad Ahad
868e102f8a
Make rate_multiplier on notification return non-decimal
2017-04-27 13:24:42 +01:00
Imdad Ahad
252c3235d7
Persist intl fields on notification
2017-04-27 13:24:36 +01:00
minglis
a8ea333606
Merge pull request #923 from alphagov/validate-int-numbers-on-api
...
Validate International phone numbers
2017-04-27 13:21:04 +01:00
Martyn Inglis
109b1727f2
Fish out the international provider if needed.
2017-04-27 12:14:22 +01:00
Martyn Inglis
ba58c55c3b
Filter provider details by international flags
2017-04-27 12:13:58 +01:00
Imdad Ahad
d0978e52fb
Use intl provider for int sms notifications (needs tests)
2017-04-27 10:18:28 +01:00
Leo Hemsted
a138ec478a
Merge branch 'master' into sent-status
2017-04-26 16:52:16 +01:00
Martyn Inglis
2a0f8c8808
Validate International phone numbers
...
- uses new utils methods to validate phone numbers
- defaults to International=True on validation. This ensures the validator works on all numbers
- Then check if the user can send this message to the number internationally if needed.
2017-04-26 15:56:45 +01:00
Imdad Ahad
26b35c5d15
Add intl notificiation fields
2017-04-26 11:31:05 +01:00
Imdad Ahad
3d312c7342
Merge pull request #918 from alphagov/feat-add-intl-provider-migration
...
Add international support flag for providers (migration)
2017-04-26 11:15:26 +01:00
Imdad Ahad
5171547990
Remove blank lines
2017-04-26 09:52:02 +01:00
Imdad Ahad
25ce3851eb
Add international support flag for providers
2017-04-25 17:33:16 +01:00
Leo Hemsted
02e8f454e1
add new notification status 'sent'
...
for international text messages, when we may not ever receive callback info,
so we need a separate status that doesn't get timed out etc
2017-04-25 17:08:29 +01:00
Martyn Inglis
e977e7cee4
Wired in a simple callback to handle SNS notifications from S3
...
S3 will send a message when a file lands - which will trigger processing of DVLA responses.
2017-04-25 14:56:16 +01:00
Rebecca Law
e8a7762688
Merge branch 'master' into update-sms-rate
2017-04-25 10:15:54 +01:00
Rebecca Law
6c8ff80440
Rename class to be singular
2017-04-25 09:53:43 +01:00
Rebecca Law
43226dc932
Added a new rates table.
...
We only need one rate per channel. This reflects that. The provider_rates has been left for now, it is still not being used.
New dao has been added to select the right rate for the given notification_type and date of notificaiton.
2017-04-24 16:20:03 +01:00
Imdad Ahad
ce2401c6e0
Ensure get_current_provider only returns active
2017-04-24 16:06:14 +01:00
Ken Tsang
04796b39a8
Add international sms feature flag in db
2017-04-24 12:43:19 +01:00
Imdad Ahad
c4fac1d937
Revert "Revert "add DVLA organisations to API""
2017-04-21 16:05:07 +01:00
minglis
8d4f9813f8
Merge pull request #907 from alphagov/upper-case-dvla-ids
...
Upper case only in the random notification id generator
2017-04-21 14:26:03 +01:00
Imdad Ahad
49fb4823e3
Refactor tests
2017-04-21 11:07:45 +01:00
Imdad Ahad
4dfd5448ad
Make get all notications return in csv format too:
...
* This adds functionality (via an extra req param) to the
* existing get all notifications method allowing us to specify
* when we want the API to return in csv/non-csv format
2017-04-20 12:31:49 +01:00
Imdad Ahad
9fbd43c072
Serialise notifications for csv separately:
...
* Introduces separate method on Notification to serialise the notification
* ready for csv output
* Fixes issue where job_row_number = 0 not being accounted for correctly
2017-04-20 11:52:00 +01:00
Martyn Inglis
5550201939
Upper case only in the random notification id generator
...
as DVLA need upper case only or the barcode doesn't generate.
2017-04-20 10:55:53 +01:00
Leo Hemsted
67002cd608
Merge pull request #905 from alphagov/letter-scheduled-task
...
exclude letters from scheduled cleanup tasks
2017-04-19 16:19:44 +01:00
Leo Hemsted
935e566284
add tests for letters not getting excluded
2017-04-19 14:22:25 +01:00
Ken Tsang
4a63a337b2
Removed slash from v2 get all templates route
2017-04-19 12:38:58 +01:00
Leo Hemsted
b381aeefa1
don't include letters when timing out/deleting old notifications
...
also refactored those functions, since they were pretty gnarly and
repeated themselves a lot
2017-04-19 11:34:00 +01:00
Ken Tsang
fc0cfa5dbf
Corrected code to handle template types
2017-04-19 10:51:12 +01:00
Ken Tsang
c33b876c66
Remove get all template print
2017-04-19 10:51:12 +01:00
Ken Tsang
a5e514c356
Refactored to use template response as template
2017-04-19 10:51:12 +01:00
Ken Tsang
d290a2e0ad
Removed paging from get all templates
2017-04-19 10:51:12 +01:00
Ken Tsang
cb7cd233d1
Rrefactored schema
2017-04-19 10:51:12 +01:00
Ken Tsang
89e244ccd2
First commit
2017-04-19 10:51:12 +01:00
Ken Tsang
f5da3574b5
Add get all templates schema
2017-04-19 10:51:12 +01:00
minglis
ddda2bd158
Merge pull request #902 from alphagov/task-to-set-job-to-error
...
Task to set job to error
2017-04-18 16:07:32 +01:00
Martyn Inglis
8956338d31
Add a new task to update a job to error - note it leaves the notifications in whatever state they were in.
2017-04-18 11:42:48 +01:00
Martyn Inglis
81f0942f57
Merge branch 'master' into update-the-notification-with-dvla-id
...
Conflicts:
requirements.txt
2017-04-18 11:21:26 +01:00
Martyn Inglis
b8cfaf02f6
Ordered the query - ambiguous orders made tests flaky
2017-04-13 12:52:30 +01:00
Martyn Inglis
b0e5062df2
Added the random string reference to the letter
...
- uses the reference field on the notifications table to store a 16char random string used to cross reference DVLA letters back to the notification
- used as letter barcode does not have space for a UUID notification id
Depends on https://github.com/alphagov/notifications-utils/pull/149
Renamed the numeric_id to notification_reference in utils and changed validation rules to match this
Note also the persist_notification method set "reference" to be "client_reference" which is confusing and they are different things, so fixed this too.
2017-04-12 17:56:55 +01:00
kentsanggds
39ed760708
Merge pull request #898 from alphagov/update-letter-jobs
...
Update letter jobs
response changed to 201
2017-04-11 17:07:12 +01:00
kentsanggds
50ee6d98cd
Merge pull request #892 from alphagov/v2-preview-subject-personalisation
...
V2 preview subject personalisation
2017-04-11 17:05:23 +01:00
