Richard Chapman
d85a71758c
Retry in only certain scenarios
...
Instead of retrying if there are genuine errors, only retry if there are
errors which are unexpected as otherwise the retries will happen and
fail for the same reason e.g. that the message has changed format and
will require a code update.
- Updated process_ses_results to only retry if there in an unknown
exception
- Update test and assert that there is a retry there is a unknown
exception
2017-10-30 13:43:23 +00:00
venusbb
b648c2e632
Merge branch 'master' of https://github.com/alphagov/notifications-api into vb-free-sms-limit-history
2017-10-30 09:34:23 +00:00
Rebecca Law
ca10c72fe6
Fix typo
2017-10-27 16:00:07 +01:00
Rebecca Law
76c8b15f59
Update the billable units with the page count from the response file for letter notifications.
2017-10-27 13:53:55 +01:00
venusbb
c991df3209
Merge branch 'master' of https://github.com/alphagov/notifications-api into vb-free-sms-limit-history
2017-10-26 20:47:18 +01:00
venusbb
eca93a5a24
added a new end point current-year and tests
2017-10-26 17:21:35 +01:00
Rebecca Law
c9909a4216
Merge pull request #1343 from alphagov/improve-get-services
...
Improve get services
2017-10-26 15:28:56 +01:00
venusbb
8dd86d433e
Merge branch 'master' of https://github.com/alphagov/notifications-api into vb-free-sms-limit-history
2017-10-26 15:02:41 +01:00
venusbb
c10cde6b22
modified serialized method and schema
2017-10-26 13:25:11 +01:00
Richard Chapman
14cbdb28a5
Deleted Local Test Files
...
Deleted files which are not required and were duplicated from the main
test files.
2017-10-26 12:44:03 +01:00
Richard Chapman
c2f2d39d22
Retry process_ses_results if it fails
...
If the SES task fails retry every 5 mins for an hour.
- Updated the process_ses_results task to retry
- Added tests to check for retry
2017-10-26 12:23:19 +01:00
Richard Chapman
0494ef3ea7
Removed the HTTP error and arguments from notification_ses_callback.py
...
In preparation for moving the SNS notification to an SES queue remove
the HTTP errors codes and arguments as the method will now be run by
a celery task. Also made the callback http method return more generic
codes as this will be removed in the longer term.
- Removed errors and arguments returned from process_ses_response
- Updated tests
2017-10-26 12:23:19 +01:00
Athanasios Voutsadakis
46144708cb
Fix tests
2017-10-26 12:22:15 +01:00
Athanasios Voutsadakis
dada25beb1
Update tests
2017-10-26 12:18:39 +01:00
Athanasios Voutsadakis
f10893d383
Allow for both an endpoint callback and SQS consumption
2017-10-26 12:17:35 +01:00
Rebecca Law
1998034b52
Refactored the get_detailed_services to stop using marshmallow.
...
Also removed an extra query to services.
The query has been refactored to use an outer join to services on the notifications or notification_history table.
The expectation is that this change will improve the performance of the trial/live-services pages for platform admins.
2017-10-26 12:15:52 +01:00
Athanasios Voutsadakis
263131f6ba
Fix tests
2017-10-26 12:14:33 +01:00
Athanasios Voutsadakis
644b31ba75
Update tests
2017-10-26 12:14:33 +01:00
venusbb
e88b311c8e
Merge branch 'master' of https://github.com/alphagov/notifications-api into vb-free-sms-limit-history
2017-10-26 11:56:14 +01:00
venusbb
9aa7489655
incorporate reviewers comments
2017-10-26 11:49:56 +01:00
kentsanggds
d39bf96324
Merge pull request #1333 from alphagov/ken-handle-dvla-response-file
...
Handle DVLA response file
2017-10-26 11:09:09 +01:00
Rebecca Law
61a68a2d13
[WIP]
2017-10-25 16:47:39 +01:00
Ken Tsang
204f170de2
Use NOTIFICATION_TECHNICAL_FAILURE not NOTIFICATION_FAILED
2017-10-25 15:39:54 +01:00
venusbb
e8f659837a
remove unused codes
2017-10-25 14:52:35 +01:00
Rebecca Law
d4678bc452
Merge pull request #1341 from alphagov/inbound-number-is-the-default-when-only-one
...
Do not create a new SMS sender when allocating an inbound number
2017-10-25 14:02:04 +01:00
Rebecca Law
5ed8f17885
Merge pull request #1338 from alphagov/use-default-sms-not-inbound
...
Use default sms not inbound
2017-10-25 13:39:18 +01:00
Rebecca Law
a8adf4d7d7
This PR is to retain current behaviour when we allocate an inbound number for a service.
...
When a service is allocated an inbound number and they only have one SMS sender, then update that SMS sender to the inbound number.
That way they will not have more than one SMS sender and will not have to choose to use either one.
2017-10-25 11:58:54 +01:00
venusbb
ae6b32d8e2
Merge branch 'master' of https://github.com/alphagov/notifications-api into vb-free-sms-limit-history
2017-10-25 11:39:30 +01:00
venusbb
8ad98f2806
create entry when creating a new service
2017-10-25 11:35:13 +01:00
Ken Tsang
ab55650871
Reordered imports
2017-10-25 10:48:35 +01:00
Ken Tsang
5da119f824
Update letter noti status based on dvla response file
2017-10-25 10:48:35 +01:00
Ken Tsang
98d5473788
Update test to to test letter status received
2017-10-25 10:48:35 +01:00
Ken Tsang
8bdc999818
Update notification schema to include received letter status
2017-10-25 10:48:35 +01:00
Ken Tsang
a2b42194cd
Add letter status received to data model
...
- in order to reduce the number of statuses in the database the letter status `received` will be mapped to `delivered` internally
2017-10-25 10:48:35 +01:00
venusbb
15e3b4171b
fixed object persistence problem
2017-10-24 16:10:51 +01:00
Rebecca Law
f519c2a4d9
fix import
2017-10-24 14:53:02 +01:00
venusbb
b9b0814853
Merge branch 'master' of https://github.com/alphagov/notifications-api into vb-free-sms-limit-history
2017-10-24 14:44:32 +01:00
Rebecca Law
8d6c38e1fe
Now that we allow multiple SMS senders for a service, update the sender for SMS to be the default SMS sender, regardless if it is inbound number or not
2017-10-24 13:37:17 +01:00
venusbb
59dd343254
Added free_sms_fragment_limit model, schema, dao and Rest
2017-10-24 13:23:24 +01:00
Ken Tsang
9bdb8f10ce
Add stats test for bst and fix existing stat test
...
- Existing test was failing as the expected results did not match when retrieving results between 11pm and 12am during bst, so time was fixed to when it wasn't affected
- New test is added to check results during the bst hour
2017-10-24 12:57:15 +01:00
Rebecca Law
ce13e62d84
Merge pull request #1332 from alphagov/improve-platform-admin
...
Improve platform admin
2017-10-24 10:25:54 +01:00
Rebecca Law
5ce44c07f5
Fix unit tests.
2017-10-23 16:07:10 +01:00
Rebecca Law
f1f2e5cd90
Fix the results to be returned in the same format that the admin app expects.
2017-10-23 15:06:11 +01:00
Chris Hill-Scott
c9a7ee991e
Merge pull request #1328 from alphagov/international-default
...
Make international text messaging on by default for new services
2017-10-23 14:03:16 +01:00
Rebecca Law
bfb8528ea9
The /platform-admin takes a long time, probably because the marshmallow schema used joins to the service table to return all the service data and is inefficient.
...
The query itself has not been improved much at all but by not using a marshmallow schema I hope to get the performance gain I am looking for.
2017-10-23 10:58:06 +01:00
Rebecca Law
4675b91763
Merge pull request #1325 from alphagov/add-update-multiple-sms-sender
...
Add update multiple SMS senders for a service
2017-10-20 14:06:53 +01:00
Rebecca Law
d1c9335307
If the add sms sender is for an inbound number use the number from the inbound number object, rather than the value passed in.
2017-10-19 16:29:54 +01:00
Rebecca Law
954a80649e
Merge branch 'master' into add-update-multiple-sms-sender
2017-10-19 14:34:58 +01:00
Rebecca Law
2193afe9a3
Remove 'data' from the json being returned.
2017-10-19 13:59:22 +01:00
Rebecca Law
cee916c68a
As per review commemnts:
...
- Add the assert to a test - oops.
- Fix typo in error message.
2017-10-19 13:51:33 +01:00
