darkhelm/notifications-api
1
0
Fork 0
mirror of https://github.com/GSA/notifications-api.git synced 2026-01-25 12:01:38 -05:00
Code Issues Packages Projects Releases Wiki Activity
8,874 Commits 132 Branches 60 Tags
ebaef4b57b4a99345ebbc27155cf35df2aed71fa
Commit Graph

4 Commits

Author SHA1 Message Date
Ben Thorner
44d90b0a4f Remove redundant ternary on SMS client FROM_NUMBER 
Logs over the past 14 days confirm we never call this code with
None as the sender, so it's safe to remove the ternary.
 2022-04-12 14:59:21 +01:00
Ben Thorner
a2e1d03009 Require "sender" argument to send_sms method 
In response to [^1].

[^1]: https://github.com/alphagov/notifications-api/pull/3493#discussion_r836616675
 2022-03-30 13:38:48 +01:00
Ben Thorner
27ddc4501e DRY-up overriding shortcode with sender 
This avoids duplicating the logic when we add a new provider.
 2022-03-30 13:37:01 +01:00
Ben Thorner
3b082477f0 DRY-up logging and metrics for sending SMS 
This avoids duplicating it as we add a new provider and means we
can test it all in one place (although it wasn't tested before).

I'm not sure why the previous code did "super(..)__init__" in a
non-init function - it's a bit late! - so I've just replaced it
with a call to the new "init_app" function in the parent class.
 2022-03-30 13:37:00 +01:00