Commit Graph

391 Commits

Author SHA1 Message Date
Nicholas Staples
1b25a3c762 Removed alpha client imports. 2016-02-09 16:13:48 +00:00
Nicholas Staples
09d2f0d79d Fix tests. 2016-02-09 16:04:49 +00:00
Nicholas Staples
68b6444eed Comment added for missing code. 2016-02-09 16:02:38 +00:00
Nicholas Staples
bd947d0743 Merge remote-tracking branch 'origin/master' into remove_alpha_client_from_api 2016-02-09 15:54:21 +00:00
NIcholas Staples
3fd333ef94 Merge pull request #65 from alphagov/add-notification-status-endpoints
[WIP] Added endpoints under /job for creating, updating and reading
2016-02-09 14:53:34 +00:00
Adam Shimali
17e5e70f6c [WIP] Added endpoints under /job for creating, updating and reading
notification status.
2016-02-09 14:17:42 +00:00
Adam Shimali
6007cdc24e Merge pull request #64 from alphagov/separate_queue_name_per_environment
updated environment variables.
2016-02-09 14:12:01 +00:00
Nicholas Staples
38e30034d1 updated environment variables. 2016-02-09 14:07:43 +00:00
NIcholas Staples
42b18897f0 Merge pull request #63 from alphagov/read-environment-from-file
Added code to read environemnt from a file
2016-02-09 14:03:42 +00:00
Martyn Inglis
66763a061c Added preview and staging config blocks 2016-02-09 13:56:11 +00:00
Martyn Inglis
c2424d6509 Added code to read environemnt from a file
If file does not exist default to live config.
2016-02-09 13:41:20 +00:00
Martyn Inglis
fb41acdac9 Celery tests 2016-02-09 13:31:45 +00:00
NIcholas Staples
db3c787caf Merge pull request #62 from alphagov/add-refs-to-notification
[WIP] Added service and template relationship to notification model.
2016-02-09 12:53:07 +00:00
Adam Shimali
e5e049d735 Added service and template relationship to notification model.
This makes it more consistent with other model classes with respect
to marhmallow serialisation/deserialisation.
2016-02-09 12:48:27 +00:00
Rebecca Law
d24a356205 Merge pull request #61 from alphagov/add-notification
[WIP] New model class and dao for notification. This will be used for
2016-02-09 12:23:33 +00:00
Adam Shimali
c7121be5a2 [WIP] New model class and dao for notification. This will be used for
recording status and outcome of sending notifications.
2016-02-09 12:03:40 +00:00
Nicholas Staples
2fda7ee59b Alpha client removed from code. Tests fixed but will wait till other notifications jobs are done before creating a pull request. 2016-02-09 11:38:57 +00:00
NIcholas Staples
c1b0cef864 Merge pull request #60 from alphagov/delivery-new-endpoint
New endpoint for delivery app to use.
2016-02-08 16:29:22 +00:00
Adam Shimali
0580f5ab06 New endpoint for delivery app to use.
Once removal of code that uses existing alpha is done, then
duplicated code from /notifications/sms and the new endpoint
can be merged.

Job id is now avaiable in notificaiton but is not used yet.
2016-02-08 14:54:15 +00:00
Adam Shimali
d99776d6cc Merge pull request #59 from alphagov/add-logging-for-auth-errors
Update the error response from the authentication method
2016-02-08 13:36:46 +00:00
Rebecca Law
416dd00ac8 Added a test for the case when there is no secret for the api client.
Fix codestyle
2016-02-08 11:33:24 +00:00
Rebecca Law
877a8a0411 Added logging for the authentication errors.
Moved the "no api secret" error message to the end and only create it if there are no
api client secrets
2016-02-08 11:10:54 +00:00
NIcholas Staples
db1c6749a6 Merge pull request #57 from alphagov/job-details-bug
Fix for incorrect property name for service and template.
2016-02-08 10:51:01 +00:00
Adam Shimali
314689cc42 Merge pull request #58 from alphagov/send_verify_code_email_bug_fix
Bug fixed for posting the correct type of notification to the aws queue.
2016-02-08 09:53:54 +00:00
Nicholas Staples
409857fba6 Now done. 2016-02-08 09:43:19 +00:00
Nicholas Staples
4ecdc9e420 Bug fixed for posting the correct type of notification to the aws queue. 2016-02-08 09:41:10 +00:00
Adam Shimali
23f4ce7255 Fix for incorrect property name for service and template. 2016-02-05 16:33:07 +00:00
NIcholas Staples
0f3bb23225 Merge pull request #56 from alphagov/all-job-details
As job update is a PUT then all non nullable fields
2016-02-05 13:24:27 +00:00
Adam Shimali
e024db6858 As job update is a PUT then all non nullable fields
need to be sent with update.

Also bug in not committing update fixed.
2016-02-05 13:07:02 +00:00
Adam Shimali
bd88cf1e93 Merge pull request #55 from alphagov/update_queue_names
Update queues with a prefix.
2016-02-05 11:24:45 +00:00
Nicholas Staples
cc5dad3744 Update queues with a prefix. 2016-02-05 11:12:59 +00:00
Rebecca Law
1d2b098cfe Merge pull request #54 from alphagov/update-job-status
Endpoint and dao method for updating job status.
2016-02-05 09:50:07 +00:00
Adam Shimali
bec4bbe04e Endpoint and dao method for updating job status. 2016-02-04 20:55:09 +00:00
NIcholas Staples
c395069bb9 Merge pull request #53 from alphagov/more-job-properties
Add more properties of job to job message.
2016-02-04 15:40:46 +00:00
Adam Shimali
aa57730fc9 Add more properties of job to job message. 2016-02-04 12:36:53 +00:00
Adam Shimali
18c5e2d37d Merge pull request #52 from alphagov/fix-create-sms
Update to create_sms_notification
2016-02-04 12:36:28 +00:00
Rebecca Law
1d4d03dbe8 Update to create_sms_notification
Removed the logic to check the api_user is the admin client user name.
There is another controller method to handle sending the verification codes.
2016-02-04 12:07:26 +00:00
Rebecca Law
290c9c3deb Merge pull request #51 from alphagov/add_email_notification_to_sqs_queue
Add email notification to sqs queue
2016-02-03 17:33:16 +00:00
Nicholas Staples
6286646d7f Fix for review comments. 2016-02-03 15:53:16 +00:00
Nicholas Staples
8fd15b44eb Missed a couple of places where we should push to the queue. 2016-02-03 13:52:09 +00:00
Nicholas Staples
aba1cd2ed5 Sqs queues now populated from all create_notification api calls. Marshmallow schemas added for notification. 2016-02-03 13:16:19 +00:00
Rebecca Law
1a7c521ebb Merge pull request #50 from alphagov/another-migration-fix
Another migration fix
2016-02-02 17:27:10 +00:00
Adam Shimali
9978672ee7 Another migration fix 2016-02-02 17:22:24 +00:00
Rebecca Law
be86f172d8 Merge pull request #49 from alphagov/migration-fix
Add default value for non nullable column
2016-02-02 17:02:48 +00:00
Adam Shimali
9a6f1ed1d7 Add default value for non nullable column 2016-02-02 16:55:08 +00:00
NIcholas Staples
02a38572bb Merge pull request #48 from alphagov/add-job-to-queue
Add job to queue as soon as it in created.
2016-02-02 16:21:36 +00:00
Adam Shimali
0ade39e63f Add job to queue as soon as it in created.
Added status to job.
2016-02-02 15:14:04 +00:00
Adam Shimali
29e9df785d Merge pull request #47 from alphagov/use-uuid-for-service-id
Change services.id to a UUID
2016-02-02 14:53:11 +00:00
Rebecca Law
b5c662eca8 Change services.id to a UUID
Ideally all the primary keys in the db would be UUID in order to guarantee unique ids across distributed dbs.
This updates the services.id to a UUID. All the tables with a foreign key to the services.id are also updated.
The endpoints no longer state a data type of the <service_id> path param.
All the tests are updated to reflect this update.

The thing to pay attention to is the 0011_uuid_service_id.py migration script.
This commit must go with a commit on the notifications_admin app to keep things working.
There will be a small outage until both deploys have happened.
2016-02-02 14:22:22 +00:00
Adam Shimali
1277837e00 Merge pull request #46 from alphagov/update_version_file_with_travis_details
version file has been updated to include a travis commit and time of …
2016-02-02 11:16:15 +00:00