Commit Graph

10581 Commits

Author SHA1 Message Date
Cliff Hill
f4c8c3e743 Making the migration, part 2.
Signed-off-by: Cliff Hill <Clifford.hill@gsa.gov>
2024-02-28 12:43:34 -05:00
Cliff Hill
d7e8228cff Making the migration.
Signed-off-by: Cliff Hill <Clifford.hill@gsa.gov>
2024-02-28 12:43:34 -05:00
Cliff Hill
95ee8b7c2e Cleaning things up, trying to get tests to work.
Signed-off-by: Cliff Hill <Clifford.hill@gsa.gov>
2024-02-28 12:43:34 -05:00
Cliff Hill
e0b9ac0827 Even more cleanup.
Signed-off-by: Cliff Hill <Clifford.hill@gsa.gov>
2024-02-28 12:43:34 -05:00
Cliff Hill
bd705ed188 More cleanup.
Signed-off-by: Cliff Hill <Clifford.hill@gsa.gov>
2024-02-28 12:43:34 -05:00
Cliff Hill
26bc6198f8 Cleaning up tests.
Signed-off-by: Cliff Hill <Clifford.hill@gsa.gov>
2024-02-28 12:43:34 -05:00
Cliff Hill
8c6046b03b Cleaning up tests.
Signed-off-by: Cliff Hill <Clifford.hill@gsa.gov>
2024-02-28 12:43:33 -05:00
Cliff Hill
9523cc1d97 Cleaning up with black, isort, flake8.
Signed-off-by: Cliff Hill <Clifford.hill@gsa.gov>
2024-02-28 12:43:33 -05:00
Cliff Hill
ab7387acd8 All string "constants" in app.models converted to app.enums.
Signed-off-by: Cliff Hill <Clifford.hill@gsa.gov>
2024-02-28 12:43:33 -05:00
Cliff Hill
7416de2a28 KeyType implemented.
Signed-off-by: Cliff Hill <Clifford.hill@gsa.gov>
2024-02-28 12:43:33 -05:00
Cliff Hill
db3761609b Job Status changed.
Signed-off-by: Cliff Hill <Clifford.hill@gsa.gov>
2024-02-28 12:43:33 -05:00
Cliff Hill
69a9accfca Getting NotificationStatus implemented everywhere.
Signed-off-by: Cliff Hill <Clifford.hill@gsa.gov>
2024-02-28 12:43:32 -05:00
Cliff Hill
a177042e77 Formatting cleanup for models.py
Signed-off-by: Cliff Hill <Clifford.hill@gsa.gov>
2024-02-28 12:43:32 -05:00
Cliff Hill
661904e2cd More fixes for enums.
Signed-off-by: Cliff Hill <Clifford.hill@gsa.gov>
2024-02-28 12:43:32 -05:00
Cliff Hill
f120641087 Getting permission types configured.
Signed-off-by: Cliff Hill <Clifford.hill@gsa.gov>
2024-02-28 12:43:32 -05:00
Cliff Hill
985ad27b3e Getting imports right to use app.enums
Signed-off-by: Cliff Hill <Clifford.hill@gsa.gov>
2024-02-28 12:43:32 -05:00
Cliff Hill
3982f061b6 Made enums.py for all the enums to avoid cyclic imports.
Signed-off-by: Cliff Hill <Clifford.hill@gsa.gov>
2024-02-28 12:43:31 -05:00
Cliff Hill
ac9591ec7c More tweaks, trying to get tests to be clean.
Signed-off-by: Cliff Hill <Clifford.hill@gsa.gov>
2024-02-28 12:43:31 -05:00
Cliff Hill
908d695b54 More cleanup.
Signed-off-by: Cliff Hill <Clifford.hill@gsa.gov>
2024-02-28 12:43:31 -05:00
Cliff Hill
df10c4693c Formatting goodness.
Signed-off-by: Cliff Hill <Clifford.hill@gsa.gov>
2024-02-28 12:43:31 -05:00
Cliff Hill
df866e40f7 More Enum goodness.
Signed-off-by: Cliff Hill <Clifford.hill@gsa.gov>
2024-02-28 12:43:27 -05:00
Cliff Hill
43f18eed6a More changes for enums.
Signed-off-by: Cliff Hill <Clifford.hill@gsa.gov>
2024-02-28 12:41:57 -05:00
Cliff Hill
820ee5a942 Cleaning up a lot of things, getting Enums used everywhere.
Signed-off-by: Cliff Hill <Clifford.hill@gsa.gov>
2024-02-28 12:40:52 -05:00
Kenneth Kehl
689d82280b fix tests 2024-02-28 08:23:56 -08:00
Kenneth Kehl
6d4064e888 make sure original_file_name is stored as part of job (notify-admin-1148) 2024-02-28 07:41:13 -08:00
Carlo Costino
0368307802 Merge pull request #794 from GSA/fix-stats-time-usage
Returned months changed to calendar year
02-27-2024
2024-02-27 11:00:17 -05:00
Carlo Costino
55dc017205 Merge pull request #814 from GSA/notify-api-809
If phone number is unavailable, change text to 'Unavailable'
2024-02-27 10:47:49 -05:00
Carlo Costino
f508ff2c76 Merge branch 'main' into notify-api-809 2024-02-27 10:22:09 -05:00
Carlo Costino
24e379cfa8 Merge pull request #705 from GSA/dependabot/pip/notifications-python-client-9.0.0
Bump notifications-python-client from 8.2.0 to 9.0.0
2024-02-23 14:43:06 -05:00
Kenneth Kehl
f301c7a389 If a telephone number is unavailable, change text to 'Unavailable' 2024-02-23 11:07:13 -08:00
dependabot[bot]
bfb619d5e9 Bump notifications-python-client from 8.2.0 to 9.0.0
Bumps [notifications-python-client](https://github.com/alphagov/notifications-python-client) from 8.2.0 to 9.0.0.
- [Changelog](https://github.com/alphagov/notifications-python-client/blob/main/CHANGELOG.md)
- [Commits](https://github.com/alphagov/notifications-python-client/compare/8.2.0...9.0.0)

---
updated-dependencies:
- dependency-name: notifications-python-client
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
2024-02-23 17:18:46 +00:00
Carlo Costino
993b171236 Merge pull request #709 from GSA/dependabot/pip/flake8-7.0.0
Bump flake8 from 6.1.0 to 7.0.0
2024-02-23 12:11:47 -05:00
dependabot[bot]
9cd68a10dc Bump flake8 from 6.1.0 to 7.0.0
Bumps [flake8](https://github.com/pycqa/flake8) from 6.1.0 to 7.0.0.
- [Commits](https://github.com/pycqa/flake8/compare/6.1.0...7.0.0)

---
updated-dependencies:
- dependency-name: flake8
  dependency-type: direct:development
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
2024-02-23 17:04:42 +00:00
Carlo Costino
4412a86b28 Merge pull request #812 from GSA/dependabot/pip/eventlet-0.35.2
Bump eventlet from 0.34.3 to 0.35.2
2024-02-23 12:00:39 -05:00
dependabot[bot]
1cf2a81d26 Bump eventlet from 0.34.3 to 0.35.2
Bumps [eventlet](https://github.com/eventlet/eventlet) from 0.34.3 to 0.35.2.
- [Changelog](https://github.com/eventlet/eventlet/blob/master/NEWS)
- [Commits](https://github.com/eventlet/eventlet/compare/v0.34.3...v0.35.2)

---
updated-dependencies:
- dependency-name: eventlet
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
2024-02-23 16:13:35 +00:00
Kenneth Kehl
aef797eb79 merge from main again 2024-02-22 14:43:54 -08:00
Carlo Costino
a93cdf9211 Merge pull request #811 from GSA/utils-0-2-9
Update utils to 0.2.9
2024-02-22 10:51:24 -05:00
Carlo Costino
d1d55cca4e Update utils to 0.2.9
This changeset updates notifications-utils to 0.2.9 to account for a recent cryptography update.

Signed-off-by: Carlo Costino <carlo.costino@gsa.gov>
2024-02-21 15:50:55 -05:00
Carlo Costino
158316a77b Merge pull request #802 from GSA/notify-api-539
add log warning in dev environment if phone number is opted out (noti…
02-20-2024
2024-02-14 17:53:00 -05:00
Carlo Costino
ba94b5a0ec Merge pull request #803 from GSA/docs/reviewee-to-author
Update reviewee to author in the code review documentation
2024-02-13 17:05:01 -05:00
Carlo Costino
755f5e085e Update reviewee to author
This changeset adjusts the language slightly to use clearer terms for the individuals involved in a code review.
2024-02-13 16:27:55 -05:00
Kenneth Kehl
467a2919f4 add log warning in dev environment if phone number is opted out (notify-api-539) 2024-02-13 09:39:53 -08:00
Steven Reilly
2f5fea6d81 Merge pull request #791 from GSA/add-code-review-doc-info
Add code review documentation
2024-02-12 16:55:13 -05:00
Carlo Costino
aabb822824 Added a couple of notes about engaging in conversation
h/t to @stvnrlly for the suggestion!

Signed-off-by: Carlo Costino <carlo.costino@gsa.gov>
2024-02-12 13:27:29 -05:00
Carlo Costino
d9e6ebdbe3 Add code review documentation
This changeset adds documentation for what to expect and how to conduct and receive code reviews.  We want to improve our team practices and ensure that all members know how to engage and what to expect with code reviews.  Furthermore, this can serve as another model and positive example of how to collaborate as a team in the broader open source community.

Signed-off-by: Carlo Costino <carlo.costino@gsa.gov>
2024-02-12 13:23:27 -05:00
Carlo Costino
88a553651b Merge pull request #790 from GSA/add-pr-template
API:  Add a pull request template
2024-02-12 12:10:21 -05:00
Carlo Costino
6e6c0ee61d Final draft adjustments to the template instructions
Signed-off-by: Carlo Costino <carlo.costino@gsa.gov>
2024-02-09 17:45:31 -05:00
Carlo Costino
050d92d822 Additional detail suggestions for the PR description
h/t to @stvnrlly for these suggestions!

Co-authored-by: Steven Reilly <stvnrlly@users.noreply.github.com>
2024-02-09 17:45:31 -05:00
Carlo Costino
f7673aa968 Add a pull request template
This changeset adds a template to the repository for our pull requests.  The intention is two-fold:

- To make it easier to know what information and details to include in our pull requests
- To improve the quality and usefulness of our pull requests

This is a start and we will be adjusting this over time as we learn more and refine our process.

Signed-off-by: Carlo Costino <carlo.costino@gsa.gov>
2024-02-09 17:45:30 -05:00
Andrew Shumway
afd77cf9fe Returned months changed to calendar year 2024-02-07 14:53:26 -07:00