Commit Graph

141 Commits

Author SHA1 Message Date
Kenneth Kehl
7f33e4445c add debug steps 2024-07-03 10:18:17 -07:00
Kenneth Kehl
723b89da51 fix command syntax 2024-07-03 08:44:13 -07:00
Kenneth Kehl
3471bf45c8 merge from main 2024-07-02 08:51:07 -07:00
Kenneth Kehl
141dd51b52 code review feedback 2024-07-02 08:50:48 -07:00
Kenneth Kehl
9a4dd043ce cleanup 2024-07-01 10:52:03 -07:00
Carlo Costino
df31d43a92 Update pull request template and docs
This changeset updates our pull request template to be much more streamlined and shifts most of the information to our documentation.  The PR template now links to the docs for folks who are new and unfamiliar with what we require in our pull requests so that the template itself just has the headings and quick outlines to get started more easily and quickly.

Signed-off-by: Carlo Costino <carlo.costino@gsa.gov>
2024-06-28 17:22:30 -04:00
Kenneth Kehl
5b2446ec62 add examples of common commands 2024-04-08 09:35:51 -07:00
John Skiles Skinner
3db2606d6a Move createdb step
The command `createdb test_notification_api` is a prereq to running `make test`. Clarify that it is not just a troubleshooting step.
2024-04-02 08:53:49 -07:00
John Skiles Skinner
c1f25e7c10 Add a note about how to resolve db error
Apparently this error is common:
```
FATAL:  database "test_notification_api" does not exist
```

In lieu of getting to the bottom of it, add a note about how to fix it
2024-04-01 16:53:02 -07:00
Andrew Shumway
a0e2f0fbc8 Merge branch 'main' of https://github.com/GSA/notifications-api into message-send-flow-docs 2024-03-27 10:33:05 -06:00
Jonathan Bobel
232bbd2d8a Merge branch 'main' of https://github.com/GSA/notifications-api into 673-data-dictionary 2024-03-20 11:25:24 -04:00
Andrew Shumway
5f2508a975 Add docs/code comments for message send flow 2024-03-18 11:32:29 -06:00
Carlo Costino
df9ee470dc Merge pull request #828 from GSA/800-flask-command-for-test
800 flask command for test
2024-03-05 11:58:00 -05:00
Anastasia Gradova
703500274b Updated doucmentation in README and all.md 2024-03-05 08:43:20 -07:00
Anastasia Gradova
ee6dfacad1 Standardized command names and updated
documentation
2024-03-04 14:34:41 -07:00
Carlo Costino
611a8c8bc6 Add E2E configuration information to docs
This changeset adds a bit of missing information to our README and documentation for E2E test configuration.  This is required for the project to be set up correctly, and while it will work out of the box, there are a couple of adjustments that need to be made to ensure everything is configured correctly.

Signed-off-by: Carlo Costino <carlo.costino@gsa.gov>
2024-03-01 12:23:05 -05:00
Carlo Costino
755f5e085e Update reviewee to author
This changeset adjusts the language slightly to use clearer terms for the individuals involved in a code review.
2024-02-13 16:27:55 -05:00
Carlo Costino
aabb822824 Added a couple of notes about engaging in conversation
h/t to @stvnrlly for the suggestion!

Signed-off-by: Carlo Costino <carlo.costino@gsa.gov>
2024-02-12 13:27:29 -05:00
Carlo Costino
d9e6ebdbe3 Add code review documentation
This changeset adds documentation for what to expect and how to conduct and receive code reviews.  We want to improve our team practices and ensure that all members know how to engage and what to expect with code reviews.  Furthermore, this can serve as another model and positive example of how to collaborate as a team in the broader open source community.

Signed-off-by: Carlo Costino <carlo.costino@gsa.gov>
2024-02-12 13:23:27 -05:00
Tim Lowden
c422f8eb4d Update all.md
Adding link to spreadsheet
2024-01-10 14:33:05 -05:00
Emily Herrick
e1dcd12d2d Production phone number assignments
Edited production phone numbers to assign the ones in use to three pilot partners with live services.
2024-01-08 14:05:30 -05:00
Jonathan Bobel
d5b98679be More realistic data 2023-12-12 12:30:47 -05:00
Jonathan Bobel
7460682c8a Merge branch 'main' of https://github.com/GSA/notifications-api into 673-data-dictionary 2023-12-12 11:04:57 -05:00
Jonathan Bobel
7c684948cb Adding the markdown file for the data dictionary 2023-12-12 11:04:46 -05:00
Carlo Costino
8ecfed4544 Expand one-off task details
This changeset adds a bit more information to the one-off task details and helps clarify what to include in the command to pass to Cloud Foundry.
2023-12-08 10:28:12 -05:00
stvnrlly
33d1fd4534 one fewer t 2023-11-28 13:10:37 -05:00
Carlo Costino
7d145a0872 Added new section to the table of contents
h/t to @stvnrlly for catching that!

Signed-off-by: Carlo Costino <carlo.costino@gsa.gov>
2023-11-28 11:41:20 -05:00
Carlo Costino
9794f82f44 Add .profile file information to docs
This changeset adds a bit of documentation to explain with the .profile file is used for with our application.

Signed-off-by: Carlo Costino <carlo.costino@gsa.gov>
2023-11-24 16:34:14 -05:00
Carlo Costino
844cab2e3d Updated references of US Notify to Notify.gov
Signed-off-by: Carlo Costino <carlo.costino@gsa.gov>
2023-11-22 13:53:15 -05:00
stvnrlly
b9db94adbb note about running independently 2023-11-17 09:50:02 -05:00
stvnrlly
63952e35a9 freshen up files 2023-11-17 09:47:32 -05:00
Carlo Costino
934eba4a15 ADR 0005 - Agreement Data Model Updates
Added a couple of clarifications to the Agreement model status field (active or expired status values, with a note about draft/pending possibly coming in the future).
2023-11-16 11:29:22 -05:00
Steven Reilly
c364c8fdab Update docs/adrs/0003-implementing-invite-expirations.md 2023-11-08 10:10:58 -05:00
Carlo Costino
3f900101c6 Update ADR-0003: InvitedUser Expirations
This changeset updates ADR-0003 to clarify the work a bit more and remove a couple of extraneous steps.  The previous draft included provisions for creating a whole separate `expired` field, which is unnecessary.

h/t to @xlorepdarkhelm and @stvnrlly for catching this and asking about it!
2023-11-08 10:05:22 -05:00
Steven Reilly
2883b93ba2 update 0002 for et instead of utc 2023-11-02 16:01:15 -04:00
Steven Reilly
ab87098cac mark 0006 as implemented 2023-11-02 10:24:48 -04:00
Steven Reilly
dfa729d5c7 update onboarding docs 2023-10-31 11:13:29 -04:00
Carlo Costino
3a3625017d Merge pull request #536 from GSA/stvnrlly/0008-implementation
Add next steps for quotas in ADR 0008
2023-10-13 13:50:52 -04:00
Carlo Costino
669f2ec813 Merge pull request #535 from GSA/stvnrlly/deploy-docs
Adding details of deploy PR process to docs
2023-10-13 13:50:30 -04:00
Steven Reilly
eadfa4ed7e add adr next steps 2023-10-13 12:19:51 -04:00
stvnrlly
d851d848f4 add info about deploy pr 2023-10-13 11:06:52 -04:00
Steven Reilly
e809c30f3d add new phone numbers to docs 2023-10-12 14:38:30 -04:00
Notify ADR Automation
440267a128 add ADR 0008: ADR: Handle paid quotas at the organization level 2023-09-30 03:03:13 +00:00
Kenneth Kehl
27197b60bb code review feedback 2023-09-29 07:30:12 -07:00
Kenneth Kehl
bebce829af instructions for bulk testing and change delivery receipt delay to 2 minutes 2023-09-28 14:27:16 -07:00
stvnrlly
5c08762fa8 Merge branch 'main' into adr/auto/0007 2023-09-27 10:40:12 -04:00
stvnrlly
5a4e828e3f add date 2023-09-27 09:47:29 -04:00
Steven Reilly
6c6762b2ce Update docs/all.md
Co-authored-by: Carlo Costino <ccostino@users.noreply.github.com>
2023-09-22 21:59:47 -04:00
Steven Reilly
ec48d436d6 Update docs/all.md
Co-authored-by: Carlo Costino <ccostino@users.noreply.github.com>
2023-09-22 21:59:24 -04:00
Steven Reilly
f5a486be78 Update docs/all.md
Co-authored-by: Carlo Costino <ccostino@users.noreply.github.com>
2023-09-22 21:59:09 -04:00