darkhelm/notifications-api
1
0
Fork 0
mirror of https://github.com/GSA/notifications-api.git synced 2025-12-23 08:51:30 -05:00
Code Issues Packages Projects Releases Wiki Activity
4,100 Commits 128 Branches 60 Tags
b1cccdcc6b8694a35a40461bf69d18ca30f39ff7
Commit Graph

6 Commits

Author SHA1 Message Date
Rebecca Law
0054361044 Refactor the sms sender code to remove any unused methods. 
Refactor tests/db/create_service() to behave more like the real world.
Created new create_service_with_inbound_number and create_service_with_defined_sms_sender() test/db methods.
 2017-11-07 14:26:18 +00:00
Rebecca Law
a8adf4d7d7 This PR is to retain current behaviour when we allocate an inbound number for a service. 
When a service is allocated an inbound number and they only have one SMS sender, then update that SMS sender to the inbound number.
That way they will not have more than one SMS sender and will not have to choose to use either one.
 2017-10-25 11:58:54 +01:00
Rebecca Law
cee916c68a As per review commemnts: 
- Add the assert to a test - oops.
- Fix typo in error message.
 2017-10-19 13:51:33 +01:00
Rebecca Law
4ac2dc3606 Fix code style 2017-10-18 13:17:52 +01:00
Rebecca Law
4ca6fbc724 Added dao methods needed to add or update multiple sms senders for a service. 
Remove the unique constraint for service on the ServiceSmsSender model.
 2017-10-18 13:13:23 +01:00
Rebecca Law
f624f4f033 Insert and update methods for service_sms_sender 2017-09-11 17:40:37 +01:00