Rebecca Law
7fa4e7ffc7
Set crown if organisation_type is updated on service.
...
Add some tests.
Update the initial values of crown.
2017-12-04 16:07:26 +00:00
Katie Smith
f73319f5ef
Add and populate crown column to services and services_history
...
- Added the boolean 'crown' column to services and services_history tables
- We populate this column in the same migration script by checking the
'organisation_type' of a service
2017-12-04 13:31:08 +00:00
Alexey Bezhan
1bcca032c2
Merge pull request #1424 from alphagov/create-history-using-init-kwargs
...
Use model constructors when creating history instances
2017-12-01 16:42:29 +00:00
venusbb
ad861f2d55
Merge branch 'master' of https://github.com/alphagov/notifications-api into vb-receipt-callback-dao
2017-12-01 14:36:25 +00:00
Alexey Bezhan
54ef53cefe
Add a test for creating a template with reply_to through the API
2017-11-30 17:31:39 +00:00
venusbb
bf8fe09908
changed name of endpoint from service_callback to delivery_receipt
2017-11-30 11:27:07 +00:00
Rebecca Law
876d30e675
Merge branch 'master' into stop-populating-mapping-tables
2017-11-30 11:20:29 +00:00
venusbb
d03280776d
CodeStyle correction
2017-11-30 09:38:57 +00:00
venusbb
6a994793dc
Merge branch 'master' of https://github.com/alphagov/notifications-api into vb-receipt-callback-dao
2017-11-29 17:39:33 +00:00
venusbb
02f8ad4db2
added test for service_callback_api rest
2017-11-29 17:36:43 +00:00
Leo Hemsted
be94894753
fix linter stuff
2017-11-29 17:18:53 +00:00
Rebecca Law
a5ceb4ba3c
Fix linter
2017-11-29 17:17:08 +00:00
Rebecca Law
8fc0c8b10d
Merge branch 'master' into stop-populating-mapping-tables
2017-11-29 16:57:29 +00:00
Leo Hemsted
4e741bab90
Merge pull request #1441 from alphagov/flake8-tests
...
Flake8 tests
2017-11-29 16:54:29 +00:00
Rebecca Law
8aa94af5d7
Stop populating the notification to sender mapping table when creating a notificaiton.
2017-11-29 16:47:23 +00:00
venusbb
8dc0455f70
move inbound_api tests into test_callback_rest.py
2017-11-29 16:43:09 +00:00
venusbb
c07e804319
Created service_callback_api daos
2017-11-29 15:58:11 +00:00
Rebecca Law
ac6d041d26
Merge branch 'master' into use-reply-to-in-send-to-provider
2017-11-29 14:34:28 +00:00
Rebecca Law
39950c47bc
Remove \t
2017-11-29 14:30:02 +00:00
Leo Hemsted
82acec87b6
flake8 the entire repo now that the tests are good 👌
2017-11-28 17:29:43 +00:00
Leo Hemsted
08494ef206
more flake8. lots of unused imports and variables that didn't get used. i tried to preserve old variable names as comments when it looked like they were useful (eg when they were describing timestamps)
2017-11-28 17:23:09 +00:00
Leo Hemsted
b1cccdcc6b
First batch of flake8 changes.
...
Many unused variables, and replacing some old fixtures with
admin_request before I realised just how many there where 😩
2017-11-28 17:00:01 +00:00
Leo Hemsted
043dee5a54
ensure no tests share the same name (using flake8's checker)
2017-11-28 14:28:01 +00:00
Leo Hemsted
9a0c01fee5
Merge pull request #1436 from alphagov/click-tweaks
...
Click tweaks
2017-11-28 14:26:29 +00:00
Rebecca Law
0d86738696
Merge branch 'master' into use-reply-to-in-send-to-provider
2017-11-28 13:20:26 +00:00
Rebecca Law
a7232381bf
Merge pull request #1433 from alphagov/add-reply-to-notifications
...
Populate reply-to-text field in notifications
2017-11-28 13:19:36 +00:00
Leo Hemsted
5b7118973e
take advantage of click's type validation/coercion
...
(saves us having to write the stuff ourselves). Also adds a small
click plugin to do datetime parsing.
Sample output:
```
[leohemsted:~/dev/api]$ flask command create_provider_rates --help
Usage: flask command create_provider_rates [OPTIONS]
Backfill rates for a given provider
Options:
-p, --provider_name [mmg|firetext|ses]
[required]
-c, --cost FLOAT Cost (pence) per message including decimals
[required]
-d, --valid_from DATE [required]
--help Show this message and exit.
[leohemsted:~/dev/api]$ flask command create_provider_rates -p ses -c 1.234 -d invalid
Usage: flask command create_provider_rates [OPTIONS]
Error: Invalid value for "-d" / "--valid_from": Could not parse datetime string "invalid" formatted as %Y-%m-%dT%H:%M:%S
```
2017-11-28 12:50:29 +00:00
Rebecca Law
b0d88ec08c
Updates as per review comments
2017-11-28 11:05:56 +00:00
Leo Hemsted
2b54c2308b
fix test that did not depend on the notify-db-session fixture, so left a messy db
2017-11-28 10:42:54 +00:00
Rebecca Law
ab5b7c20a7
Use sms sender or reply to email address of the Notify service in create_2fa_code depending on message type.
2017-11-27 16:52:52 +00:00
Rebecca Law
caf810eb76
Select sms sender or email reply to when creating a 2fa code notification
2017-11-27 16:49:18 +00:00
Rebecca Law
03c3ebbbe7
Update send_to_providers and create_dvla_file_contents_for_notifications to use notification.reply_to_text.
...
The next thing to do is to stop updating the notification to sender mapping tables.
2017-11-27 15:24:16 +00:00
Leo Hemsted
1e4a480298
only catch s3 and db errors in build-dvla-file-for-job
...
this reduces the amount of error messages we log (we'll no longer log
at error level when build-dvla-file-for-job retries while waiting for
the task to finish), and make sure we retry in those cases above - db
or s3 having temporary troubl
2017-11-27 15:11:58 +00:00
Leo Hemsted
b6ac7f074d
celery.task.retry exc param should be a throwable.
...
This causes an issue when it hits the max retry limit, and tries to
throw your exception to let you deal with it - at this point it was
moaning because we pass in a string
if it's not defined, and we're inside an exception block celery uses
that instead.
2017-11-27 14:55:29 +00:00
Rebecca Law
4ecf168590
Upate test for persist_notification
2017-11-27 14:45:34 +00:00
venusbb
3945007d24
add reply-to-text to user/rest persist notifications
2017-11-27 14:36:54 +00:00
venusbb
e1175542b7
add reply-to-text to send notification to service users
2017-11-27 14:05:04 +00:00
venusbb
a97d946d2d
Merge branch 'master' of https://github.com/alphagov/notifications-api into add-reply-to-notifications
2017-11-27 13:53:37 +00:00
Rebecca Law
530f2e7f6a
Update invite user endpoint to set the reply_to_text on the notification.
...
Update v1 post notifications to set the reply_to_text on the notification.
2017-11-27 12:30:50 +00:00
Rebecca Law
12024e9619
Update save_letter task to save the default letter contact block when creating the notification.
2017-11-27 11:33:04 +00:00
Richard Chapman
adfba208c4
Removed the templates/monthly endpoint
...
Removed the REST endpoint and the DAO that it uses as the endpoint is
no longer used by the Admin UI and the DAO is not reused anywhere
else.
- Removed REST endpoint
- Removed DAO which gets the stats
- Removed associated tests of both methods
2017-11-27 11:06:43 +00:00
Alexey Bezhan
1971d7d4b3
Merge pull request #1425 from alphagov/enable-firetext-inbound-sms-auth
...
Abort unauthenticated requests for Firetext inbound SMS
2017-11-27 10:45:34 +00:00
Rebecca Law
5450af661e
Merge branch 'master' into add-reply-to-notifications
2017-11-27 10:40:02 +00:00
Rebecca Law
049daa0cb8
Save reply_to_text for one off notiications and csv notificaitons.
2017-11-25 11:31:36 +00:00
Rebecca Law
d779751bae
Set reply_to_text for letter notifications posted to /notifications/letter
2017-11-24 16:17:25 +00:00
Leo Hemsted
b7d5e80509
Merge pull request #1423 from alphagov/fix-firetext-inbound-500s
...
fix 500s when inbound msgs sent from alphanumerics rather than normal…
2017-11-24 15:39:39 +00:00
Leo Hemsted
4c14e3279f
ensure the app context is included in every single flask command
2017-11-24 12:01:28 +00:00
Alexey Bezhan
4d48421767
Abort unauthenticated requests for Firetext inbound SMS
...
Switches on authentication checks for Firetext inbound SMS callbacks.
This should only be released once Firetext callback URLs have been
updated with authentication details.
2017-11-23 17:17:37 +00:00
Leo Hemsted
5466b7cd3c
fix test create_app invocation
2017-11-23 17:04:58 +00:00
Rebecca Law
e0d0b2f4fd
Merge branch 'add-reply-to-notifications' of github.com:alphagov/notifications-api into add-reply-to-notifications
2017-11-23 16:57:17 +00:00
