Imdad Ahad
e75b618c6e
Use datetime in other test for consistency
2017-02-03 13:35:50 +00:00
Imdad Ahad
1e541b5079
TEMPORARY: Execute every 10 minutes
2017-02-03 13:34:09 +00:00
Imdad Ahad
99cc2f5897
Format date correctly for upload + refactor tests
2017-02-03 13:32:19 +00:00
Chris Hill-Scott
0dca47b249
Merge pull request #813 from alphagov/pep8-rename
...
Use pycodestyle instead of PEP8
2017-02-02 16:02:02 +00:00
Rebecca Law
30ca9e7e78
Merge pull request #811 from alphagov/check-service-is-active
...
Check service is active
2017-02-02 11:59:28 +00:00
Rebecca Law
f56824adde
Cancel job if the service is inactive.
...
Update the PermissionsDao.get_permissions_by_user_id to only return permissions for active services,
this will make the admin app return a 403 if someone (otherthan platform admin) tries to look at an inactive service.
Removed the active flag in sample_service the dao_create_service overiddes this attribute.
2017-02-02 11:34:00 +00:00
Rebecca Law
0d83daf350
Merge pull request #814 from alphagov/improve-template-usage-query
...
Performance improvement to the template usage query.
2017-02-02 10:18:58 +00:00
Rebecca Law
da07f9dde8
Performance improvement to the template usage query.
2017-02-02 09:45:06 +00:00
Chris Hill-Scott
c2999ed5ad
Use pycodestyle instead of PEP8
...
PEP8 was renamed to pycodestyle; this issue explains why:
https://github.com/PyCQA/pycodestyle/issues/466
This commit changes our tests to use pycodestyle instead of pep8.
It also means:
- making a couple of whitespace changes to appease the linter
- disabling warnings for bare `Except`s (ie `Except` instead of `Except
ValueError`) – this seems like a sensible thing to catch but I’m not
going to make meaningful code changes in this commit
2017-02-01 09:19:32 +00:00
Leo Hemsted
855a412c90
Merge pull request #812 from alphagov/plat-adm-dates
...
make sure we convert strings to dates before we use them
2017-01-31 16:24:30 +00:00
Leo Hemsted
cd47dbd36b
make sure we convert strings to dates before we use them
...
fixes 500 on platform admin page
2017-01-31 16:12:46 +00:00
Chris Hill-Scott
d0b467b2fb
Merge pull request #807 from alphagov/monthly-service-usage
...
Add endpoint for breakdown of activity by month
2017-01-31 16:04:32 +00:00
Rebecca Law
dab89969cc
If the service is inactive at the time of sending the notification to the provider, the notification is marked as technical-failure.
...
Removed the /service/<id>/deactivate endpoint, now using /service/<id>/archive
2017-01-31 14:28:25 +00:00
Chris Hill-Scott
45b505f379
Split out handling of BST queries for reuse
2017-01-31 14:16:35 +00:00
Chris Hill-Scott
8381a5e11c
Ensure that monthly service usage groups by BST
2017-01-31 14:16:35 +00:00
Chris Hill-Scott
56ba653f48
Add endpoint for breakdown of activity by month
...
This endpoint will eventualy replace the weekly breakdown one. By month
for a given financial year is better, because it gives us consistency
with the breakdown of financial usage (and eventually consistency with
the template usage).
The code to do this is a bit convoluted, in order to fill out the counts
for months and statuses where we don’t have notifications.
This will make the admin side of this easier, because we can rely on
there always being numbers available. The admin side will deal with
summing the statuses (eg `temporary-failure` > `failed`) because this
is presentational.
This commit also modifies the usage count to use `.between()` for
consistency.
2017-01-31 14:16:34 +00:00
Rebecca Law
fde3216f9e
Check the service is active before sending the notification to the provider.
2017-01-31 13:53:13 +00:00
Leo Hemsted
3113f49271
Merge pull request #810 from alphagov/letter-fix
...
fix api statistics to account for letters
2017-01-31 12:29:35 +00:00
bandesz
e2a466932a
Put Jenkinsfile milestones before the prompts
2017-01-31 12:18:10 +00:00
Leo Hemsted
0d089a383e
fix tests in service/test_rest.py
2017-01-31 12:06:25 +00:00
Rebecca Law
ef0f708da0
Merge branch 'master' into check-service-is-active
2017-01-31 12:00:30 +00:00
Rebecca Law
e2e5cb6866
Merge pull request #808 from alphagov/disable-service
...
Suspend/resume service feature
2017-01-31 11:56:22 +00:00
Rebecca Law
539ebdce70
This is what I meant to test
2017-01-31 11:45:35 +00:00
Rebecca Law
907a1e91ac
Removed the need for 2 return statements.
...
Update tests to fix copy/paste errors, use freezetime to ensure there is never a random failing test.
2017-01-31 11:33:36 +00:00
Leo Hemsted
3cd8605e11
fix api statistics to account for letters
2017-01-31 11:32:53 +00:00
imdadahad
0957520735
Merge pull request #809 from alphagov/fix-perf-platform-stats-job
...
Fix perf platform stats job
2017-01-31 11:23:03 +00:00
Rebecca Law
fe64b565a0
Create job now checks that the service is active before creating job.
...
Need to check what message and status code we should use for this case. Probably will create a InactiveServiceRequest exception.
2017-01-31 11:11:33 +00:00
Imdad Ahad
53b6cdcfab
Only send stats from celery task if active + refactor tests
2017-01-30 18:24:18 +00:00
Imdad Ahad
c811f1b6c6
Init the perf platform client, add logs and refactor payload methods
2017-01-30 18:24:06 +00:00
Rebecca Law
87556687ab
This is the first PR in the story to create a suspend service feature.
...
- Renaming /service/<id>/deactivate to /service/<id>/archive to match language on the UI.
- Will need to update admin before deleting the deactive service method
- Created dao and endpoint methods to suspend and resume a service.
- I confirm the use of suspend and resume with a couple people on the team, seems to be the right choice.
The idea is that if you archive a service there is no coming back from that.
To suspend a service is marking it as inactive and revoking the api keys. To resume a service is to mark the service as active, the service will need to create new API keys.
It makes sense that if a service is under threat that the API keys should be renewed.
The next PR will update the code to check that the service is active before sending the request or allowing any actions by the service.
2017-01-30 16:32:44 +00:00
Leo Hemsted
1650fb0807
Merge pull request #797 from alphagov/persist-letters
...
Persist letters
2017-01-30 14:24:38 +00:00
Leo Hemsted
0f7d4548b0
Merge pull request #806 from alphagov/add-logging-for-ses-callback
...
Small change to include the reference that SES send us on the callback.
2017-01-30 14:24:07 +00:00
Rebecca Law
c6eb284218
Small change to include the reference that ses send us on the callback.
2017-01-30 14:09:30 +00:00
Rebecca Law
1d734d3b28
Merge pull request #805 from alphagov/fix-duplicate-test
...
Fix duplicate test name
2017-01-30 09:40:41 +00:00
imdadahad
eec7564475
Merge pull request #804 from alphagov/feat-add-perf-platform-client-and-job
...
Add client and job to update the performance platform daily
2017-01-27 17:03:38 +00:00
Imdad Ahad
cc7bf45766
Move notification retrieval logic into perf platform client and dont filter by status
2017-01-27 16:39:01 +00:00
Rebecca Law
090ecb0de1
Revert local change to config
2017-01-27 16:09:11 +00:00
Rebecca Law
c87d0a37f3
Refactor the get_midnight functions to return the date in UTC but for the localised time.
...
So in June when we are in BST June 16, 00:00 BST => June 15 23:00 UTC
2017-01-27 15:57:25 +00:00
Rebecca Law
4e4afc5d0b
Rename test with duplicate name
2017-01-27 15:21:59 +00:00
Rebecca Law
fba3332488
Merge pull request #802 from alphagov/return-200-for-duplicate-callback
...
Return success of the callback is a duplicate or for an id that does not exist
2017-01-27 14:02:56 +00:00
bandesz
568d93e67f
Update branch to master in Jenkinsfile
2017-01-27 13:57:15 +00:00
minglis
2057fcdbdd
Merge pull request #801 from alphagov/remove-task-from-research-mode-process
...
Change to research mode.
2017-01-27 13:30:41 +00:00
Imdad Ahad
ac1ca608dd
Add performance platform url directly in config (not a secret)
2017-01-27 13:03:04 +00:00
Imdad Ahad
b04c524bc3
Add celery task to run daily at 00:30 that sends notification counts to performance platform
2017-01-27 12:30:56 +00:00
Imdad Ahad
b6cc5b00ba
Add dao method to get sms and email notification counts for a date range and previous day
2017-01-27 12:22:36 +00:00
Imdad Ahad
781bef557a
Add date helper methods to be used as date range filters for notification counts
2017-01-27 12:21:28 +00:00
Imdad Ahad
ed52f41039
Add, init and config performance platform client to prepare/upload daily notification stats
2017-01-27 12:21:08 +00:00
Rebecca Law
27b6aa736c
Update info log to waring.
...
Removed duplicate test
2017-01-27 12:20:54 +00:00
Chris Hill-Scott
355f650f86
Merge pull request #803 from alphagov/filter-global-usage-financial-year
...
Allow filtering of billing info by financial year
2017-01-27 11:58:28 +00:00
Chris Hill-Scott
4e60265c58
Add tests for billable unit rest endpoint
...
Doesn’t do extensive tests through the DAO layer, we have separate tests
elsewhere for that. This just tests the query parameter validation.
2017-01-27 11:47:40 +00:00
