darkhelm/notifications-api
1
0
Fork 0
mirror of https://github.com/GSA/notifications-api.git synced 2026-01-08 03:34:29 -05:00
Code Issues Packages Projects Releases Wiki Activity
953 Commits 130 Branches 60 Tags
6b5b40b9533347a2cb1eaeedbc9ef2e84ab30917
Commit Graph

554 Commits

Author SHA1 Message Date
Martyn Inglis
6b5b40b953 Added tests for statsd and provider stats outcomes with the new provider stats tasks 
- note large change to DAO to remove provider from create notification. Added on send now not creation.
 2016-06-13 11:38:25 +01:00
Martyn Inglis
92e4c0872b Pulled out the tests that send SMSs into provider_tasks file/tests 
- updated tests to validate creation of next task, not sending direct to provider
 2016-06-07 12:53:31 +01:00
Martyn Inglis
37fe2342ae Merge branch 'master' into split-sms-and-retry 2016-06-07 11:10:17 +01:00
Martyn Inglis
642aa2890e Starting to implement tests across the new tasks file 2016-06-07 11:09:54 +01:00
Adam Shimali
207d9088c4 Merge pull request #384 from alphagov/invite-permissions-fix 
API receives full set of permission names
 2016-06-07 09:36:32 +01:00
Rebecca Law
d3c85732bc Merge pull request #383 from alphagov/use-notify-to-send-sms-codes 
Use notify to send sms codes
 2016-06-06 14:30:25 +01:00
Adam Shimali
63c29a3a3d API recieves full set of permissions names on create of user 
invite. This is instead of mapping from permission groups to individual
permissions on user creation.
 2016-06-06 12:37:06 +01:00
Chris Hill-Scott
c2ae4773da Order templates by newest created first 
When you add a new template, it’s probably the one that you want to do
subsequent stuff with. But it’s also helpful to see the template in
context (with its siblings) to understand that there are multiple
templates. So we don’t want to do what we do in
https://github.com/alphagov/notifications-admin/pull/648
for adding a new template.

But we _can_ make your brand-new template appear first by always
ordering by when the template was created.

This also removes the confusion caused by having `updated_at` affecting
order, and causing the templates to move around all the time.
 2016-06-06 10:44:40 +01:00
Rebecca Law
dbc57e3b58 [WIP] 
use send_sms task to send sms code.
Tests are broken because the template data for the Notify service is being delete after every test. Need a way to seed the data for the test.
 2016-06-03 15:15:46 +01:00
Martyn Inglis
12503d6291 First spike to split up send-sms task 
- 2 separate tasks - DB and Provider
- DB to persist notification
- Provider to contact provider
- Each piece has separate retries
- Provider retries have configured back-off
 2016-06-03 14:54:46 +01:00
Leo Hemsted
d41048f4aa statsd counters for callback statuses 
also for the 'code' param from firetext
 2016-06-02 15:53:04 +01:00
Martyn Inglis
b8638a891f Merge branch 'master' into research-mode-implementation 
Conflicts:
	tests/app/conftest.py
 2016-06-02 11:53:06 +01:00
Leo Hemsted
a51d6fae47 Merge pull request #363 from alphagov/send-sms-tests 
send_sms tests
 2016-06-02 11:27:57 +01:00
Rebecca Law
b2a26e3dce Merge pull request #361 from alphagov/do-not-create-new-tempalte-version 
Check for an update before saving template
 2016-06-02 10:11:55 +01:00
Martyn Inglis
754ccbe9af Removed update reference from updating the provider stats 
- single focus method
- allows not to pollute DAO with research mode
 2016-06-02 09:52:47 +01:00
Martyn Inglis
099c17192d Merged provider stats only on success branch 
- ensures that don't raise stats in research mode
 2016-06-02 09:30:01 +01:00
Martyn Inglis
001149c263 Merge branch 'master' into research-mode-implementation 2016-06-02 09:28:35 +01:00
minglis
04a644b66f Merge pull request #362 from alphagov/create_notification_provider_stats_bug 
Provider stats only updated if the provider successfully sends the me…
 2016-06-02 09:25:10 +01:00
Martyn Inglis
49f386e7c5 Refactored to put notifications update last 2016-06-02 09:17:06 +01:00
Martyn Inglis
6ca2e588a9 Re-aligned the dao update that moved by mistake 2016-06-02 08:59:30 +01:00
Martyn Inglis
97e29b9039 Merge branch 'master' into research-mode-implementation 2016-06-01 17:06:38 +01:00
minglis
cf1b777fe6 Merge pull request #357 from alphagov/research-mode 
Add research mode to service/history tables
 2016-06-01 16:58:54 +01:00
Martyn Inglis
290f416485 Various tidy ups and changes 
- use new queue
- remove some new lines in AWS response data
- migration script to populate new fields
 2016-06-01 16:57:57 +01:00
Leo Hemsted
0a8cb679d7 make mmg and firetext client params consistent 2016-06-01 15:58:48 +01:00
Rebecca Law
ec7d9b1c6e Use a more pythonic way to compare the dicts. 2016-06-01 13:55:04 +01:00
Nicholas Staples
276ca15919 Provider stats only updated if the provider successfully sends the message. 2016-06-01 12:43:26 +01:00
Rebecca Law
047a7d5488 Only test the items of the template that can change on an update request. 
Return 200 if no change is made.
 2016-06-01 12:19:59 +01:00
Rebecca Law
05e72b07ae Return status code 304 when template is not updated. 
Moved import
 2016-06-01 11:50:45 +01:00
Rebecca Law
0a9cdbd75a Do not create a new version of the template if there is no change to the tempalte. 2016-06-01 10:53:03 +01:00
Martyn Inglis
909fac3c05 Added research mode tasks 
- if a service is in research mode the don't send the notifications via the providers (MMG/SES/etc)
- instead set up a task to mimic those services callbacks - this completes the loop, and show stats, delivery receipts and so on.
- Use the "to" field to choose the response, allows users to create successful and errored notifications

temp fail sms, uses  "07833333333"
perm fail sms, uses = "07822222222"
success = "07811111111" (or anything else)

success email = "delivered@simulator.notify"
perm fail = "perm-fail@simulator.notify"
temp fail = "temp-fail@simulator.notify"
 2016-05-31 16:55:26 +01:00
Nicholas Staples
79dfc360f2 Notification not created in send_sms or send_email when service is in restricted mode. 2016-05-31 14:55:06 +01:00
Martyn Inglis
9617f0748b Added some tests around creating and updated services 
- ensure research mode is respected on creation and update
- ensure rest client gives an error for bad research mode update
 2016-05-31 12:49:06 +01:00
Martyn Inglis
9aa727e0cf Add research mode to service/history tables 
- added as a nullable boolean column.
 2016-05-31 11:29:20 +01:00
Martyn Inglis
2108bb52d5 Reorder updates to the notification / stats tables to match create. 2016-05-31 10:17:15 +01:00
Rebecca Law
97088a4af1 Added a comment to explain how the delivery receipt will affect the notification status. 2016-05-27 12:28:58 +01:00
Rebecca Law
2bfa9b7e10 Merge branch 'master' into permanent-failure-firetext 2016-05-27 12:10:59 +01:00
Rebecca Law
885abcaf16 Make update notification status transcational. 
Refactor methods for reusability.
 2016-05-27 12:09:36 +01:00
Leo Hemsted
a90a18541f notifications/statistics returns when no stats exist for today 
moved filtering from WHERE to JOIN ON so that when join suceeds but filter fails, we dont lose the service's data from the results set
 2016-05-26 16:48:30 +01:00
Rebecca Law
25a1b7f31c Firetext does not have a status code for temporary-failure. 
In order to set a message as temporary-failure, we check if it is in pending status first.
Otherwise a delivery receipt for failure is set to permanent failure.
 2016-05-26 16:46:00 +01:00
Rebecca Law
c5ec07a9ce Merge branch 'master' into permanent-failure-firetext 2016-05-25 15:45:42 +01:00
Rebecca Law
83df16025d Merge pull request #347 from alphagov/get-jobs-created-in-last-7-days 
Add a limit days query param for get all jobs.
 2016-05-25 11:36:31 +01:00
Rebecca Law
a67793cf8a Updated date query so that the created_at date is truncated so that we get all jobs created number of days requested. 2016-05-25 11:13:49 +01:00
Rebecca Law
2a7872cce1 Add a limit days query param for get all jobs. 2016-05-24 17:21:04 +01:00
Rebecca Law
6735a7103c Merge pull request #345 from alphagov/notification-job-status-counts 
Notification job status counts
 2016-05-24 16:47:00 +01:00
Rebecca Law
fa152c4431 Mark a declined message from Firetext as permanent-failure rather than failed. 2016-05-24 15:32:48 +01:00
Leo Hemsted
24625a44f3 prevent public api from sending archived templates 2016-05-24 13:08:38 +01:00
Leo Hemsted
7801efd5ca don't create job if template has been archived 2016-05-24 13:08:02 +01:00
Rebecca Law
e4eecb894a Update job.notifications_delivered and job.notifications_failed count when updating the status of a notification. 2016-05-24 11:31:44 +01:00
Rebecca Law
dff60175a4 Add jobs.notifications_delivered and jobs.notifications_failed counts to the jobs table. 2016-05-23 15:44:57 +01:00
Leo Hemsted
5ebae9c66c only return unarchived templates when getting all templates 
get_specific_template functions happily return archived templates
 2016-05-23 14:20:02 +01:00