darkhelm/notifications-api
1
0
Fork 0
mirror of https://github.com/GSA/notifications-api.git synced 2026-08-14 02:48:01 -04:00
Code Issues Packages Projects Releases Wiki Activity
1,819 Commits 122 Branches 63 Tags
640f51fc0af5c74bf6cee85d04aa5387a3fe51d3
Commit Graph

9 Commits

Author SHA1 Message Date
Paul Craig
1fce30aaa7 Cost savings 
The "cost" value was flawed for a couple of reasons.

1. Lots of messages are free, so in those instances the "cost"
   doesn't tell you anything
2. The query to get the rate was expensive and we don't have
   an obvious way to get it back very efficiently for large numbers
   of notifications.

So we scrapped it.
 2016-11-25 15:23:03 +00:00
Paul Craig
a17adb4707 New test for notification.cost() method 
Added a test that asking for a nonexistent provider_rate blows
everything up.

Also updated existing test to use a weirder number.
 2016-11-22 18:01:16 +00:00
Paul Craig
fddb1653ac Add .cost() to notification model 
In the V2 API, the GET response for an individual notification
returns a 'cost' value, which we can get by multiplying the
billable units by the per-message rate of the supplier who
sent the message.
Any notifications with billable units > 0 but without a
corresponding `ProviderRates` entry will blow up the application,
so make sure you've got one.
 2016-11-18 17:50:39 +00:00
Rebecca Law
c00eb0f5a4 Remove from_request method on the Notification db model, was not needed anymore. 
Use Notifications.query.one(), rather than assert count is 1 and query for all and get first item in list.
 2016-11-14 14:41:32 +00:00
Rebecca Law
c45d1f63a7 Use the same method to persist a notification. 
Refactored the send_sms task to use this method.
 2016-11-11 14:56:33 +00:00
Imdad Ahad
8184eff15a Update ServiceWhitelist to conform to new data model 2016-09-27 13:44:29 +01:00
Leo Hemsted
2e16be18bc Merge branch 'master' of github.com:alphagov/notifications-api into service-whitelist 2016-09-23 10:14:42 +01:00
Leo Hemsted
5c5ca26630 Add ServiceWhiteList model with corresponding tests 2016-09-22 11:58:51 +01:00
Martyn Inglis
99250b2248 Adds a builder method to the notification object. 
This is used to construct a notification from the sorts of data an API call provides. This is used in both the db-email / db-sms tasks and the notifications rest endpoint to construct the notification DB object.
 2016-09-07 13:44:56 +01:00