Commit Graph

1998 Commits

Author SHA1 Message Date
Chris Hill-Scott
5f696ca696 Merge pull request #1223 from alphagov/quis-patch-1
Warn devs about changing healthcheck page response
2017-09-13 14:11:16 +01:00
Rebecca Law
a03c199225 Merge pull request #1238 from alphagov/imdad-migrate-to-new-reply-to
[3/5] Migrate existing data to new service_email_reply_to table
2017-09-13 09:17:20 +01:00
kentsanggds
ca1856eb20 Merge pull request #1246 from alphagov/ken-prevent-blank-letter-address
Raise validation errors for empty letter fields
2017-09-12 14:36:54 +01:00
Katie Smith
d88e437005 Merge pull request #1248 from alphagov/update-reply-to-email-test
Update reply to email test
2017-09-12 11:30:06 +01:00
Rebecca Law
d356957974 Change the ServiceEmailReplyTo model to uselist for the backref to services (allow 0 to many reply to emails)
Add another assert in the test
2017-09-12 10:14:58 +01:00
Rebecca Law
9bd3ed2dac Use a unique id 2017-09-12 09:30:55 +01:00
Katie Smith
269e88f7de Update reply to email test
- Updated reply to email test so that the request to create or update
email is not mocked.
- Excluded reply_to_email_addresses from the Service schema
2017-09-12 09:07:34 +01:00
Leo Hemsted
cfd51fbbed Merge pull request #1245 from alphagov/bcrypt
upgrade flask-bcrypt to 0.7.1
2017-09-11 16:22:14 +01:00
Leo Hemsted
43bda1ae2c upgrade flask-bcrypt to 0.7.1
this uses bcrypt directly rather than using the wrapper python-bcrypt.
WARNING! You'll need to update your local install by running:

```
pip uninstall python-bcrypt
pip install flask-bcrypt==0.7.1
```
2017-09-11 15:47:10 +01:00
Ken Tsang
41f427d6dd Update definitions to check non empty strings 2017-09-11 15:37:40 +01:00
Rebecca Law
0a21f1f3e8 Small refactor to how notification_schemas are tested.
My local build was not always getting the optional requirement for the jsonschema uri format checker (rfc3987).
The requirement has been added to the requirements_for_test file.
I changed the tests to validate the response schema from the post_notifications tests, this way we can tell if we are breaking the contract.
This showed that the email_from was not returning the entire email address but just the username, that has been corrected here.
Removed the response schema validation tests since they are not being testing in the post notification tests.
2017-09-11 11:10:45 +01:00
Imdad Ahad
e119ced7c1 Add command to populate service_email_reply_to:
* Insert new entries for unpopulated services
* Exclude services who do not have a reply to set
2017-09-08 15:27:49 +01:00
Imdad Ahad
6d0ad75a60 Upsert to new email reply to table when updating a service 2017-09-08 14:56:05 +01:00
Katie Smith
01eef6c7f5 Add service_email_reply_to DAO with an upsert method 2017-09-08 14:56:05 +01:00
Imdad Ahad
d997eb3af9 Create ServiceEmailReplyTo table 2017-09-07 15:41:23 +01:00
Rebecca Law
3b115cc79f Remove the or current_app['FROM_NUMBER'] since sms_sender is a required field. 2017-09-06 15:33:09 +01:00
Rebecca Law
86929fd6b6 Create a table for service_sms_senders.
Migration from inbound_number to service_sms_senders.
May need to pull out the migration into another PR.
2017-09-05 17:53:47 +01:00
Leo Hemsted
3d2e788a4d Merge pull request #1226 from alphagov/backfill-perf-stats
Backfill perf stats
2017-09-05 16:55:43 +01:00
Rebecca Law
e32abb0ada Merge pull request #1221 from alphagov/ken-no-letters-when-trial
Stop letters when service is in trial
2017-09-05 15:33:50 +01:00
Rebecca Law
19f964a90b Added a check that the call is not using a test api key.
Removed the tests for trial mode service for the scheduled tasks and the process job.
Having the validation in the POST notification and create job endpoint is enough.
Updated the test_service_whitelist test because the order of the array is not gaurenteed.
2017-09-04 17:24:41 +01:00
Leo Hemsted
378b131c59 add batch task to backfill processing time data
give it a start date and an end date, and it'll send data to the
performance platform for all dates in that (inclusive)
2017-08-31 14:41:05 +01:00
Leo Hemsted
9fcd54c12b unindent old fn 2017-08-31 14:41:05 +01:00
Imdad Ahad
3f34f8fa3e Merge pull request #1222 from alphagov/get-performance-stats
Get performance stats
2017-08-31 14:17:42 +01:00
Imdad Ahad
72de309b26 Make perf platform processing stats query the NotificationHistory table 2017-08-31 12:52:59 +01:00
Chris Hill-Scott
9d02496173 Warn devs about changing healthcheck page response 2017-08-31 12:14:04 +01:00
Imdad Ahad
ea2f838510 Fix typo 2017-08-31 11:10:54 +01:00
Imdad Ahad
e39c202a01 Merge pull request #1195 from alphagov/imdad-refactor-remove-unused-billing-code
Remove unused billing usage code
2017-08-31 10:39:12 +01:00
Ken Tsang
d391919677 Refactored to check trial when running scheduled job 2017-08-30 22:30:05 +01:00
Ken Tsang
225c85832c Refactored to update job status and not build dvla file 2017-08-30 16:04:10 +01:00
Ken Tsang
01830b7e59 Push letter job to research queue in research mode 2017-08-30 16:04:10 +01:00
Ken Tsang
ff860ec242 403 when creating a letter job in trial mode 2017-08-30 16:04:10 +01:00
Ken Tsang
7e70b44113 Error in task when letter template and in trial mode 2017-08-30 16:04:10 +01:00
Ken Tsang
8f82642422 Prevent v2 notifications POST when in trial mode 2017-08-30 16:04:10 +01:00
Katie Smith
49a6bfc06b Send '0', not 'null', to perf platform if no notifications are sent 2017-08-30 16:02:30 +01:00
Imdad Ahad
af54d98faa Remove unused imports 2017-08-30 14:40:54 +01:00
Imdad Ahad
e1ef0e85c6 Remove monthly usage dao methods 2017-08-30 14:40:54 +01:00
Imdad Ahad
c92b72da6e Remove yearly billing data dao methods 2017-08-30 14:40:29 +01:00
Katie Smith
a1a5fdedb1 Send results of processing-time query to performance platform 2017-08-30 14:40:10 +01:00
Katie Smith
132d65bc75 Add query to get processing time stats for performance platform
We are only interested in API notifications, not including test
messages. Letters are not included.
2017-08-30 14:40:10 +01:00
Imdad Ahad
9478af0941 Remove get yearly usage endpoint 2017-08-30 14:37:27 +01:00
Chris Hill-Scott
26f50af6e9 Let whitelist and user have int. phone numbers
On the frontend, we’re letting users register with international phone
numbers. So we shouldn’t block users from doing this on the API side.

Same thing for the whitelist, where we’re also allowing international
phone numbers now.
2017-08-30 10:55:18 +01:00
Chris Hill-Scott
4f0443041d Merge pull request #1213 from alphagov/remove-spec
Remove Swagger specification
2017-08-29 14:19:31 +01:00
Leo Hemsted
cf2d803db1 Merge pull request #1205 from alphagov/perf-stats
Perf stats refactor
2017-08-29 10:44:09 +01:00
Chris Hill-Scott
d0be79cc4c Remove Swagger specification
This was only ever a spike into what it might look like to document
Notify’s API with Swagger (see
7c3d25a87a).
It’s no longer updated, and only talks about version 1 of the public
API.

Keeping it around now is just a liability, and gives us additional Pyup
upgrades to deal with.
2017-08-29 10:32:37 +01:00
Leo Hemsted
c863b33c8d make sure letters are handled properly by the v1 api 2017-08-25 16:47:17 +01:00
kentsanggds
549601a6df Merge pull request #1200 from alphagov/ken-refactor-inbound_numbers
Refactor inbound numbers
2017-08-25 13:27:16 +01:00
Leo Hemsted
e85b621cbc make perf platform client handle more stuff sensibly
specifically, all of the performance platform specific data layout now
happens in performance_platform_client.py - stuff like setting the
_timestamp, period etc, and the perf platform-specific nomenclature is
all handled there.
2017-08-24 17:10:42 +01:00
Rebecca Law
f9ee8bba91 Merge pull request #1209 from alphagov/remove-unused-endpoint
Removed unused endpoint and dao methods.
2017-08-24 16:32:37 +01:00
Rebecca Law
717c0510a3 Merge pull request #1202 from alphagov/v1-send-letter-error-msg
Added a proper error response if the notification type is not supported.
2017-08-24 16:31:21 +01:00
Rebecca Law
17f62723fa Removed unused endpoint and dao methods. 2017-08-24 16:09:48 +01:00