darkhelm/notifications-api
1
0
Fork 0
mirror of https://github.com/GSA/notifications-api.git synced 2025-12-27 19:01:32 -05:00
Code Issues Packages Projects Releases Wiki Activity
640 Commits 126 Branches 60 Tags
2e09ead30fa2afdeff8a838e6eac34f852d7cb7b
Commit Graph

373 Commits

Author SHA1 Message Date
NIcholas Staples
2e09ead30f Merge pull request #198 from alphagov/retain_all_notifications_for_7_days 
Successful notifications are deleted after a week now. All tests pass…
 2016-04-05 15:05:58 +01:00
Nicholas Staples
4cc0028b01 Remove csv after process job is finished. 
Fixed new tests.
 2016-04-05 14:55:03 +01:00
Nicholas Staples
4d15409781 Successful notifications are deleted after a week now. All tests passing. 2016-04-05 11:07:21 +01:00
Chris Hill-Scott
e465dc8bc4 Merge pull request #195 from alphagov/use-utils-validate-restricted 
Validate recipient for restricted service using utils
 2016-04-05 10:20:27 +01:00
Chris Hill-Scott
e56aee5d1d Validate recipient for restricted service w/ utils 
Implements
https://github.com/alphagov/notifications-utils/pull/16

Once
https://github.com/alphagov/notifications-admin/pull/376
is merged it will no longer be possible for a user to upload a CSV file
containing recipients that they’re not allowed to send to.

So this commit also removes any restricted service checks in the task,
because any public phone numbers/email addresses no longer have any way
of reach this point if the service is restricted.
 2016-04-04 20:10:19 +01:00
Adam Shimali
f6620792b5 Additional sort order by template name for template statistics. 2016-04-04 17:51:24 +01:00
Adam Shimali
e4a5e3890a Corrected error message format 2016-04-04 14:51:56 +01:00
Adam Shimali
0d06be05e1 [WIP] Added dao method and rest endpoint for getting template 
statistics by service.

Some cosmetic changes to imports.

Added fix for job rest not correctly returning errors.
 2016-04-04 14:38:54 +01:00
NIcholas Staples
e2d0d39ea7 Merge pull request #192 from alphagov/update_filter_for_multiple_arguments 
Added functionality to allow filtering by multiple arguments.
 2016-04-04 14:29:53 +01:00
Nicholas Staples
fac34aff10 Added functionality to allow filtering by multiple arguments. 
Removed commented out code.
 2016-04-04 13:21:51 +01:00
Rebecca Law
df6f784f9e - Remove different behaviour for debug mode in errors.py 2016-04-01 14:19:50 +01:00
Rebecca Law
ec180980ee Merge branch 'master' into remove_email_safe 2016-04-01 13:45:21 +01:00
Rebecca Law
8493e29acc Added some more tests. 
Removed the validation in the schema - it was adding complexity, let the unique constraint on the db throw the exception. This should only ever happen on a race condition which seems unlikely (two people changing a service to the same name at the same time)
Do no set debug=true to the test config. If debug=true it changes the behaviour of the error handlers, throwing the exception rather than returning a 500.
 2016-04-01 13:42:11 +01:00
Nicholas Staples
514d490d2f No limit for live services. 2016-04-01 11:12:44 +01:00
Rebecca Law
8df4919029 The admin app now sends the email from when creating a service and when updating the service name. 
This PR removes the need for the email_safe function. The api does not create the email_from field for the service.
Tests were updated to reflect this change.
 2016-03-31 17:46:18 +01:00
Adam Shimali
ca9c886c3e [WIP] On create of notification. Upsert record for template stats 
recording usages of template by day.
 2016-03-31 15:57:50 +01:00
Rebecca Law
4f9dd4863f Merge branch 'master' into add-view-activity-permission 2016-03-30 09:34:36 +01:00
Rebecca Law
c7c845cea6 Remove access_developer_docs as a permission type. It does not make sense to have permission for viewing the documentation. 
On the downgrade method of the db script the assumption that all users with manage_api_keys had the access_developer_docs permission.
 2016-03-29 17:00:42 +01:00
Rebecca Law
376a074f5f Add view_activity permission so that users can have the default permission to see activity. 
Add view_activity to default permissions when adding a new user.
Add view_activity as a permission group, used when inviting a user.
 2016-03-29 15:35:34 +01:00
Chris Hill-Scott
e3ae81bd0a Strip trailing CSV rows, relax phone validation 
Implements (and depends on):
- https://github.com/alphagov/notifications-utils/pull/14
- https://github.com/alphagov/notifications-utils/pull/15
 2016-03-24 20:30:15 +00:00
Adam Shimali
ed1d988bf4 Merge pull request #184 from alphagov/notifications-return-change 
Align notifications api with docs and other endpoints
 2016-03-24 16:24:43 +00:00
Adam Shimali
7bc81528bb Post endpoint to create notificaition and get endpoint 
to retrieve notification by id return data in shape more
consistent with other api endpoints.
 2016-03-24 13:34:45 +00:00
Nicholas Staples
3a59c75257 Transaction management added for one example. All tests passing. 2016-03-23 16:30:47 +00:00
Nicholas Staples
090babaaeb Added endpoint for removing user from service, all tests passing. 2016-03-22 13:14:23 +00:00
Martyn Inglis
268819284f Merge branch 'master' into capture-delivery-outcomes 
Conflicts:
	tests/app/notifications/test_rest.py
 2016-03-21 13:32:31 +00:00
Martyn Inglis
e0316d1881 Adds notification stats update into the callback process 
- when a provider callback occurs and we update the status of the notification, also update the statistics table

Adds:
- Mapping object to the clients to handle mapping to various states from the response codes, this replaces the map.
- query lookup in the DAO to get the query based on response type / template type

Tests around rest class and dao to check correct updating of stats

Missing:
- multiple client callbacks will keep incrementing the counts of success/failure. This edge case needs to be handle in a future story.
 2016-03-21 13:24:37 +00:00
Nicholas Staples
327f169575 Filtering added and tests working. 2016-03-21 12:37:34 +00:00
Martyn Inglis
e2cfbce8c4 Added base object for response statuses, and tests around it's behaviour 2016-03-21 09:20:38 +00:00
Chris Hill-Scott
a0022455f0 Merge pull request #173 from alphagov/email-wrapper 
Add HTML email
 2016-03-18 15:42:32 +00:00
Martyn Inglis
86579fba71 Merge branch 'master' into capture-delivery-outcomes 2016-03-18 15:35:51 +00:00
Chris Hill-Scott
f3ddf1f456 Add HTML email 
Make the SES client optionally pass through HTML and text body, as per:
http://docs.aws.amazon.com/ses/latest/APIReference/API_Body.html

Gets the message as HTML from:
https://github.com/alphagov/notifications-utils/pull/12
 2016-03-18 15:26:32 +00:00
NIcholas Staples
7d99787146 Merge pull request #161 from alphagov/fix_pagination_bug 
Fix pagination bug and swapped file name with original file name.
 2016-03-18 15:08:30 +00:00
Adam Shimali
2d1d883283 Added task for sending email verification links out on intial 
registration.

Left original email code endpoint in as it is still used for things like
email change.
 2016-03-17 15:21:04 +00:00
minglis
cb0b091468 Merge pull request #164 from alphagov/staging-live-config-seperation 
Allowing overrides on a per environment basis
 2016-03-17 12:56:26 +00:00
Martyn Inglis
9a7788a6f5 Allowing overrides on a per environment basis 2016-03-17 11:47:44 +00:00
Rebecca Law
bd26c4740c Merge branch 'master' into default-stats-to-zero 2016-03-17 11:40:49 +00:00
Rebecca Law
15fac879e3 Merge pull request #162 from alphagov/platform-admin-role 
Add platform_admin boolean on the User data model.
 2016-03-17 11:33:52 +00:00
Rebecca Law
b7f65feadd Set default to 0 for the notification_statistics table. 2016-03-17 11:32:55 +00:00
Rebecca Law
bd2d77fec8 Add platform_admin boolean on the User data model. 2016-03-17 10:37:24 +00:00
Nicholas Staples
c3a15f9f30 Fix pagination bug and swapped file name with original file name. 2016-03-16 16:47:18 +00:00
minglis
e7532d2c64 Merge pull request #158 from alphagov/set-application-name 
Pass application name in from start scripts
 2016-03-16 14:51:50 +00:00
Martyn Inglis
6ceddf0ebf pep8 fixed 2016-03-16 14:08:25 +00:00
Rebecca Law
4268f8453b Use the same validation in the endpoint and the task to validate the phone number is ok to send to. 
Format the phone number before sending it to the sms provider.
 2016-03-16 13:36:46 +00:00
Martyn Inglis
27d48a9746 Pass application name in from start scripts 
- allows logger to log as correct application
 2016-03-16 13:25:09 +00:00
Martyn Inglis
69654f4209 Parking some code that updates stats when notification delivery happens 2016-03-15 14:40:42 +00:00
Nicholas Staples
356083e8ac Update schemas to return more details about the job and template for notifications. 2016-03-15 14:24:10 +00:00
Rebecca Law
2caea40212 Pass the utcnow function, rather than the result of executing the function. 2016-03-15 09:32:43 +00:00
minglis
c2b2ce3878 Merge pull request #151 from alphagov/order-jobs 
Order jobs
 2016-03-14 16:43:48 +00:00
Martyn Inglis
b88b0499b9 Order jobs on dashboard page 2016-03-14 16:31:57 +00:00
Martyn Inglis
beb6f7ca57 Order jobs by service 
- newest first
 2016-03-14 16:15:39 +00:00