darkhelm/notifications-api
1
0
Fork 0
mirror of https://github.com/GSA/notifications-api.git synced 2026-01-02 05:41:57 -05:00
Code Issues Packages Projects Releases Wiki Activity
240 Commits 127 Branches 60 Tags
1b25a3c7628adce9c8ae8be6b8550175edca4021
Commit Graph

125 Commits

Author SHA1 Message Date
Nicholas Staples
1b25a3c762 Removed alpha client imports. 2016-02-09 16:13:48 +00:00
Nicholas Staples
68b6444eed Comment added for missing code. 2016-02-09 16:02:38 +00:00
Nicholas Staples
bd947d0743 Merge remote-tracking branch 'origin/master' into remove_alpha_client_from_api 2016-02-09 15:54:21 +00:00
Adam Shimali
17e5e70f6c [WIP] Added endpoints under /job for creating, updating and reading 
notification status.
 2016-02-09 14:17:42 +00:00
Adam Shimali
e5e049d735 Added service and template relationship to notification model. 
This makes it more consistent with other model classes with respect
to marhmallow serialisation/deserialisation.
 2016-02-09 12:48:27 +00:00
Adam Shimali
c7121be5a2 [WIP] New model class and dao for notification. This will be used for 
recording status and outcome of sending notifications.
 2016-02-09 12:03:40 +00:00
Nicholas Staples
2fda7ee59b Alpha client removed from code. Tests fixed but will wait till other notifications jobs are done before creating a pull request. 2016-02-09 11:38:57 +00:00
Adam Shimali
0580f5ab06 New endpoint for delivery app to use. 
Once removal of code that uses existing alpha is done, then
duplicated code from /notifications/sms and the new endpoint
can be merged.

Job id is now avaiable in notificaiton but is not used yet.
 2016-02-08 14:54:15 +00:00
Rebecca Law
416dd00ac8 Added a test for the case when there is no secret for the api client. 
Fix codestyle
 2016-02-08 11:33:24 +00:00
Rebecca Law
877a8a0411 Added logging for the authentication errors. 
Moved the "no api secret" error message to the end and only create it if there are no
api client secrets
 2016-02-08 11:10:54 +00:00
NIcholas Staples
db1c6749a6 Merge pull request #57 from alphagov/job-details-bug 
Fix for incorrect property name for service and template.
 2016-02-08 10:51:01 +00:00
Nicholas Staples
409857fba6 Now done. 2016-02-08 09:43:19 +00:00
Nicholas Staples
4ecdc9e420 Bug fixed for posting the correct type of notification to the aws queue. 2016-02-08 09:41:10 +00:00
Adam Shimali
23f4ce7255 Fix for incorrect property name for service and template. 2016-02-05 16:33:07 +00:00
Adam Shimali
e024db6858 As job update is a PUT then all non nullable fields 
need to be sent with update.

Also bug in not committing update fixed.
 2016-02-05 13:07:02 +00:00
Nicholas Staples
cc5dad3744 Update queues with a prefix. 2016-02-05 11:12:59 +00:00
Adam Shimali
bec4bbe04e Endpoint and dao method for updating job status. 2016-02-04 20:55:09 +00:00
Adam Shimali
aa57730fc9 Add more properties of job to job message. 2016-02-04 12:36:53 +00:00
Rebecca Law
1d4d03dbe8 Update to create_sms_notification 
Removed the logic to check the api_user is the admin client user name.
There is another controller method to handle sending the verification codes.
 2016-02-04 12:07:26 +00:00
Nicholas Staples
6286646d7f Fix for review comments. 2016-02-03 15:53:16 +00:00
Nicholas Staples
8fd15b44eb Missed a couple of places where we should push to the queue. 2016-02-03 13:52:09 +00:00
Nicholas Staples
aba1cd2ed5 Sqs queues now populated from all create_notification api calls. Marshmallow schemas added for notification. 2016-02-03 13:16:19 +00:00
Adam Shimali
0ade39e63f Add job to queue as soon as it in created. 
Added status to job.
 2016-02-02 15:14:04 +00:00
Rebecca Law
b5c662eca8 Change services.id to a UUID 
Ideally all the primary keys in the db would be UUID in order to guarantee unique ids across distributed dbs.
This updates the services.id to a UUID. All the tables with a foreign key to the services.id are also updated.
The endpoints no longer state a data type of the <service_id> path param.
All the tests are updated to reflect this update.

The thing to pay attention to is the 0011_uuid_service_id.py migration script.
This commit must go with a commit on the notifications_admin app to keep things working.
There will be a small outage until both deploys have happened.
 2016-02-02 14:22:22 +00:00
Adam Shimali
1277837e00 Merge pull request #46 from alphagov/update_version_file_with_travis_details 
version file has been updated to include a travis commit and time of …
 2016-02-02 11:16:15 +00:00
Nicholas Staples
238e8942af Fix for pull request comment. 2016-02-02 11:06:22 +00:00
Adam Shimali
459dc193a3 Merge pull request #44 from alphagov/production_exception_handling 
Added exception handling for 500 error messages. Actually just logging added.
 2016-02-02 10:23:24 +00:00
Nicholas Staples
cd5a91d4c8 version file has been updated to include a travis commit and time of build. 2016-02-01 11:37:22 +00:00
Rebecca Law
0b62005983 Move VERIFY_CODE_TYPES outside the class and use it in the schema 2016-02-01 10:54:32 +00:00
Rebecca Law
cec0d40e5b Create schema for RequestVerifyCodeSchema 
Previously we were using a schema that mapped onto db.Model. However, the json
in the request did not reflect the VerfiyCode db Model.
I did not add validation on the to field, we did not have that previously.
 2016-02-01 10:48:33 +00:00
Nicholas Staples
d56bb82d1d Code style fix. 2016-02-01 10:25:09 +00:00
Nicholas Staples
47351b2009 Added exception handling for 500 error messages. 2016-02-01 10:19:17 +00:00
Rebecca Law
8c20c3e7be Merge pull request #43 from alphagov/update_status_page 
Status page updated with api version and db version.
 2016-01-29 16:39:17 +00:00
Nicholas Staples
99b849171f Status page updated with api version and db version. 2016-01-29 12:51:33 +00:00
Nicholas Staples
2451f7e53d Added support for validation only of put requests. 2016-01-29 11:11:00 +00:00
NIcholas Staples
2bd244032b Merge pull request #41 from alphagov/fix-sms-bug 
Fix bug with sending sms
 2016-01-28 12:49:11 +00:00
Rebecca Law
92cec8831e Fix bug with sending sms 2016-01-28 12:44:05 +00:00
Adam Shimali
806b3f6851 If failed login count > 0 and user subsequently logs in sucessfully, 
then failed logins set to 0.
 2016-01-28 11:58:33 +00:00
Adam Shimali
9bf11b3d40 Merge pull request #39 from alphagov/add_password_update 
Added support for allowing password to updated from the PUT request t…
 2016-01-28 11:54:26 +00:00
Rebecca Law
4010ed61ce Moved creating queue name to model 2016-01-28 11:42:13 +00:00
Nicholas Staples
66c1d858ac Added support for allowing password to updated from the PUT request to the user rest endpoint. 2016-01-28 11:41:21 +00:00
Rebecca Law
03989c09de Add message id to message attributes 2016-01-28 11:09:25 +00:00
Rebecca Law
a546665188 Some code clean up. 
Clean up the unit test.
 2016-01-28 11:06:24 +00:00
Rebecca Law
42a4c8b0b1 Add sms notifications from a service to a queue. 2016-01-27 17:42:05 +00:00
Rebecca Law
daff1c3f53 Add queue name to service table. 
Set queue name when creating the service
 2016-01-27 14:18:11 +00:00
Rebecca Law
3536aef8c0 Use VerifyCodeSchema 2016-01-27 12:11:25 +00:00
Rebecca Law
ba1a496520 Update send user code to use optional to field 'to' send the sms message to. 2016-01-27 11:54:28 +00:00
Rebecca Law
5dc48f8a01 Updated send user code to use an optional to field to send emails 
Added tests for send_user_code
 2016-01-27 11:51:02 +00:00
Rebecca Law
20f71487df Remove trailing slash from /verify/code 2016-01-26 15:32:55 +00:00
Adam Shimali
d62b5bdce7 Record and persist failed login count on api. 2016-01-25 11:14:23 +00:00