Rebecca Law
16eb20371f
Fix import
2016-07-06 15:07:09 +01:00
Rebecca Law
a1209ed9a4
Merge branch 'master' into fix-count
2016-07-06 14:45:10 +01:00
Rebecca Law
8bea8b6a8f
Fix bug where all notifications were getting a type = email.
...
Includes a fix to notification and notification_statistics data.
2016-07-06 14:31:52 +01:00
Leo Hemsted
96513442fe
notifications from test api keys dont send for real - a la research_mode
...
also added a bunch more tests around api keys to help ensure we're behaving in at least a consistent way
2016-07-05 16:29:53 +01:00
Leo Hemsted
242be97bfa
remove reply_to_addresses from task kwargs
...
also added a test for aws_ses.send_email to prove it handles reply_to_address correctly
2016-07-04 17:29:41 +01:00
Leo Hemsted
f5e14f043d
dont pass reply-to-addresses about
...
dont send reply_to_addresses around from process_job and send_email -
take it from the service in send_email_to_provider. also clean up
the kwarg in aws_ses.send_email to more accurately reflect what we
might pass in
2016-07-04 15:04:43 +01:00
Adam Shimali
b32f0ab2cd
Resolve conflicts
2016-07-01 16:53:12 +01:00
Adam Shimali
c29dd23702
Add sms sender to service to be used in sms templates
...
in place of default numeric short code.
If not present default short code is used.
2016-07-01 15:27:54 +01:00
Rebecca Law
4a321497fc
Remove print
2016-07-01 15:03:28 +01:00
Rebecca Law
f52755742c
Split send_email task into one task to create the notification and one to send it to the provider.
...
Is there is an exception the task will go to the retry queue.
2016-07-01 14:14:28 +01:00
Rebecca Law
b3fabae958
Merge and codestyle
2016-06-27 15:38:25 +01:00
Rebecca Law
3346582634
Fix codestyle
2016-06-27 15:32:26 +01:00
Rebecca Law
90e8154700
Added a test that the message is not sent if the status of the notification is not created.
2016-06-27 15:23:23 +01:00
Rebecca Law
8a0211b3eb
Only send to the provider if the notification has a created status.
...
If the notification ends up in the retry queue and the delivery app is restarted the notification will get sent twice.
This is because when the app is restarted another message will be in the retry queue as message available which is a
duplicate of the one in the queue that is a message in flight.
This should complete https://www.pivotaltracker.com/story/show/121844427
2016-06-27 14:47:20 +01:00
Rebecca Law
8f19ad19f8
Stop sending the encrypted message to the send_sms_to_provider task.
...
Everything the task needs is now stored in the db.
2016-06-23 09:41:21 +01:00
Rebecca Law
fcb5ca9ef4
The send_sms task will created the notification with a status = created.
...
The encrypted_notification for the send_sms_to_provider task has been made optional.
2016-06-22 13:32:27 +01:00
Rebecca Law
3d3bff25a8
[WIP] updating notification to start in the created status
2016-06-21 15:51:30 +01:00
Martyn Inglis
51c6d57a86
Changed the delay period. Now waits
...
10 seconds, 1 minute, 5 minutes, 1 hour and 4 hours.
Total elapsed wait is max 5 hours 6 minutes and 10 seconds.
Changed visibility window of SQS to be 4 hours 10 seconds, longer the max retry period.
2016-06-17 16:32:56 +01:00
Martyn Inglis
f143aade71
Added new tests/code to ensure failure stats recorded
2016-06-13 16:40:46 +01:00
Martyn Inglis
6b5b40b953
Added tests for statsd and provider stats outcomes with the new provider stats tasks
...
- note large change to DAO to remove provider from create notification. Added on send now not creation.
2016-06-13 11:38:25 +01:00
Martyn Inglis
b6fa6815ee
Commented out tests in progress
2016-06-07 12:54:25 +01:00
Martyn Inglis
92e4c0872b
Pulled out the tests that send SMSs into provider_tasks file/tests
...
- updated tests to validate creation of next task, not sending direct to provider
2016-06-07 12:53:31 +01:00
Martyn Inglis
642aa2890e
Starting to implement tests across the new tasks file
2016-06-07 11:09:54 +01:00
