Rebecca Law
34aa541199
Merge branch 'master' into add-multiple-reply-to-email-endpoints
2017-09-15 17:13:29 +01:00
Chris Hill-Scott
29a962060f
Return delivery estimate for letter notifications
...
> For get all or get one letter the response needs to be updated so that
> it looks similar to admin app.
>
> status: created|sending --> received letter
> new column: `estimated delivery date`: derived from created at date.
> (see how the admin app is doing it)
>
> NOTE:
> At the moment we only have 2 statuses for a letter created and
> sending, but we will want to have other internal statuses that make
> sense to the Notify team but not our services. When we know those
> statuses the status map will be updated at that point.
– https://www.pivotaltracker.com/story/show/150512525
This commit implements the date (not status) part of this story.
2017-09-15 14:58:07 +01:00
Leo Hemsted
69ba0ba743
Merge pull request #1249 from alphagov/rename-tasks
...
use new send-jobs-to-dvla task instead of send-files-to-dvla
2017-09-15 11:33:52 +01:00
Rebecca Law
6b2c2962c9
New endpoint to insert new service reply to email address and update existing one.
2017-09-14 17:54:38 +01:00
Katie Smith
45512228e1
Merge pull request #1253 from alphagov/add-multiple-reply-to-email-endpoints
...
Add multiple reply to email endpoints
2017-09-14 13:30:45 +01:00
Rebecca Law
a5d3b787e1
Merge branch 'master' into add-multiple-reply-to-email-endpoints
2017-09-14 13:04:01 +01:00
Rebecca Law
5366968cc9
Added some more tests
2017-09-14 12:23:52 +01:00
venusbb
160b878745
Minor change in how we inteprete Incoming IP
2017-09-13 17:23:23 +01:00
venusbb
d4a3c96a75
Merge branch 'master' of https://github.com/alphagov/notifications-api into Inbound-sms-ip
2017-09-13 17:09:58 +01:00
Katie Smith
72760550bd
Add endpoint to get the email reply to addresses for a service
...
- Changed the dao_get_reply_to_by_service_id method to return a list of
results.
- Added a GET /service/<service_id>/email-reply-to endpoint
2017-09-13 16:58:36 +01:00
Rebecca Law
63b62e74bb
Merge pull request #1251 from alphagov/updating-service_sms_senders
...
Insert or update service sms senders
2017-09-13 15:10:11 +01:00
venusbb
9efc17a941
Use ipaddress library for the masked bits
2017-09-13 14:08:23 +01:00
venusbb
c285ab0b45
inbound sms monitoring 24bit mask
2017-09-13 11:29:11 +01:00
Leo Hemsted
2c758cbccd
use new send-jobs-to-dvla task instead of send-files-to-dvla
...
the tasks (on the ftp app) do the same thing, but to improve clarity
i've renamed it to jobs, because we'll be adding a notifications one
soon
2017-09-12 17:28:07 +01:00
kentsanggds
ca1856eb20
Merge pull request #1246 from alphagov/ken-prevent-blank-letter-address
...
Raise validation errors for empty letter fields
2017-09-12 14:36:54 +01:00
Rebecca Law
3779f9d1df
Merge branch 'master' into updating-service_sms_senders
2017-09-12 12:11:38 +01:00
Rebecca Law
5439b01a6e
When an inbound number is allocated insert or update a row in service_sms_senders.
2017-09-12 12:09:32 +01:00
Rebecca Law
d356957974
Change the ServiceEmailReplyTo model to uselist for the backref to services (allow 0 to many reply to emails)
...
Add another assert in the test
2017-09-12 10:14:58 +01:00
Katie Smith
269e88f7de
Update reply to email test
...
- Updated reply to email test so that the request to create or update
email is not mocked.
- Excluded reply_to_email_addresses from the Service schema
2017-09-12 09:07:34 +01:00
Rebecca Law
f624f4f033
Insert and update methods for service_sms_sender
2017-09-11 17:40:37 +01:00
Ken Tsang
41f427d6dd
Update definitions to check non empty strings
2017-09-11 15:37:40 +01:00
Rebecca Law
0a21f1f3e8
Small refactor to how notification_schemas are tested.
...
My local build was not always getting the optional requirement for the jsonschema uri format checker (rfc3987).
The requirement has been added to the requirements_for_test file.
I changed the tests to validate the response schema from the post_notifications tests, this way we can tell if we are breaking the contract.
This showed that the email_from was not returning the entire email address but just the username, that has been corrected here.
Removed the response schema validation tests since they are not being testing in the post notification tests.
2017-09-11 11:10:45 +01:00
Imdad Ahad
6d0ad75a60
Upsert to new email reply to table when updating a service
2017-09-08 14:56:05 +01:00
Katie Smith
01eef6c7f5
Add service_email_reply_to DAO with an upsert method
2017-09-08 14:56:05 +01:00
Rebecca Law
4f57f2c5a5
Change test to use json loads so that the test will pass consistently
2017-09-08 09:56:46 +01:00
Leo Hemsted
3d2e788a4d
Merge pull request #1226 from alphagov/backfill-perf-stats
...
Backfill perf stats
2017-09-05 16:55:43 +01:00
Rebecca Law
e32abb0ada
Merge pull request #1221 from alphagov/ken-no-letters-when-trial
...
Stop letters when service is in trial
2017-09-05 15:33:50 +01:00
Katie Smith
dbeec6c88b
Remove unused fixtures from tests
2017-09-05 11:50:39 +01:00
Rebecca Law
19f964a90b
Added a check that the call is not using a test api key.
...
Removed the tests for trial mode service for the scheduled tasks and the process job.
Having the validation in the POST notification and create job endpoint is enough.
Updated the test_service_whitelist test because the order of the array is not gaurenteed.
2017-09-04 17:24:41 +01:00
Leo Hemsted
b2436b3e02
add command to application.py
2017-08-31 15:01:38 +01:00
Leo Hemsted
378b131c59
add batch task to backfill processing time data
...
give it a start date and an end date, and it'll send data to the
performance platform for all dates in that (inclusive)
2017-08-31 14:41:05 +01:00
Imdad Ahad
3f34f8fa3e
Merge pull request #1222 from alphagov/get-performance-stats
...
Get performance stats
2017-08-31 14:17:42 +01:00
Imdad Ahad
96443f5d6e
Combine test to query notifications within date range instead
2017-08-31 13:52:56 +01:00
Imdad Ahad
72de309b26
Make perf platform processing stats query the NotificationHistory table
2017-08-31 12:52:59 +01:00
Imdad Ahad
ea2f838510
Fix typo
2017-08-31 11:10:54 +01:00
Imdad Ahad
e39c202a01
Merge pull request #1195 from alphagov/imdad-refactor-remove-unused-billing-code
...
Remove unused billing usage code
2017-08-31 10:39:12 +01:00
Ken Tsang
d391919677
Refactored to check trial when running scheduled job
2017-08-30 22:30:05 +01:00
Ken Tsang
225c85832c
Refactored to update job status and not build dvla file
2017-08-30 16:04:10 +01:00
Ken Tsang
01830b7e59
Push letter job to research queue in research mode
2017-08-30 16:04:10 +01:00
Ken Tsang
ff860ec242
403 when creating a letter job in trial mode
2017-08-30 16:04:10 +01:00
Ken Tsang
7e70b44113
Error in task when letter template and in trial mode
2017-08-30 16:04:10 +01:00
Ken Tsang
41a71c703b
Refactor test
2017-08-30 16:04:10 +01:00
Ken Tsang
8f82642422
Prevent v2 notifications POST when in trial mode
2017-08-30 16:04:10 +01:00
Katie Smith
49a6bfc06b
Send '0', not 'null', to perf platform if no notifications are sent
2017-08-30 16:02:30 +01:00
Chris Hill-Scott
b346d5d173
Merge pull request #1219 from alphagov/international-sms-notify
...
Allow Notify service to send international sms
2017-08-30 15:53:19 +01:00
Imdad Ahad
af54d98faa
Remove unused imports
2017-08-30 14:40:54 +01:00
Imdad Ahad
e1ef0e85c6
Remove monthly usage dao methods
2017-08-30 14:40:54 +01:00
Imdad Ahad
994e797b26
Replace 'sms' with SMS_TYPE
2017-08-30 14:40:29 +01:00
Imdad Ahad
c92b72da6e
Remove yearly billing data dao methods
2017-08-30 14:40:29 +01:00
Katie Smith
a1a5fdedb1
Send results of processing-time query to performance platform
2017-08-30 14:40:10 +01:00
