Commit Graph

6987 Commits

Author SHA1 Message Date
Leo Hemsted
ff77814e36 Merge pull request #931 from alphagov/csv-status
add type conversion to report downloads
2017-04-28 11:04:05 +01:00
Leo Hemsted
fd4e27bfd3 add type conversion to report downloads
"sent" is fine as an internal marker but not very obvious to the end
user that it specifically refers to international messages. We now
say "Sent internationally" in the CSV
2017-04-28 11:00:55 +01:00
Ken Tsang
baf84b53d3 Update test to check it doesn't get email usage 2017-04-28 10:10:49 +01:00
Rebecca Law
3b41478a0a Updated Notification model to use Float(asdecimal=False) for rate_mutliplier.
Added test with multiple rows for a month.
2017-04-28 10:10:49 +01:00
Rebecca Law
1a64509186 Change the resultset from the yearly and monthly billing data queries.
Fix some formatting of the return objects.
2017-04-28 10:10:49 +01:00
Rebecca Law
fdbadf967e Fix the email billing data when there is no results. 2017-04-28 10:10:48 +01:00
Rebecca Law
a186fc95be Added new endpoints to return the yearly-usage and monthly-usage for a given financial year and service id.
Since the response has changed I have created new endpoints so that the deployments for Admin are more managable.

Removed print statements from some tests.
2017-04-28 10:10:48 +01:00
Rebecca Law
e1e55edd9c Add new fields to the usage queries: rate_multiplier, international, phone_prefix. 2017-04-28 10:10:48 +01:00
Rebecca Law
4c37c8bdbb New query to get billing data per month. 2017-04-28 10:10:48 +01:00
Rebecca Law
6dc336ad6c Created new queries to return the rate with the sum of billable units for the year totals.
Once we have the new columns in notifications table, the query will need to include the rate multiplier and if the number is international.
The monthly billing query will be built next.
2017-04-28 10:10:48 +01:00
Imdad Ahad
93287719e4 Merge pull request #930 from alphagov/set-status-to-sent-on-int-numbers
Send to provider for international
2017-04-28 09:55:01 +01:00
Imdad Ahad
b5d4acb758 Make message more accurate 2017-04-27 16:58:00 +01:00
Imdad Ahad
e450f15b2b Fix typo and update test now that we expect sent for international 2017-04-27 16:57:04 +01:00
Imdad Ahad
c5bd685cef Don't update sent notifications (dao) 2017-04-27 16:55:39 +01:00
Martyn Inglis
349fb3529e Handle case for international SMS - use correct phone validator, and also set status correctly.
This relies on some other code so this commit has placeholder failing tests to be populated when other PRs are merged.
2017-04-27 16:27:14 +01:00
Imdad Ahad
1b483f5f1e Merge pull request #929 from alphagov/remove-references-to-old-utils
Remove references to old utils code
2017-04-27 16:22:55 +01:00
Chris Hill-Scott
698b20596f Remove references to old utils code
These methods don’t exist any more.

Not doing this reformatting in the tests probably makes the tests more
robust too 😬
2017-04-27 16:03:27 +01:00
Imdad Ahad
162fc8de04 Merge pull request #925 from alphagov/feat-use-intl-provider-send-sms
Feat use intl provider send sms
2017-04-27 15:33:45 +01:00
Imdad Ahad
c1651013af Merge pull request #927 from alphagov/persist-notification-intl
Persist international notification fields
2017-04-27 14:06:41 +01:00
Imdad Ahad
164ba0c6b3 as_decimal defaults to False 2017-04-27 13:50:51 +01:00
Imdad Ahad
3de93cbcd0 Assume that we will only receive a UK number:
* We currently don't validate the number so this test
* will fail assuming an invalid number was passed.
* Since we do validation on the front end, for now
* we'll assume a valid number. This does need to be
* looked at in future.
2017-04-27 13:24:48 +01:00
Imdad Ahad
868e102f8a Make rate_multiplier on notification return non-decimal 2017-04-27 13:24:42 +01:00
Imdad Ahad
252c3235d7 Persist intl fields on notification 2017-04-27 13:24:36 +01:00
minglis
a8ea333606 Merge pull request #923 from alphagov/validate-int-numbers-on-api
Validate International phone numbers
2017-04-27 13:21:04 +01:00
Martyn Inglis
99081488f1 Mock out some SQS calls 2017-04-27 12:47:08 +01:00
Leo Hemsted
d4dd15118f Merge pull request #922 from alphagov/sent-status
Sent status
2017-04-27 12:30:16 +01:00
Martyn Inglis
bedbd8e21f Removed unneeded test case 2017-04-27 12:15:47 +01:00
Martyn Inglis
cdd3ad687c updated the fixture 2017-04-27 12:14:31 +01:00
Martyn Inglis
109b1727f2 Fish out the international provider if needed. 2017-04-27 12:14:22 +01:00
Martyn Inglis
ba58c55c3b Filter provider details by international flags 2017-04-27 12:13:58 +01:00
Martyn Inglis
84860b2a1d Adds a debug line to try and debug jenkins 2017-04-27 10:41:31 +01:00
Imdad Ahad
d0978e52fb Use intl provider for int sms notifications (needs tests) 2017-04-27 10:18:28 +01:00
Martyn Inglis
83dc7c2bb7 Little test updates 2017-04-27 09:58:37 +01:00
Martyn Inglis
56a82bb593 Bumped utils version 2017-04-27 09:45:36 +01:00
Martyn Inglis
86a5445fb6 Bumped utils version 2017-04-27 09:26:12 +01:00
Martyn Inglis
2a1c3c248f Bumped utils 2017-04-26 21:21:00 +01:00
Martyn Inglis
dfbca8043e Fixed typo errors 2017-04-26 21:08:43 +01:00
Imdad Ahad
05145afcec Fix tests for checking simulated recipients 2017-04-26 17:26:06 +01:00
Leo Hemsted
c8c6675ec6 set migration number 2017-04-26 16:54:24 +01:00
Leo Hemsted
a138ec478a Merge branch 'master' into sent-status 2017-04-26 16:52:16 +01:00
Leo Hemsted
9afc07175a fix typo in downgrade 2017-04-26 16:51:40 +01:00
Martyn Inglis
2a0f8c8808 Validate International phone numbers
- uses new utils methods to validate phone numbers
- defaults to International=True on validation. This ensures the validator works on all numbers
- Then check if the user can send this message to the number internationally if needed.
2017-04-26 15:56:45 +01:00
Imdad Ahad
f77b82a4a5 Merge pull request #921 from alphagov/migration-add-intl-notification-fields
Add intl notification fields
2017-04-26 13:14:42 +01:00
Imdad Ahad
68edd7a33f Fix PEP issues :-| 2017-04-26 11:52:03 +01:00
Imdad Ahad
014a29170c Rebase off master 2017-04-26 11:31:58 +01:00
Imdad Ahad
26b35c5d15 Add intl notificiation fields 2017-04-26 11:31:05 +01:00
Imdad Ahad
3d312c7342 Merge pull request #918 from alphagov/feat-add-intl-provider-migration
Add international support flag for providers (migration)
2017-04-26 11:15:26 +01:00
Imdad Ahad
c69ee2405a Fix comment 2017-04-26 10:37:12 +01:00
Martyn Inglis
ad8e445558 Reformatted code 2017-04-26 10:24:39 +01:00
Imdad Ahad
5171547990 Remove blank lines 2017-04-26 09:52:02 +01:00