darkhelm/notifications-api
1
0
Fork 0
mirror of https://github.com/GSA/notifications-api.git synced 2026-01-01 21:31:58 -05:00
Code Issues Packages Projects Releases Wiki Activity
6,987 Commits 127 Branches 60 Tags
02c824a980db5b3c11294de0eca663452bdb2da3
Commit Graph

6987 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Rebecca Law
7d763260ce Update format of the errors for DataError and exception 2016-11-10 14:53:39 +00:00
Rebecca Law
26d6a0c1a9 Merge branch 'master' into change-v2-error-resp 2016-11-10 14:21:20 +00:00
Leo Hemsted
17cf582502 Merge branch 'master' into active-service 2016-11-10 13:54:02 +00:00
Leo Hemsted
abecb5ff98 Merge pull request #726 from alphagov/auth-500 
update python client to 2.0.0
 2016-11-10 13:47:34 +00:00
Leo Hemsted
dd004a6154 Merge pull request #727 from alphagov/exc-handl 
remove 500/unplanned exception handlers in test
 2016-11-10 13:47:13 +00:00
Martyn Inglis
6c27f8023e Added tests for setting and fetching from redis respecting the enabled flag. 2016-11-10 13:22:38 +00:00
Imdad Ahad
f85ee54707 Refactor stuff + stricter validation for updating only ALLOWED user attrs 2016-11-10 13:09:25 +00:00
Imdad Ahad
8b64aa7e79 Use POST endpoint for updating a user attr 2016-11-10 12:07:29 +00:00
Martyn Inglis
aabda3f83e Refactored the initialisation of the redis client to follow the model used in the StatsdClient. 
Basically wrapped the client so we can enable/disable, exception handle and so on.
 2016-11-10 11:50:49 +00:00
Chris Hill-Scott
988bf06132 Update error message for invalid email addresses 
It has a trailing full stop since:
https://github.com/alphagov/notifications-utils/pull/76
 2016-11-10 11:40:00 +00:00
Chris Hill-Scott
8474344c9a Ignore case and whitespace in personalisation keys 
From a support ticket:

> it's possible to add a personalisation token with trailing whitespace
> (eg. "key " rather than "key"). Can this be trimmed in the UI to guard
> against this? (one of our devs copied and pasted it from a document
> and inadvertently included the space)

> Nothing major but caused a few hours of investigations!

Rather than trim the placeholder in the template, we should treat
placeholders in API calls the same way we do with CSV files, ie we
ignore case and spacing in the name of the placeholder. So
`(( First Name))` is equivalent to `((first_name))`, and both would be
populated with a dictionary like `{'firstName': 'Chris'}`.

Depends on:
- [x] https://github.com/alphagov/notifications-utils/pull/77
 2016-11-10 11:40:00 +00:00
Martyn Inglis
eb94fe6c0a Adding Flask-Redis to the project. 
[https://pypi.python.org/pypi/Flask-Redis/0.1.0](https://pypi.python.org/pypi/Flask-Redis/0.1.0)

Initial addition as we think about redis as cache.
 2016-11-10 11:27:57 +00:00
Martyn Inglis
23cc37e2d1 Merge branch 'master' into caching-with-redis 2016-11-10 11:09:04 +00:00
Leo Hemsted
e8c3a5cdde add check for inactive services to auth handler 
cleaned up some auth code to marginally improve efficiency of error checking
and hopefully make it easier to read

fixed some incorrect auth headers in the deactivate tests
 2016-11-10 11:07:12 +00:00
Leo Hemsted
b2149bf02a undo unnecessary change to models 2016-11-10 10:38:36 +00:00
Leo Hemsted
b0e240267a add only_active flag to get services functionality 2016-11-09 15:07:23 +00:00
Rebecca Law
346d90e319 update V2 error response to 
{status_code: 403,
 errors: [error: AuthError, message: token has expired}]
}
 2016-11-09 14:56:54 +00:00
Imdad Ahad
31dfc36094 Merge branch 'master' into update-user-profile-endpoints 2016-11-09 12:41:21 +00:00
Leo Hemsted
d4a300ec7a add only_active flag to GET /services/ 
does what it says on the tin
 2016-11-09 11:45:39 +00:00
Leo Hemsted
3cbacecf19 fix non-functional/overengineered existing tests 2016-11-09 11:32:07 +00:00
Leo Hemsted
efd2be9acb set service to active on creation 2016-11-08 17:10:28 +00:00
Leo Hemsted
f6de17d6b7 dont let people accidentally delete their local database by forcing it to run against a different DB (ie test_notifications_api) 2016-11-08 17:10:28 +00:00
Leo Hemsted
089ac099f3 POST /service/{id}/deactivate deactivates a service: 
* set active=False on the service
* renames service to "_archived_{old_name}"
* archives all templates for the service
* revokes all api keys for the service
 2016-11-08 17:10:28 +00:00
Leo Hemsted
da2fa5b4bc move sqlalchemy defaults from booleans to SQL constructs 
booleans aren't actually allowed, and quietly do nothing

also default Services.active to true
 2016-11-08 17:10:28 +00:00
Rebecca Law
78e84801bd Merge branch 'master' into change-v2-error-resp 2016-11-08 15:59:42 +00:00
Imdad Ahad
34892694f3 Fix merge conflicts 2016-11-07 17:45:01 +00:00
Imdad Ahad
3f10e59db3 Add user dao method to update a single user attr 2016-11-07 17:42:39 +00:00
Imdad Ahad
461d8a9b2c Add separate endpoint to update a single user attr 2016-11-07 17:42:23 +00:00
Imdad Ahad
8a126c7387 Add a schema to validate a single user attr 'strictly' 2016-11-07 17:41:49 +00:00
Chris Hill-Scott
bec20d3854 Merge pull request #728 from alphagov/case-insensitive-auth-header 
Make bearer prefix on auth header case insensitive
 2016-11-07 14:59:09 +01:00
imdadahad
273984a629 Merge pull request #729 from alphagov/logging-around-jobs-and-tasks 
Added job id to logger
 2016-11-07 12:00:48 +00:00
Martyn Inglis
15ba0a3eb1 Added job id to logger 2016-11-07 11:59:46 +00:00
Martyn Inglis
aea2356ae1 Initial SPIKE into redis for cache 2016-11-07 11:55:59 +00:00
Chris Hill-Scott
9248e72c50 Make bearer prefix on auth header case insensitive 
From a support ticket:

> the "Bearer" prefix on the auth header is case sensitive. Can this be
> made case-insensitive?

Sure can 🙃
 2016-11-07 10:49:05 +00:00
Leo Hemsted
f842a8c893 update test to pytest.raises instaed of assert response == 500 2016-11-04 17:04:51 +00:00
Leo Hemsted
ed187f7fad remove 500/unplanned exception handlers in test 
this means if your code throws an exception, in the test you'll see the full stack trace to help debugging
 2016-11-04 16:37:55 +00:00
Leo Hemsted
f089b75129 update python client to 2.0.0 
this is to prevent 500 errors because <2.0.0 raised AssertionError
if supplied JWT tokens were incorrectly formatted

tests added
 2016-11-03 17:05:25 +00:00
Imdad Ahad
a41e7d5a2f Add the right password check 2016-11-03 11:46:58 +00:00
Imdad Ahad
37c95b08b6 Refactor saving user profile 2016-11-03 11:11:51 +00:00
bandesz
edf22860e1 Bump boto version to 2.43.0-patch3 2016-11-02 17:59:09 +00:00
Rebecca Law
4cb38e2d12 Use status_code in error response. 
Remove code.
 2016-11-02 14:58:39 +00:00
Rebecca Law
db91a87fb2 Remove link from v2 error response 2016-11-02 14:48:15 +00:00
Rebecca Law
9f9ec28e2c Merge pull request #724 from alphagov/post-sms-v2 
Move jsonschema to requirements.txt to missing dependency
 2016-11-02 14:16:27 +00:00
Rebecca Law
83f3c92c24 Move jsonschema to requirements.txt to missing dependency 2016-11-02 14:02:06 +00:00
Rebecca Law
58a010ae77 Merge pull request #721 from alphagov/post-sms-v2 
Post sms v2
 2016-11-02 13:38:42 +00:00
Rebecca Law
36ac00811d Create dict for the fields in the error response. 2016-11-02 09:13:48 +00:00
Rebecca Law
e32978b72a Merge branch 'master' into post-sms-v2 2016-11-02 09:08:26 +00:00
Rebecca Law
482d10545b Improvements to the tests. 
Update AuthError with a to_dict_v2 method.
 2016-11-01 10:33:34 +00:00
Rebecca Law
a358f3cb3a Error handler for schema validation errors 2016-10-31 15:43:11 +00:00
Chris Hill-Scott
5485252b85 Merge pull request #720 from alphagov/utils-bump-email-newline 
Bump utils
 2016-10-31 16:05:37 +01:00