darkhelm/notifications-api
1
0
Fork 0
mirror of https://github.com/GSA/notifications-api.git synced 2026-09-08 01:28:24 -04:00
Code Issues Packages Projects Releases Wiki Activity

Remove letters-related code (#175)

Browse Source 
This deletes a big ol' chunk of code related to letters. It's not everything—there are still a few things that might be tied to sms/email—but it's the the heart of letters function. SMS and email function should be untouched by this.

Areas affected:

- Things obviously about letters
- PDF tasks, used for precompiling letters
- Virus scanning, used for those PDFs
- FTP, used to send letters to the printer
- Postage stuff
This commit is contained in:
Steven Reilly
2023-03-02 20:20:31 -05:00
committed by GitHub
parent b07b95f795
commit ff4190a8eb
141 changed files with 1108 additions and 12083 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
tests/app/dao/test_service_data_retention_dao.py
View File

@@ -17,27 +17,23 @@ from tests.app.db import create_service, create_service_data_retention
def test_fetch_service_data_retention(sample_service):
email_data_retention = insert_service_data_retention(sample_service.id, 'email', 3)
letter_data_retention = insert_service_data_retention(sample_service.id, 'letter', 30)
sms_data_retention = insert_service_data_retention(sample_service.id, 'sms', 5)
list_of_data_retention = fetch_service_data_retention(sample_service.id)
assert len(list_of_data_retention) == 3
assert len(list_of_data_retention) == 2
assert list_of_data_retention[0] == email_data_retention
assert list_of_data_retention[1] == sms_data_retention
assert list_of_data_retention[2] == letter_data_retention
def test_fetch_service_data_retention_only_returns_row_for_service(sample_service):
another_service = create_service(service_name="Another service")
email_data_retention = insert_service_data_retention(sample_service.id, 'email', 3)
letter_data_retention = insert_service_data_retention(sample_service.id, 'letter', 30)
insert_service_data_retention(another_service.id, 'sms', 5)
list_of_data_retention = fetch_service_data_retention(sample_service.id)
assert len(list_of_data_retention) == 2
assert len(list_of_data_retention) == 1
assert list_of_data_retention[0] == email_data_retention
assert list_of_data_retention[1] == letter_data_retention
def test_fetch_service_data_retention_returns_empty_list_when_no_rows_for_service(sample_service):
@@ -136,10 +132,7 @@ def test_update_service_data_retention_does_not_update_row_if_data_retention_is_
@pytest.mark.parametrize('notification_type, alternate',
[('sms', 'email'),
('email', 'sms'),
('letter', 'email'),
('letter', 'sms')]
)
('email', 'sms')])
def test_fetch_service_data_retention_by_notification_type(sample_service, notification_type, alternate):
data_retention = create_service_data_retention(service=sample_service, notification_type=notification_type)
create_service_data_retention(service=sample_service, notification_type=alternate)