From ff1ffc7fba70860093beb59cbe56e1dc4faa92dd Mon Sep 17 00:00:00 2001 From: Toby Lorne Date: Thu, 22 Oct 2020 12:22:11 +0100 Subject: [PATCH] clients: cbc_proxy lambda client is unabbreviated for code clarity Signed-off-by: Toby Lorne --- app/clients/cbc_proxy.py | 4 ++-- tests/app/clients/test_cbc_proxy.py | 16 ++++++++-------- 2 files changed, 10 insertions(+), 10 deletions(-) diff --git a/app/clients/cbc_proxy.py b/app/clients/cbc_proxy.py index 9f990cc38..73db662ba 100644 --- a/app/clients/cbc_proxy.py +++ b/app/clients/cbc_proxy.py @@ -46,7 +46,7 @@ class CBCProxyNoopClient: class CBCProxyClient: def init_app(self, app): - self._ld_client = boto3.client( + self._lambda_client = boto3.client( 'lambda', region_name='eu-west-2', aws_access_key_id=app.config['CBC_PROXY_AWS_ACCESS_KEY_ID'], @@ -63,7 +63,7 @@ class CBCProxyClient: 'description': description, }), encoding='utf8') - result = self._ld_client.invoke( + result = self._lambda_client.invoke( FunctionName='bt-ee-1-proxy', InvocationType='RequestResponse', Payload=payload_bytes, diff --git a/tests/app/clients/test_cbc_proxy.py b/tests/app/clients/test_cbc_proxy.py index 705d91c28..606231f62 100644 --- a/tests/app/clients/test_cbc_proxy.py +++ b/tests/app/clients/test_cbc_proxy.py @@ -16,13 +16,13 @@ def cbc_proxy(client, mocker): return client -def test_cbc_proxy_ld_client_has_correct_region(cbc_proxy): - assert cbc_proxy._ld_client._client_config.region_name == 'eu-west-2' +def test_cbc_proxy_lambda_client_has_correct_region(cbc_proxy): + assert cbc_proxy._lambda_client._client_config.region_name == 'eu-west-2' -def test_cbc_proxy_ld_client_has_correct_keys(cbc_proxy): - key = cbc_proxy._ld_client._request_signer._credentials.access_key - secret = cbc_proxy._ld_client._request_signer._credentials.secret_key +def test_cbc_proxy_lambda_client_has_correct_keys(cbc_proxy): + key = cbc_proxy._lambda_client._request_signer._credentials.access_key + secret = cbc_proxy._lambda_client._request_signer._credentials.secret_key assert key == 'cbc-proxy-aws-access-key-id' assert secret == 'cbc-proxy-aws-secret-access-key' @@ -35,7 +35,7 @@ def test_cbc_proxy_create_and_send_invokes_function(mocker, cbc_proxy): ld_client_mock = mocker.patch.object( cbc_proxy, - '_ld_client', + '_lambda_client', create=True, ) @@ -71,7 +71,7 @@ def test_cbc_proxy_create_and_send_handles_invoke_error(mocker, cbc_proxy): ld_client_mock = mocker.patch.object( cbc_proxy, - '_ld_client', + '_lambda_client', create=True, ) @@ -102,7 +102,7 @@ def test_cbc_proxy_create_and_send_handles_function_error(mocker, cbc_proxy): ld_client_mock = mocker.patch.object( cbc_proxy, - '_ld_client', + '_lambda_client', create=True, )