darkhelm/notifications-api
1
0
Fork 0
mirror of https://github.com/GSA/notifications-api.git synced 2026-08-23 15:56:45 -04:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #3353 from alphagov/letter-sending-cc-dvla-180096891

Browse Source 
CC DVLA in tickets about outstanding letters
This commit is contained in:
Ben Thorner
2021-10-29 15:04:16 +01:00
committed by GitHub
parent 32873ef70f d1586a8f81
commit fd7373ed73
4 changed files with 5 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
app/celery/nightly_tasks.py
View File

@@ -185,6 +185,7 @@ def raise_alert_if_letter_notifications_still_sending():
ticket = NotifySupportTicket( ticket = NotifySupportTicket(
subject=f"[{current_app.config['NOTIFY_ENVIRONMENT']}] Letters still sending", subject=f"[{current_app.config['NOTIFY_ENVIRONMENT']}] Letters still sending",
email_ccs=current_app.config['DVLA_EMAIL_ADDRESSES'],
message=message, message=message,
ticket_type=NotifySupportTicket.TYPE_INCIDENT, ticket_type=NotifySupportTicket.TYPE_INCIDENT,
technical_ticket=True, technical_ticket=True,

2
requirements-app.txt
View File

@@ -36,7 +36,7 @@ notifications-python-client==6.0.2
# PaaS # PaaS
awscli-cwlogs==1.4.6 awscli-cwlogs==1.4.6
git+https://github.com/alphagov/notifications-utils.git@46.1.0#egg=notifications-utils==46.1.0 git+https://github.com/alphagov/notifications-utils.git@47.1.0#egg=notifications-utils==47.1.0
# gds-metrics requires prometheseus 0.2.0, override that requirement as 0.7.1 brings significant performance gains # gds-metrics requires prometheseus 0.2.0, override that requirement as 0.7.1 brings significant performance gains
prometheus-client==0.10.1 prometheus-client==0.10.1

4
requirements.txt
View File

@@ -38,7 +38,7 @@ notifications-python-client==6.0.2
# PaaS # PaaS
awscli-cwlogs==1.4.6 awscli-cwlogs==1.4.6
git+https://github.com/alphagov/notifications-utils.git@46.1.0#egg=notifications-utils==46.1.0 git+https://github.com/alphagov/notifications-utils.git@47.1.0#egg=notifications-utils==47.1.0
# gds-metrics requires prometheseus 0.2.0, override that requirement as 0.7.1 brings significant performance gains # gds-metrics requires prometheseus 0.2.0, override that requirement as 0.7.1 brings significant performance gains
prometheus-client==0.10.1 prometheus-client==0.10.1
@@ -52,7 +52,7 @@ attrs==21.2.0
awscli==1.21.4 awscli==1.21.4
bcrypt==3.2.0 bcrypt==3.2.0
billiard==3.3.0.23 billiard==3.3.0.23
bleach==3.3.0 bleach==4.1.0
blinker==1.4 blinker==1.4
boto==2.49.0 boto==2.49.0
boto3==1.19.4 boto3==1.19.4

1
tests/app/celery/test_nightly_tasks.py
View File

@@ -250,6 +250,7 @@ def test_create_ticket_if_letter_notifications_still_sending(notify_api, mocker)
mock_create_ticket.assert_called_once_with( mock_create_ticket.assert_called_once_with(
ANY, ANY,
subject='[test] Letters still sending', subject='[test] Letters still sending',
email_ccs=current_app.config['DVLA_EMAIL_ADDRESSES'],
message=( message=(
"There are 1 letters in the 'sending' state from Monday 15 January. Resolve using " "There are 1 letters in the 'sending' state from Monday 15 January. Resolve using "
"https://github.com/alphagov/notifications-manuals/wiki/Support-Runbook#deal-with-letters-still-in-sending" "https://github.com/alphagov/notifications-manuals/wiki/Support-Runbook#deal-with-letters-still-in-sending"