darkhelm/notifications-api
1
0
Fork 0
mirror of https://github.com/GSA/notifications-api.git synced 2025-12-16 02:02:13 -05:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #1315 from alphagov/callback-ip-whitelist

Browse Source 
Remove ip whitelist from callbacks
This commit is contained in:
Leo Hemsted
2017-10-16 13:55:06 +01:00
committed by GitHub
parent 87b819dd53 d33c25bdac
commit fd5aa7dd0a
2 changed files with 6 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
app/__init__.py
View File

@@ -117,9 +117,13 @@ def register_blueprint(application):
ses_callback_blueprint.before_request(requires_no_auth) ses_callback_blueprint.before_request(requires_no_auth)
application.register_blueprint(ses_callback_blueprint) application.register_blueprint(ses_callback_blueprint)
sms_callback_blueprint.before_request(restrict_ip_sms) # delivery receipts
# TODO: make sure research mode can still trigger sms callbacks, then re-enable this
# sms_callback_blueprint.before_request(restrict_ip_sms)
sms_callback_blueprint.before_request(requires_no_auth)
application.register_blueprint(sms_callback_blueprint) application.register_blueprint(sms_callback_blueprint)
# inbound sms
receive_notifications_blueprint.before_request(restrict_ip_sms) receive_notifications_blueprint.before_request(restrict_ip_sms)
application.register_blueprint(receive_notifications_blueprint) application.register_blueprint(receive_notifications_blueprint)

2
app/delivery/send_to_providers.py
View File

@@ -54,8 +54,8 @@ def send_sms_to_provider(notification):
if service.research_mode or notification.key_type == KEY_TYPE_TEST: if service.research_mode or notification.key_type == KEY_TYPE_TEST:
notification.billable_units = 0 notification.billable_units = 0
update_notification(notification, provider)
send_sms_response(provider.get_name(), str(notification.id), notification.to) send_sms_response(provider.get_name(), str(notification.id), notification.to)
update_notification(notification, provider)
else: else:
try: try:
provider.send_sms( provider.send_sms(