darkhelm/notifications-api
1
0
Fork 0
mirror of https://github.com/GSA/notifications-api.git synced 2026-08-24 00:06:16 -04:00
Code Issues Packages Projects Releases Wiki Activity

fix tests

Browse Source
This commit is contained in:
Kenneth Kehl
2024-02-02 09:32:24 -08:00
parent a028be238b
commit fad3d4f473
3 changed files with 4 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
tests/app/notifications/test_process_notification.py
View File

@@ -256,8 +256,6 @@ def test_send_notification_to_queue_throws_exception_deletes_notification(
[ [
("+14254147755", "sms", True), ("+14254147755", "sms", True),
("+14254147167", "sms", True), ("+14254147167", "sms", True),
("2028675000", "sms", True),
("2028675111", "sms", True),
("simulate-delivered@notifications.service.gov.uk", "email", True), ("simulate-delivered@notifications.service.gov.uk", "email", True),
("simulate-delivered-2@notifications.service.gov.uk", "email", True), ("simulate-delivered-2@notifications.service.gov.uk", "email", True),
("simulate-delivered-3@notifications.service.gov.uk", "email", True), ("simulate-delivered-3@notifications.service.gov.uk", "email", True),
@@ -274,7 +272,7 @@ def test_simulated_recipient(notify_api, to_address, notification_type, expected
'simulate-delivered-2@notifications.service.gov.uk', 'simulate-delivered-2@notifications.service.gov.uk',
'simulate-delivered-2@notifications.service.gov.uk' 'simulate-delivered-2@notifications.service.gov.uk'
) )
SIMULATED_SMS_NUMBERS = ('+12028675000', '+12028675111', '+12028675222') SIMULATED_SMS_NUMBERS = ("+14254147755", "+14254147167")
""" """
formatted_address = None formatted_address = None

2
tests/app/service/send_notification/test_send_notification.py
View File

@@ -881,7 +881,7 @@ def test_should_not_persist_notification_or_send_email_if_simulated_email(
assert Notification.query.count() == 0 assert Notification.query.count() == 0
@pytest.mark.parametrize("to_sms", ["2028675000", "2028675111", "+12028675222"]) @pytest.mark.parametrize("to_sms", ["+14254147755", "+14254147167"])
def test_should_not_persist_notification_or_send_sms_if_simulated_number( def test_should_not_persist_notification_or_send_sms_if_simulated_number(
client, to_sms, sample_template, mocker client, to_sms, sample_template, mocker
): ):

5
tests/app/v2/notifications/test_post_notifications.py
View File

@@ -532,9 +532,8 @@ def test_post_email_notification_returns_201(
("simulate-delivered@notifications.service.gov.uk", EMAIL_TYPE), ("simulate-delivered@notifications.service.gov.uk", EMAIL_TYPE),
("simulate-delivered-2@notifications.service.gov.uk", EMAIL_TYPE), ("simulate-delivered-2@notifications.service.gov.uk", EMAIL_TYPE),
("simulate-delivered-3@notifications.service.gov.uk", EMAIL_TYPE), ("simulate-delivered-3@notifications.service.gov.uk", EMAIL_TYPE),
("2028675000", "sms"), ("+14254147167", "sms"),
("2028675111", "sms"), ("+14254147755", "sms"),
("2028675222", "sms"),
], ],
) )
def test_should_not_persist_or_send_notification_if_simulated_recipient( def test_should_not_persist_or_send_notification_if_simulated_recipient(