darkhelm/notifications-api
1
0
Fork 0
mirror of https://github.com/GSA/notifications-api.git synced 2025-12-23 08:51:30 -05:00
Code Issues Packages Projects Releases Wiki Activity

Make the errors in the process_sms_client_reponse more obvious by changing variable name.

Browse Source 
Added a missing test if mmg sends a CID (or reference) that is not a UUID.

NB: All client specific tests are in test_callbacks.
This commit is contained in:
Rebecca Law
2018-02-12 12:06:43 +00:00
parent e68604a600
commit fa8cd780b0
2 changed files with 16 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
app/notifications/process_client_response.py
View File

@@ -40,8 +40,8 @@ def process_sms_client_response(status, reference, client_name):
try:
uuid.UUID(reference, version=4)
except ValueError:
message = "{} callback with invalid reference {}".format(client_name, reference)
return success, message
errors = "{} callback with invalid reference {}".format(client_name, reference)
return success, errors
try:
response_parser = sms_response_mapper[client_name]
@@ -55,15 +55,14 @@ def process_sms_client_response(status, reference, client_name):
client_name, status, reference)
)
except KeyError:
process_for_status(notification_status='technical-failure', client_name=client_name, reference=reference)
_process_for_status(notification_status='technical-failure', client_name=client_name, reference=reference)
raise ClientException("{} callback failed: status {} not found.".format(client_name, status))
success = process_for_status(notification_status=notification_status, client_name=client_name, reference=reference)
success = _process_for_status(notification_status=notification_status, client_name=client_name, reference=reference)
return success, errors
def process_for_status(notification_status, client_name, reference):
def _process_for_status(notification_status, client_name, reference):
# record stats
notification = notifications_dao.update_notification_status_by_id(reference, notification_status)
if not notification: