darkhelm/notifications-api
1
0
Fork 0
mirror of https://github.com/GSA/notifications-api.git synced 2026-08-18 21:48:49 -04:00
Code Issues Packages Projects Releases Wiki Activity

Refactor code

Browse Source 
- removed redundant dao method
- also handle letter jobs
This commit is contained in:
Ken Tsang
2017-10-11 21:48:47 +01:00
parent c29fc8cfa4
commit f9a7a78e55
4 changed files with 15 additions and 27 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
tests/app/dao/notification_dao/test_notification_dao.py
View File

@@ -35,7 +35,6 @@ from app.dao.notifications_dao import (
dao_get_potential_notification_statistics_for_day,
dao_get_scheduled_notifications,
dao_get_template_usage,
dao_get_total_notifications_for_job_id,
dao_timeout_notifications,
dao_update_notification,
dao_update_notifications_for_job_to_sent_to_dvla,
@@ -2001,13 +2000,3 @@ def test_dao_get_notification_ememail_reply_toail_reply_for_notification(sample_
def test_dao_get_notification_email_reply_for_notification_where_no_mapping(notify_db_session, fake_uuid):
assert dao_get_notification_email_reply_for_notification(fake_uuid) is None
def test_dao_get_total_notifications_for_job_id(sample_job):
job = create_job(sample_job.template)
create_notification(sample_job.template, job=sample_job)
create_notification(sample_job.template, job=sample_job)
create_notification(sample_job.template, job=sample_job)
create_notification(sample_job.template, job=job)
assert dao_get_total_notifications_for_job_id(sample_job.id) == 3