darkhelm/notifications-api
1
0
Fork 0
mirror of https://github.com/GSA/notifications-api.git synced 2025-12-21 16:01:15 -05:00
Code Issues Packages Projects Releases Wiki Activity

Refactor code

Browse Source 
- removed redundant dao method
- also handle letter jobs
This commit is contained in:
Ken Tsang
2017-10-11 21:48:47 +01:00
parent c29fc8cfa4
commit f9a7a78e55
4 changed files with 15 additions and 27 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
tests/app/celery/test_tasks.py
View File

@@ -32,6 +32,7 @@ from app.models import (
EMAIL_TYPE,
JOB_STATUS_ERROR,
JOB_STATUS_FINISHED,
JOB_STATUS_SENT_TO_DVLA,
KEY_TYPE_NORMAL,
KEY_TYPE_TEAM,
KEY_TYPE_TEST,
@@ -1234,6 +1235,14 @@ def test_job_incomplete_raises_job_incomplete_error(sample_job):
assert e.value.message == 'Job {} did not complete'.format(sample_job.id)
def test_job_finished_does_not_raises_job_incomplete_error(sample_job):
sample_job.job_status = JOB_STATUS_FINISHED
@pytest.mark.parametrize('job_status,notification_type',
[
(JOB_STATUS_FINISHED, SMS_TYPE),
(JOB_STATUS_SENT_TO_DVLA, LETTER_TYPE)
]
)
def test_job_finished_does_not_raises_job_incomplete_error(
sample_job, job_status, notification_type):
sample_job.job_status = job_status
sample_job.template.template_type = notification_type
check_job_status(str(sample_job.id))