mirror of
https://github.com/GSA/notifications-api.git
synced 2025-12-23 00:41:35 -05:00
Fixed bug in test which was passing but not testing the services_dao
correctly The dao_fetch_monthly_historical_usage_by_template_for_service code wasn't being tested properly due to an bug on the test which created a notification with the same template and hence was not testing that a specific service would have a different template id. - Fixed the bug in the test - Update services_dao so that the service id check is made
This commit is contained in:
@@ -576,6 +576,7 @@ def dao_fetch_monthly_historical_usage_by_template_for_service(service_id, year)
|
|||||||
Template, Notification.template_id == Template.id,
|
Template, Notification.template_id == Template.id,
|
||||||
).filter(
|
).filter(
|
||||||
Notification.created_at >= start_date,
|
Notification.created_at >= start_date,
|
||||||
|
Notification.service_id == service_id
|
||||||
).group_by(
|
).group_by(
|
||||||
Notification.template_id,
|
Notification.template_id,
|
||||||
Template.name,
|
Template.name,
|
||||||
|
|||||||
@@ -1496,6 +1496,13 @@ def test_dao_fetch_monthly_historical_usage_by_template_for_service_only_returns
|
|||||||
notification_history(created_at=datetime(year, 2, day))
|
notification_history(created_at=datetime(year, 2, day))
|
||||||
|
|
||||||
service_two = create_service(service_name='other_service')
|
service_two = create_service(service_name='other_service')
|
||||||
|
template_two = create_sample_template(
|
||||||
|
notify_db,
|
||||||
|
notify_db_session,
|
||||||
|
template_name='1',
|
||||||
|
template_type='email',
|
||||||
|
service=service_two
|
||||||
|
)
|
||||||
|
|
||||||
daily_stats_template_usage_by_month()
|
daily_stats_template_usage_by_month()
|
||||||
|
|
||||||
@@ -1503,7 +1510,7 @@ def test_dao_fetch_monthly_historical_usage_by_template_for_service_only_returns
|
|||||||
notify_db,
|
notify_db,
|
||||||
notify_db_session,
|
notify_db_session,
|
||||||
service=sample_service,
|
service=sample_service,
|
||||||
template=template_one,
|
template=template_two,
|
||||||
created_at=datetime.utcnow()
|
created_at=datetime.utcnow()
|
||||||
)
|
)
|
||||||
|
|
||||||
|
|||||||
Reference in New Issue
Block a user