darkhelm/notifications-api
1
0
Fork 0
mirror of https://github.com/GSA/notifications-api.git synced 2026-09-05 15:08:25 -04:00
Code Issues Packages Projects Releases Wiki Activity

add info lost in action

Browse Source
This commit is contained in:
stvnrlly
2023-09-08 10:08:23 -04:00
parent 4a0d18a39b
commit f7782dad30
1 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
docs/adrs/0006-use-for-dependency-management.md
View File

@@ -1,4 +1,4 @@
# Use for dependency management # Use `poetry` for dependency management
Date: 2023-09-08 Date: 2023-09-08
@@ -10,11 +10,11 @@ Accepted
Our initial decision to use was primarily driven by [built-in support in Cloud Foundry](https://docs.cloudfoundry.org/buildpacks/python/index.html#pipenv). In practice, we have found that we still need to export the requirements file as part of the build process, removing the benefit. Our initial decision to use was primarily driven by [built-in support in Cloud Foundry](https://docs.cloudfoundry.org/buildpacks/python/index.html#pipenv). In practice, we have found that we still need to export the requirements file as part of the build process, removing the benefit.
Meanwhile, appears to be the informal standard around TTS. It's relatively simple for a dev to switch between them, but we do value consistency across the organization. Meanwhile, `poetry` appears to be the informal standard around TTS. It's relatively simple for a dev to switch between them, but we do value consistency across the organization.
### Decision ### Decision
Let's use . Let's use `poetry`.
### Consequences ### Consequences
@@ -29,7 +29,7 @@ We expect this to be a one-time cost.
We will need to: We will need to:
- Convert to - Convert to `poetry`
- Convert our CI/CD processes - Convert our CI/CD processes
- Ensure [proper Dependabot configuration](https://docs.github.com/en/code-security/dependabot/dependabot-version-updates/configuration-options-for-the-dependabot.yml-file) - Ensure [proper Dependabot configuration](https://docs.github.com/en/code-security/dependabot/dependabot-version-updates/configuration-options-for-the-dependabot.yml-file)
- Update developer documentation - Update developer documentation