Updates:

* Add endpoint to retrieve provider history
* Remove marshmallow schemas when updating a provider
* Include created by user when updating a provider

tests/app/provider_details/test_rest.py

@@ -1,7 +1,7 @@
 import pytest
 from flask import json
 
-from app.models import ProviderDetails
+from app.models import ProviderDetails, ProviderDetailsHistory
 
 from tests import create_authorization_header
 
@@ -45,7 +45,9 @@ def test_get_provider_details_contains_correct_fields(client, notify_db):
     )
     json_resp = json.loads(response.get_data(as_text=True))['provider_details']
     allowed_keys = {
-        "id", "display_name", "identifier", "priority", 'notification_type', "active", "version", "updated_at"
+        "id", "created_by", "display_name",
+        "identifier", "priority", 'notification_type',
+        "active", "version", "updated_at"
     }
     assert allowed_keys == set(json_resp[0].keys())
 
@@ -92,13 +94,46 @@ def test_should_be_able_to_update_status(client, restore_provider_details):
 def test_should_not_be_able_to_update_disallowed_fields(client, restore_provider_details, field, value):
     provider = ProviderDetails.query.first()
 
-    update_resp = client.post(
+    resp = client.post(
         '/provider-details/{}'.format(provider.id),
         headers=[('Content-Type', 'application/json'), create_authorization_header()],
         data=json.dumps({field: value})
     )
-    assert update_resp.status_code == 400
-    update_resp = json.loads(update_resp.get_data(as_text=True))
-    print(update_resp)
-    assert update_resp['message'][field][0] == 'Not permitted to be updated'
-    assert update_resp['result'] == 'error'
+    resp_json = json.loads(resp.get_data(as_text=True))
+
+    assert resp_json['message'][field][0] == 'Not permitted to be updated'
+    assert resp_json['result'] == 'error'
+    assert resp.status_code == 400
+
+
+def test_get_provider_versions_contains_correct_fields(client, notify_db):
+    provider = ProviderDetailsHistory.query.first()
+    response = client.get(
+        '/provider-details/{}/versions'.format(provider.id),
+        headers=[create_authorization_header()]
+    )
+    json_resp = json.loads(response.get_data(as_text=True))['data']
+    allowed_keys = {
+        "id", "created_by", "display_name",
+        "identifier", "priority", 'notification_type',
+        "active", "version", "updated_at"
+    }
+    assert allowed_keys == set(json_resp[0].keys())
+
+
+def test_update_provider_should_store_user_id(client, restore_provider_details, sample_user):
+    provider = ProviderDetails.query.first()
+
+    update_resp_1 = client.post(
+        '/provider-details/{}'.format(provider.id),
+        headers=[('Content-Type', 'application/json'), create_authorization_header()],
+        data=json.dumps({
+            'created_by': sample_user.id,
+            'active': False
+        })
+    )
+    assert update_resp_1.status_code == 200
+    update_resp_1 = json.loads(update_resp_1.get_data(as_text=True))['provider_details']
+    assert update_resp_1['identifier'] == provider.identifier
+    assert not update_resp_1['active']
+    assert not provider.active