- Added logging to indicate that we created the notification and that we sent the notification to a delivery queue.

- Small updates as recommended by review comments.

tests/app/v2/notifications/test_get_notifications.py

@@ -164,10 +164,11 @@ def test_get_notification_by_id_nonexistent_id(client, sample_notification):
     }
 
 
-def test_get_notification_by_id_invalid_id(client, sample_notification):
+@pytest.mark.parametrize("id", ["1234-badly-formatted-id-7890", "0"])
+def test_get_notification_by_id_invalid_id(client, sample_notification, id):
     auth_header = create_authorization_header(service_id=sample_notification.service_id)
     response = client.get(
-        path='/v2/notifications/1234-badly-formatted-id-7890',
+        path='/v2/notifications/{}'.format(id),
         headers=[('Content-Type', 'application/json'), auth_header])
 
     assert response.status_code == 404

tests/app/v2/notifications/test_post_notifications.py

@@ -159,7 +159,7 @@ def test_post_email_notification_returns_201(client, sample_email_template_with_
     ('07700 900111', 'sms'),
     ('07700 900222', 'sms')
 ])
-def test_should_not_persist_notification_or_send_notification_if_simulated_recipient(
+def test_should_not_persist_or_send_notification_if_simulated_recipient(
         client,
         recipient,
         notification_type,