darkhelm/notifications-api
1
0
Fork 0
mirror of https://github.com/GSA/notifications-api.git synced 2026-08-18 05:28:49 -04:00
Code Issues Packages Projects Releases Wiki Activity

If a sms or email has not been sent after 4 hours and 15 minutes then put it on the delivery queue.

Browse Source
This commit is contained in:
Rebecca Law
2018-03-23 15:38:35 +00:00
parent 9bf739007a
commit f596d17bf2
5 changed files with 105 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

38
tests/app/dao/notification_dao/test_notification_dao.py
View File

@@ -33,6 +33,7 @@ from app.dao.notifications_dao import (
dao_get_notification_by_reference,
dao_get_notifications_by_references,
dao_get_notification_history_by_reference,
notifications_not_yet_sent
)
from app.dao.services_dao import dao_update_service
from app.models import (
@@ -2216,3 +2217,40 @@ def test_dao_get_count_of_letters_to_process_for_date_ignores_test_keys(sample_l
count_for_date = dao_get_count_of_letters_to_process_for_date()
assert count_for_date == 2
@pytest.mark.parametrize("notification_type",
["letter", "email", "sms"]
)
def test_notifications_not_yet_sent(sample_service, notification_type):
older_than = 4 # number of seconds the notification can not be older than
template = create_template(service=sample_service, template_type=notification_type)
old_notification = create_notification(template=template,
created_at=datetime.utcnow() - timedelta(seconds=older_than),
status='created')
create_notification(template=template,
created_at=datetime.utcnow() - timedelta(seconds=older_than),
status='sending')
create_notification(template=template, created_at=datetime.utcnow(), status='created')
results = notifications_not_yet_sent(older_than, notification_type)
assert len(results) == 1
assert results[0] == old_notification
@pytest.mark.parametrize("notification_type",
["letter", "email", "sms"]
)
def test_notifications_not_yet_sent_return_no_rows(sample_service, notification_type):
older_than = 5 # number of seconds the notification can not be older than
template = create_template(service=sample_service, template_type=notification_type)
create_notification(template=template,
created_at=datetime.utcnow(),
status='created')
create_notification(template=template,
created_at=datetime.utcnow(),
status='sending')
create_notification(template=template, created_at=datetime.utcnow(), status='delivered')
results = notifications_not_yet_sent(older_than, notification_type)
assert len(results) == 0