darkhelm/notifications-api
1
0
Fork 0
mirror of https://github.com/GSA/notifications-api.git synced 2026-02-04 10:21:14 -05:00
Code Issues Packages Projects Releases Wiki Activity

treat sent as delivered in detailed service api

Browse Source 
this is for when we fetch the large blue numbers for viewing
notifications for an entire service
This commit is contained in:
Leo Hemsted
2017-04-28 11:56:12 +01:00
parent 56e5045e9a
commit f577e91134
2 changed files with 6 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
app/service/statistics.py
View File

@@ -48,7 +48,7 @@ def create_zeroed_stats_dicts():
def _update_statuses_from_row(update_dict, row): def _update_statuses_from_row(update_dict, row):
update_dict['requested'] += row.count update_dict['requested'] += row.count
if row.status == 'delivered': if row.status in ('delivered', 'sent'):
update_dict['delivered'] += row.count update_dict['delivered'] += row.count
elif row.status in ('failed', 'technical-failure', 'temporary-failure', 'permanent-failure'): elif row.status in ('failed', 'technical-failure', 'temporary-failure', 'permanent-failure'):
update_dict['failed'] += row.count update_dict['failed'] += row.count

5
tests/app/service/test_statistics.py
View File

@@ -30,6 +30,11 @@ StatsRow = collections.namedtuple('row', ('notification_type', 'status', 'count'
StatsRow('email', 'temporary-failure', 1), StatsRow('email', 'temporary-failure', 1),
StatsRow('email', 'permanent-failure', 1), StatsRow('email', 'permanent-failure', 1),
], [4, 0, 4], [0, 0, 0], [0, 0, 0]), ], [4, 0, 4], [0, 0, 0], [0, 0, 0]),
'convert_sent_to_delivered': ([
StatsRow('sms', 'sending', 1),
StatsRow('sms', 'delivered', 1),
StatsRow('sms', 'sent', 1),
], [0, 0, 0], [3, 2, 0], [0, 0, 0]),
}) })
def test_format_statistics(stats, email_counts, sms_counts, letter_counts): def test_format_statistics(stats, email_counts, sms_counts, letter_counts):