darkhelm/notifications-api
1
0
Fork 0
mirror of https://github.com/GSA/notifications-api.git synced 2026-02-01 07:35:34 -05:00
Code Issues Packages Projects Releases Wiki Activity

try fixing tests

Browse Source
This commit is contained in:
Kenneth Kehl
2024-10-01 11:36:09 -07:00
parent c2ed8f1686
commit f55c437c7d
2 changed files with 5 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
app/delivery/send_to_providers.py
View File

@@ -65,7 +65,9 @@ def send_sms_to_provider(notification):
temp = dict(zip(first_row, row)) temp = dict(zip(first_row, row))
personalisation[job_row] = temp personalisation[job_row] = temp
job_row = job_row + 1 job_row = job_row + 1
notification.personalisation = personalisation[notification.job_row_number] notification.personalisation = personalisation[notification.job_row_number]
else:
notification.personalisation = personalisation
service = SerialisedService.from_id(notification.service_id) service = SerialisedService.from_id(notification.service_id)
message_id = None message_id = None

3
tests/app/delivery/test_send_to_providers.py
View File

@@ -649,7 +649,8 @@ def test_should_update_billable_units_and_status_according_to_research_mode_and_
mock_personalisation = mocker.patch( mock_personalisation = mocker.patch(
"app.delivery.send_to_providers.get_personalisation_from_s3" "app.delivery.send_to_providers.get_personalisation_from_s3"
) )
mock_personalisation.return_value = {} # So we don't treat it as a one off and have to mock other things
mock_personalisation.return_value = {"ignore": "ignore"}
send_to_providers.send_sms_to_provider(notification) send_to_providers.send_sms_to_provider(notification)
assert notification.billable_units == billable_units assert notification.billable_units == billable_units