darkhelm/notifications-api
1
0
Fork 0
mirror of https://github.com/GSA/notifications-api.git synced 2026-08-15 07:18:09 -04:00
Code Issues Packages Projects Releases Wiki Activity

remove LETTER_TYPE from NOTIFICATION_TYPES

Browse Source
This commit is contained in:
stvnrlly
2023-02-24 15:30:05 -05:00
parent 0a3260c030
commit f55b7bf931
6 changed files with 24 additions and 44 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
tests/app/v2/notifications/test_get_notifications.py
View File

@@ -343,7 +343,7 @@ def test_get_all_notifications_filter_by_template_type_invalid_template_type(cli
assert json_response['status_code'] == 400
assert len(json_response['errors']) == 1
assert json_response['errors'][0]['message'] == "template_type orange is not one of [sms, email, letter]"
assert json_response['errors'][0]['message'] == "template_type orange is not one of [sms, email]"
def test_get_all_notifications_filter_by_single_status(client, sample_template):

4
tests/app/v2/notifications/test_notification_schemas.py
View File

@@ -67,7 +67,7 @@ def test_get_notifications_request_invalid_statuses(
def test_get_notifications_request_invalid_template_types(
invalid_template_types, valid_template_types
):
partial_error_template_type = "is not one of [sms, email, letter]"
partial_error_template_type = "is not one of [sms, email]"
with pytest.raises(ValidationError) as e:
validate({'template_type': invalid_template_types + valid_template_types}, get_notifications_request)
@@ -98,7 +98,7 @@ def test_get_notifications_request_invalid_statuses_and_template_types():
) in error_messages
for invalid_template_type in ["orange", "avocado"]:
assert "template_type {} is not one of [sms, email, letter]" \
assert "template_type {} is not one of [sms, email]" \
.format(invalid_template_type) in error_messages