darkhelm/notifications-api
1
0
Fork 0
mirror of https://github.com/GSA/notifications-api.git synced 2026-02-03 18:01:08 -05:00
Code Issues Packages Projects Releases Wiki Activity

code review feedback

Browse Source
This commit is contained in:
Kenneth Kehl
2023-08-15 14:50:41 -07:00
parent c5008da8df
commit f2f0e5a0f1
10 changed files with 2 additions and 165 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
tests/app/delivery/test_send_to_providers.py
View File

@@ -1,7 +1,7 @@
import json
import uuid
from collections import namedtuple
from datetime import datetime, timedelta
from datetime import datetime
from unittest.mock import ANY
import pytest
@@ -595,7 +595,6 @@ def test_should_set_notification_billable_units_and_reduces_provider_priority_if
mocker,
):
mocker.patch('app.aws_sns_client.send_sms', side_effect=Exception())
mock_reduce = mocker.patch('app.delivery.send_to_providers.dao_reduce_sms_provider_priority')
sample_notification.billable_units = 0
assert sample_notification.sent_by is None
@@ -608,7 +607,6 @@ def test_should_set_notification_billable_units_and_reduces_provider_priority_if
assert 1 == 1
assert sample_notification.billable_units == 1
mock_reduce.assert_called_once_with('sns', time_threshold=timedelta(minutes=1))
def test_should_send_sms_to_international_providers(