darkhelm/notifications-api
1
0
Fork 0
mirror of https://github.com/GSA/notifications-api.git synced 2026-08-19 14:08:47 -04:00
Code Issues Packages Projects Releases Wiki Activity

Add DAO function and endpoint for archiving letter contact blocks

Browse Source 
Added a new DAO function which archives letter contact blocks by
setting archived to True. This raises an ArchiveValidationError if
trying to archive the default letter block for a service or the default
letter contact block for a template.

Added a new endpoint for archiving letter contact blocks.
This commit is contained in:
Katie Smith
2018-04-26 10:00:11 +01:00
parent 472b86f3f4
commit f2d4bc795e
4 changed files with 120 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

32
tests/app/service/test_rest.py
View File

@@ -2733,6 +2733,38 @@ def test_update_service_letter_contact_returns_404_when_invalid_service_id(clien
assert result['message'] == 'No result found'
def test_delete_service_letter_contact_can_archive_letter_contact(admin_request, notify_db_session):
service = create_service()
create_letter_contact(service=service, contact_block='Edinburgh, ED1 1AA')
letter_contact = create_letter_contact(service=service, contact_block='Swansea, SN1 3CC', is_default=False)
admin_request.post(
'service.delete_service_letter_contact',
service_id=service.id,
letter_contact_id=letter_contact.id,
)
assert letter_contact.archived is True
def test_delete_service_letter_contact_returns_400_if_archiving_template_default(admin_request, notify_db_session):
service = create_service()
create_letter_contact(service=service, contact_block='Edinburgh, ED1 1AA')
letter_contact = create_letter_contact(service=service, contact_block='Swansea, SN1 3CC', is_default=False)
create_template(service=service, template_type='letter', reply_to=letter_contact.id)
response = admin_request.post(
'service.delete_service_letter_contact',
service_id=service.id,
letter_contact_id=letter_contact.id,
_expected_status=400
)
assert response == {
'message': 'You cannot delete the default letter contact block for a template',
'result': 'error'}
assert letter_contact.archived is False
def test_add_service_sms_sender_can_add_multiple_senders(client, notify_db_session):
service = create_service()
data = {