darkhelm/notifications-api
1
0
Fork 0
mirror of https://github.com/GSA/notifications-api.git synced 2026-08-20 14:29:25 -04:00
Code Issues Packages Projects Releases Wiki Activity

Done some stuff.

Browse Source 
Signed-off-by: Cliff Hill <Clifford.hill@gsa.gov>
This commit is contained in:
Cliff Hill
2024-02-20 14:40:40 -05:00
parent 8e8749a40e
commit f0e737472a
4 changed files with 87 additions and 71 deletions
Download Patch File Download Diff File Expand all files Collapse all files

74
tests/app/template/test_rest.py
View File

@@ -9,7 +9,7 @@ from freezegun import freeze_time
from notifications_utils import SMS_CHAR_COUNT_LIMIT
from app.dao.templates_dao import dao_get_template_by_id, dao_redact_template
from app.enums import ServicePermissionType, TemplateType
from app.enums import ServicePermissionType, TemplateProcessType, TemplateType
from app.models import Template, TemplateHistory
from tests import create_admin_authorization_header
from tests.app.db import create_service, create_template, create_template_folder
@@ -39,7 +39,7 @@ def test_should_create_a_new_template_for_a_service(
auth_header = create_admin_authorization_header()
response = client.post(
"/service/{}/template".format(service.id),
f"/service/{service.id}/template",
headers=[("Content-Type", "application/json"), auth_header],
data=data,
)
@@ -51,7 +51,7 @@ def test_should_create_a_new_template_for_a_service(
assert json_resp["data"]["service"] == str(service.id)
assert json_resp["data"]["id"]
assert json_resp["data"]["version"] == 1
assert json_resp["data"]["process_type"] == "normal"
assert json_resp["data"]["process_type"] == TemplateProcessType.NORMAL
assert json_resp["data"]["created_by"] == str(sample_user.id)
if subject:
assert json_resp["data"]["subject"] == "subject"
@@ -71,7 +71,7 @@ def test_create_a_new_template_for_a_service_adds_folder_relationship(
data = {
"name": "my template",
"template_type": "sms",
"template_type": TemplateType.SMS,
"content": "template <b>content</b>",
"service": str(sample_service.id),
"created_by": str(sample_service.users[0].id),
@@ -81,7 +81,7 @@ def test_create_a_new_template_for_a_service_adds_folder_relationship(
auth_header = create_admin_authorization_header()
response = client.post(
"/service/{}/template".format(sample_service.id),
f"/service/{sample_service.id}/template",
headers=[("Content-Type", "application/json"), auth_header],
data=data,
)
@@ -98,7 +98,7 @@ def test_create_template_should_return_400_if_folder_is_for_a_different_service(
data = {
"name": "my template",
"template_type": "sms",
"template_type": TemplateType.SMS,
"content": "template <b>content</b>",
"service": str(sample_service.id),
"created_by": str(sample_service.users[0].id),
@@ -108,7 +108,7 @@ def test_create_template_should_return_400_if_folder_is_for_a_different_service(
auth_header = create_admin_authorization_header()
response = client.post(
"/service/{}/template".format(sample_service.id),
f"/service/{sample_service.id}/template",
headers=[("Content-Type", "application/json"), auth_header],
data=data,
)
@@ -124,7 +124,7 @@ def test_create_template_should_return_400_if_folder_does_not_exist(
):
data = {
"name": "my template",
"template_type": "sms",
"template_type": TemplateType.SMS,
"content": "template <b>content</b>",
"service": str(sample_service.id),
"created_by": str(sample_service.users[0].id),
@@ -134,7 +134,7 @@ def test_create_template_should_return_400_if_folder_does_not_exist(
auth_header = create_admin_authorization_header()
response = client.post(
"/service/{}/template".format(sample_service.id),
f"/service/{sample_service.id}/template",
headers=[("Content-Type", "application/json"), auth_header],
data=data,
)
@@ -159,7 +159,7 @@ def test_should_raise_error_if_service_does_not_exist_on_create(
auth_header = create_admin_authorization_header()
response = client.post(
"/service/{}/template".format(fake_uuid),
f"/service/{fake_uuid}/template",
headers=[("Content-Type", "application/json"), auth_header],
data=data,
)
@@ -204,7 +204,7 @@ def test_should_raise_error_on_create_if_no_permission(
auth_header = create_admin_authorization_header()
response = client.post(
"/service/{}/template".format(service.id),
f"/service/{service.id}/template",
headers=[("Content-Type", "application/json"), auth_header],
data=data,
)
@@ -245,9 +245,7 @@ def test_should_be_error_on_update_if_no_permission(
auth_header = create_admin_authorization_header()
update_response = client.post(
"/service/{}/template/{}".format(
template_without_permission.service_id, template_without_permission.id
),
f"/service/{template_without_permission.service_id}/template/{template_without_permission.id}",
headers=[("Content-Type", "application/json"), auth_header],
data=data,
)
@@ -270,7 +268,7 @@ def test_should_error_if_created_by_missing(client, sample_user, sample_service)
auth_header = create_admin_authorization_header()
response = client.post(
"/service/{}/template".format(service_id),
f"/service/{service_id}/template",
headers=[("Content-Type", "application/json"), auth_header],
data=data,
)
@@ -286,7 +284,7 @@ def test_should_be_error_if_service_does_not_exist_on_update(client, fake_uuid):
auth_header = create_admin_authorization_header()
response = client.post(
"/service/{}/template/{}".format(fake_uuid, fake_uuid),
f"/service/{fake_uuid}/template/{fake_uuid}",
headers=[("Content-Type", "application/json"), auth_header],
data=data,
)
@@ -322,7 +320,7 @@ def test_must_have_a_subject_on_an_email_template(
def test_update_should_update_a_template(client, sample_user):
service = create_service()
template = create_template(service, template_type="sms")
template = create_template(service, template_type=TemplateType.SMS)
assert template.created_by == service.created_by
assert template.created_by != sample_user
@@ -335,7 +333,7 @@ def test_update_should_update_a_template(client, sample_user):
auth_header = create_admin_authorization_header()
update_response = client.post(
"/service/{}/template/{}".format(service.id, template.id),
f"/service/{service.id}/template/{template.id}",
headers=[("Content-Type", "application/json"), auth_header],
data=data,
)
@@ -373,9 +371,7 @@ def test_should_be_able_to_archive_template(client, sample_template):
auth_header = create_admin_authorization_header()
resp = client.post(
"/service/{}/template/{}".format(
sample_template.service.id, sample_template.id
),
f"/service/{sample_template.service.id}/template/{sample_template.id}",
headers=[("Content-Type", "application/json"), auth_header],
data=json_data,
)
@@ -431,14 +427,14 @@ def test_should_be_able_to_get_all_templates_for_a_service(
data_2 = json.dumps(data)
auth_header = create_admin_authorization_header()
client.post(
"/service/{}/template".format(sample_service.id),
f"/service/{sample_service.id}/template",
headers=[("Content-Type", "application/json"), auth_header],
data=data_1,
)
auth_header = create_admin_authorization_header()
client.post(
"/service/{}/template".format(sample_service.id),
f"/service/{sample_service.id}/template",
headers=[("Content-Type", "application/json"), auth_header],
data=data_2,
)
@@ -446,7 +442,7 @@ def test_should_be_able_to_get_all_templates_for_a_service(
auth_header = create_admin_authorization_header()
response = client.get(
"/service/{}/template".format(sample_service.id), headers=[auth_header]
f"/service/{sample_service.id}/template", headers=[auth_header]
)
assert response.status_code == 200
@@ -467,10 +463,12 @@ def test_should_get_only_templates_for_that_service(admin_request, notify_db_ses
id_3 = create_template(service_2).id
json_resp_1 = admin_request.get(
"template.get_all_templates_for_service", service_id=service_1.id
"template.get_all_templates_for_service",
service_id=service_1.id,
)
json_resp_2 = admin_request.get(
"template.get_all_templates_for_service", service_id=service_2.id
"template.get_all_templates_for_service",
service_id=service_2.id,
)
assert {template["id"] for template in json_resp_1["data"]} == {
@@ -580,7 +578,7 @@ def test_should_get_a_single_template(
)
response = client.get(
"/service/{}/template/{}".format(sample_service.id, template.id),
f"/service/{sample_service.id}/template/{template.id}",
headers=[create_admin_authorization_header()],
)
@@ -667,7 +665,7 @@ def test_should_return_empty_array_if_no_templates_for_service(client, sample_se
auth_header = create_admin_authorization_header()
response = client.get(
"/service/{}/template".format(sample_service.id), headers=[auth_header]
f"/service/{sample_service.id}/template", headers=[auth_header]
)
assert response.status_code == 200
@@ -681,7 +679,7 @@ def test_should_return_404_if_no_templates_for_service_with_id(
auth_header = create_admin_authorization_header()
response = client.get(
"/service/{}/template/{}".format(sample_service.id, fake_uuid),
f"/service/{sample_service.id}/template/{fake_uuid}",
headers=[auth_header],
)
@@ -715,7 +713,7 @@ def test_create_400_for_over_limit_content(
auth_header = create_admin_authorization_header()
response = client.post(
"/service/{}/template".format(sample_service.id),
f"/service/{sample_service.id}/template",
headers=[("Content-Type", "application/json"), auth_header],
data=data,
)
@@ -740,9 +738,7 @@ def test_update_400_for_over_limit_content(
)
auth_header = create_admin_authorization_header()
resp = client.post(
"/service/{}/template/{}".format(
sample_template.service.id, sample_template.id
),
f"/service/{sample_template.service.id}/template/{sample_template.id}",
headers=[("Content-Type", "application/json"), auth_header],
data=json_data,
)
@@ -766,9 +762,7 @@ def test_should_return_all_template_versions_for_service_and_template_id(
auth_header = create_admin_authorization_header()
resp = client.get(
"/service/{}/template/{}/versions".format(
sample_template.service_id, sample_template.id
),
f"/service/{sample_template.service_id}/template/{sample_template.id}/versions",
headers=[("Content-Type", "application/json"), auth_header],
)
assert resp.status_code == 200
@@ -792,9 +786,7 @@ def test_update_does_not_create_new_version_when_there_is_no_change(
"content": sample_template.content,
}
resp = client.post(
"/service/{}/template/{}".format(
sample_template.service_id, sample_template.id
),
f"/service/{sample_template.service_id}/template/{sample_template.id}",
data=json.dumps(data),
headers=[("Content-Type", "application/json"), auth_header],
)
@@ -808,9 +800,7 @@ def test_update_set_process_type_on_template(client, sample_template):
auth_header = create_admin_authorization_header()
data = {"process_type": "priority"}
resp = client.post(
"/service/{}/template/{}".format(
sample_template.service_id, sample_template.id
),
f"/service/{sample_template.service_id}/template/{sample_template.id}",
data=json.dumps(data),
headers=[("Content-Type", "application/json"), auth_header],
)